This is a live mirror of the Perl 5 development currently hosted at https://github.com/perl/perl5
The second argument to Move() is the destination, so cannot possibly
authorNicholas Clark <nick@ccl4.org>
Mon, 19 Sep 2005 21:02:02 +0000 (21:02 +0000)
committerNicholas Clark <nick@ccl4.org>
Mon, 19 Sep 2005 21:02:02 +0000 (21:02 +0000)
be const. Pesky casting in handy.h. Getting in the way of correctness.

p4raw-id: //depot/perl@25502

sv.c

diff --git a/sv.c b/sv.c
index 4ebdc10..24c497d 100644 (file)
--- a/sv.c
+++ b/sv.c
@@ -4606,7 +4606,7 @@ Perl_sv_force_normal_flags(pTHX_ register SV *sv, U32 flags)
            SvPV_set(sv, Nullch);
            SvLEN_set(sv, 0);
            SvGROW(sv, len + 1);
-           Move(pvx,SvPVX_const(sv),len,char);
+           Move(pvx,SvPVX(sv),len,char);
            *SvEND(sv) = '\0';
            unshare_hek(SvSHARED_HEK_FROM_PV(pvx));
        }
@@ -4665,7 +4665,7 @@ Perl_sv_chop(pTHX_ register SV *sv, register const char *ptr)
            const char *pvx = SvPVX_const(sv);
            const STRLEN len = SvCUR(sv);
            SvGROW(sv, len + 1);
-           Move(pvx,SvPVX_const(sv),len,char);
+           Move(pvx,SvPVX(sv),len,char);
            *SvEND(sv) = '\0';
        }
        SvIV_set(sv, 0);
@@ -7937,7 +7937,7 @@ Perl_sv_pvn_force_flags(pTHX_ SV *sv, STRLEN *lp, I32 flags)
                sv_unref(sv);
            SvUPGRADE(sv, SVt_PV);              /* Never FALSE */
            SvGROW(sv, len + 1);
-           Move(s,SvPVX_const(sv),len,char);
+           Move(s,SvPVX(sv),len,char);
            SvCUR_set(sv, len);
            *SvEND(sv) = '\0';
        }