Use NOT_REACHED for the impossible case.

The default case really is impossible because all the valid
enums values are already covered in the switch.

The NOT_REACHED; is for the compiler (from perl.h),
the /* NOTREACHED */ is for static analyzers.

diff --git a/regexp.h b/regexp.h
index db7ae8b..59d5ee2 100644 (file)
--- a/regexp.h
+++ b/regexp.h
@@ -382,7 +382,7 @@ get_regex_charset_name(const U32 flags, STRLEN* const lenp)
            *lenp = 2;
            return ASCII_MORE_RESTRICT_PAT_MODS;
         default:
-           return "?";     /* Unknown */
+           NOT_REACHED; /* NOTREACHED */
     }
 }