This is a live mirror of the Perl 5 development currently hosted at https://github.com/perl/perl5
Avoiding source code duplication for the lstat() on filehandle %s
authorNicholas Clark <nick@ccl4.org>
Thu, 3 Nov 2005 09:51:56 +0000 (09:51 +0000)
committerNicholas Clark <nick@ccl4.org>
Thu, 3 Nov 2005 09:51:56 +0000 (09:51 +0000)
warning also makes the object code slightly smaller.

p4raw-id: //depot/perl@25968

pp_sys.c

index 8682be3..d2a9618 100644 (file)
--- a/pp_sys.c
+++ b/pp_sys.c
@@ -2763,6 +2763,7 @@ PP(pp_stat)
        gv = cGVOP_gv;
        if (PL_op->op_type == OP_LSTAT) {
            if (gv != PL_defgv) {
+           do_fstat_warning_check:
                if (ckWARN(WARN_IO))
                    Perl_warner(aTHX_ packWARN(WARN_IO),
                        "lstat() on filehandle %s", GvENAME(gv));
@@ -2792,9 +2793,8 @@ PP(pp_stat)
        }
        else if (SvROK(sv) && SvTYPE(SvRV(sv)) == SVt_PVGV) {
            gv = (GV*)SvRV(sv);
-           if (PL_op->op_type == OP_LSTAT && ckWARN(WARN_IO))
-               Perl_warner(aTHX_ packWARN(WARN_IO),
-                       "lstat() on filehandle %s", GvENAME(gv));
+           if (PL_op->op_type == OP_LSTAT)
+               goto do_fstat_warning_check;
            goto do_fstat;
        }
        sv_setpv(PL_statname, SvPV_nolen_const(sv));