This is a live mirror of the Perl 5 development currently hosted at https://github.com/perl/perl5
PATCH: [perl #122126] BBC DBD::SQLite
authorKarl Williamson <khw@cpan.org>
Wed, 18 Jun 2014 19:01:41 +0000 (13:01 -0600)
committerKarl Williamson <khw@cpan.org>
Wed, 18 Jun 2014 19:38:40 +0000 (13:38 -0600)
This problem turns out to be a misspelling in two places of a compiler
definition.  Since the definition didn't exist (as it was misspelled),
the #ifdef failed.

I don't know how really to test this as it is locale collation, which
varies by locale, and we would be relying on vendor-supplied locales
which may be inconsistent between platforms.  I intend to tackle
improvements to collaction later this release cycle, and should come up
with tests at that time.  The failing tests in the module were comparing
the Perl sort results with those of the module, and finding they differ.

pp.c

diff --git a/pp.c b/pp.c
index c240b22..4e2d26a 100644 (file)
--- a/pp.c
+++ b/pp.c
@@ -2138,7 +2138,7 @@ PP(pp_sle)
     {
       dPOPTOPssrl;
       const int cmp =
-#ifdef USE_LC_COLLATE
+#ifdef USE_LOCALE_COLLATE
                       (IN_LC_RUNTIME(LC_COLLATE))
                      ? sv_cmp_locale_flags(left, right, 0)
                       :
@@ -2178,7 +2178,7 @@ PP(pp_scmp)
     {
       dPOPTOPssrl;
       const int cmp =
-#ifdef USE_LC_COLLATE
+#ifdef USE_LOCALE_COLLATE
                       (IN_LC_RUNTIME(LC_COLLATE))
                      ? sv_cmp_locale_flags(left, right, 0)
                      :