This is a live mirror of the Perl 5 development currently hosted at https://github.com/perl/perl5
pp_subst: remove a superflous PUTBACK/SPAGAIN
authorDavid Mitchell <davem@iabyn.com>
Sat, 5 Feb 2011 14:23:57 +0000 (14:23 +0000)
committerDavid Mitchell <davem@iabyn.com>
Sun, 6 Feb 2011 21:34:43 +0000 (21:34 +0000)
These were added around a mg_set() call before the stack-of-stacks
mechanism was introduced, which has made them redundant.

This is another step in making two branches of code more identical

pp_hot.c

index 88d42a5..5a920d4 100644 (file)
--- a/pp_hot.c
+++ b/pp_hot.c
@@ -2320,11 +2320,7 @@ PP(pp_subst)
        }
        (void)SvPOK_only_UTF8(TARG);
        TAINT_IF(rxtainted);
-       if (SvSMAGICAL(TARG)) {
-           PUTBACK;
-           mg_set(TARG);
-           SPAGAIN;
-       }
+       SvSETMAGIC(TARG);
        SvTAINT(TARG);
        if (doutf8)
            SvUTF8_on(TARG);