POSIX.xs: Avoid a leak in setlocale()

Tony Cook suggested this fix.

diff --git a/ext/POSIX/POSIX.xs b/ext/POSIX/POSIX.xs
index f46fedc..281bea8 100644 (file)
--- a/ext/POSIX/POSIX.xs
+++ b/ext/POSIX/POSIX.xs
@@ -2184,6 +2184,7 @@ setlocale(category, locale = 0)
 
         /* Save retval since subsequent setlocale() calls may overwrite it. */
         retval = savepv(retval);
+        SAVEFREEPV(retval);
 
         /* For locale == 0, we may have switched to NUMERIC_UNDERLYING.  Switch
          * back */
@@ -2259,8 +2260,6 @@ setlocale(category, locale = 0)
        }
     OUTPUT:
        RETVAL
-    CLEANUP:
-        Safefree(RETVAL);
 
 NV
 acos(x)

diff --git a/ext/POSIX/lib/POSIX.pm b/ext/POSIX/lib/POSIX.pm
index 2a5829c..e9c1375 100644 (file)
--- a/ext/POSIX/lib/POSIX.pm
+++ b/ext/POSIX/lib/POSIX.pm
@@ -4,7 +4,7 @@ use warnings;
 
 our ($AUTOLOAD, %SIGRT);
 
-our $VERSION = '1.63';
+our $VERSION = '1.64';
 
 require XSLoader;