lseek fd can be bad.

Coverity CID 104788

diff --git a/ext/POSIX/POSIX.xs b/ext/POSIX/POSIX.xs
index 670d8ec..514b514 100644 (file)
--- a/ext/POSIX/POSIX.xs
+++ b/ext/POSIX/POSIX.xs
@@ -3210,9 +3210,14 @@ lseek(fd, offset, whence)
        Off_t           offset
        int             whence
     CODE:
        Off_t           offset
        int             whence
     CODE:

-       Off_t pos = PerlLIO_lseek(fd, offset, whence);
-       RETVAL = sizeof(Off_t) > sizeof(IV)
-                ? newSVnv((NV)pos) : newSViv((IV)pos);
+       if (fd >= 0) {
+            Off_t pos = PerlLIO_lseek(fd, offset, whence);
+            RETVAL = sizeof(Off_t) > sizeof(IV)
+              ? newSVnv((NV)pos) : newSViv((IV)pos);
+        } else {
+            SETERRNO(EBADF,RMS_IFI);
+            RETVAL = newSViv(-1);
+        }

     OUTPUT:
        RETVAL
 
     OUTPUT:
        RETVAL