This is a live mirror of the Perl 5 development currently hosted at https://github.com/perl/perl5
fix harmless(ish) thinko in pp_return
authorDavid Mitchell <davem@iabyn.com>
Wed, 24 Jun 2015 07:52:14 +0000 (08:52 +0100)
committerDavid Mitchell <davem@iabyn.com>
Wed, 24 Jun 2015 07:52:14 +0000 (08:52 +0100)
My recently added Move() is moving an array of SV*'s, not SV**'s.
Spotted by Coverity.

pp_ctl.c

index 7f485d3..e6fdcf4 100644 (file)
--- a/pp_ctl.c
+++ b/pp_ctl.c
@@ -2455,7 +2455,7 @@ PP(pp_return)
         if (nargs) {
             if (cx->blk_gimme == G_ARRAY) {
                 /* shift return args to base of call stack frame */
-                Move(MARK + 1, oldsp + 1, nargs, SV**);
+                Move(MARK + 1, oldsp + 1, nargs, SV*);
                 PL_stack_sp  = oldsp + nargs;
             }
         }