This is a live mirror of the Perl 5 development currently hosted at https://github.com/perl/perl5
Revert "there is no obvious reason not to set flags"
authorKarl Williamson <khw@cpan.org>
Fri, 20 Mar 2020 18:22:55 +0000 (12:22 -0600)
committerKarl Williamson <khw@cpan.org>
Thu, 30 Jul 2020 21:12:09 +0000 (15:12 -0600)
This reverts commit 0ddecb91901742e7df780394170d4bf818ee1da8
as part of https://github.com/Perl/perl5/issues/15855

hv.c

diff --git a/hv.c b/hv.c
index 194c567..3aa1d42 100644 (file)
--- a/hv.c
+++ b/hv.c
@@ -392,7 +392,7 @@ Perl_hv_common(pTHX_ HV *hv, SV *keysv, const char *key, STRLEN klen,
        if (SvIsCOW_shared_hash(keysv)) {
            flags = HVhek_KEYCANONICAL | (is_utf8 ? HVhek_UTF8 : 0);
        } else {
-           flags = is_utf8 ? HVhek_UTF8 : 0;
+           flags = 0;
        }
     } else {
        is_utf8 = cBOOL(flags & HVhek_UTF8);
@@ -400,7 +400,8 @@ Perl_hv_common(pTHX_ HV *hv, SV *keysv, const char *key, STRLEN klen,
 
     if (action & HV_DELETE) {
        return (void *) hv_delete_common(hv, keysv, key, klen,
-                                        flags, action, hash);
+                                        flags | (is_utf8 ? HVhek_UTF8 : 0),
+                                        action, hash);
     }
 
     xhv = (XPVHV*)SvANY(hv);