This is a live mirror of the Perl 5 development currently hosted at https://github.com/perl/perl5
Fix the Configure escape with usecrosscompile but no targethost
authorNiko Tyni <ntyni@debian.org>
Sun, 10 Jan 2016 20:35:53 +0000 (22:35 +0200)
committerTony Cook <tony@develop-help.com>
Tue, 10 May 2016 00:46:13 +0000 (10:46 +1000)
Commit 97076f2 added a graceful exit to Configure when targethost is
not defined but usecrosscompile is. However, this is not reached because
there is a similar check a bit earlier that makes Configure bail out.

Make the earlier check warn instead of croaking.

The use case for this combination is supplying an external config.sh
suitable for the target platform, avoiding the need for configuration
probes.

Configure

index 5a353d6..33a6cac 100755 (executable)
--- a/Configure
+++ b/Configure
@@ -2973,7 +2973,7 @@ $define|true|[yY]*)
        *)  echo "Using targetarch $targetarch." >&4 ;;
        esac
        case "$targethost" in
-       '') echo "Targethost not defined." >&4; croak=y ;;
+       '') echo "Targethost not defined." >&4; croak=n ;;
        *)  echo "Using targethost $targethost." >&4
        esac
        locincpth=' '