This is a live mirror of the Perl 5 development currently hosted at https://github.com/perl/perl5
remove private flag 1 from OP_REGCOMP
authorDavid Mitchell <davem@iabyn.com>
Tue, 1 Nov 2011 13:57:50 +0000 (13:57 +0000)
committerDavid Mitchell <davem@iabyn.com>
Wed, 13 Jun 2012 12:25:51 +0000 (13:25 +0100)
When an OP_REGCOMP is hand-rolled, the op_private flags field is
set to 1. This has been so since 1993, but it is undocumented and appears
completely unused. So remove it.

op.c

diff --git a/op.c b/op.c
index e2607fe..cd5b0a7 100644 (file)
--- a/op.c
+++ b/op.c
@@ -4512,7 +4512,7 @@ Perl_pmruntime(pTHX_ OP *o, OP *expr, bool isreg, I32 floor)
        rcop->op_flags |= OPf_KIDS
                            | ((PL_hints & HINT_RE_EVAL) ? OPf_SPECIAL : 0)
                            | (reglist ? OPf_STACKED : 0);
-       rcop->op_private = 1;
+       rcop->op_private = 0;
        rcop->op_other = o;
        if (reglist)
            rcop->op_targ = pad_alloc(rcop->op_type, SVs_PADTMP);