This is a live mirror of the Perl 5 development currently hosted at
https://github.com/perl/perl5
https://perl5.git.perl.org
/
perl5.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
bad3a43
)
Local variable 'imode' hides a parameter of the same name
author
James E Keenan
<jkeenan@cpan.org>
Tue, 3 Dec 2019 02:50:17 +0000
(21:50 -0500)
committer
James E Keenan
<jkeenan@cpan.org>
Thu, 5 Dec 2019 03:14:10 +0000
(22:14 -0500)
LGTM static code analysis of Perl 5 source code issued this
recommendation. Implement fix.
https://lgtm.com/projects/g/Perl/perl5/rev/
ae73d7ec2329275a2dba4be24415743f884d9dfd
perlio.c
patch
|
blob
|
blame
|
history
diff --git
a/perlio.c
b/perlio.c
index
805959f
..
e6e4312
100644
(file)
--- a/
perlio.c
+++ b/
perlio.c
@@
-1490,7
+1490,7
@@
PerlIO_openn(pTHX_ const char *layers, const char *mode, int fd,
int imode, int perm, PerlIO *f, int narg, SV **args)
{
if (!f && narg == 1 && *args == &PL_sv_undef) {
- i
nt i
mode = PerlIOUnix_oflags(mode);
+ imode = PerlIOUnix_oflags(mode);
if (imode != -1 && (f = PerlIO_tmpfile_flags(imode))) {
if (!layers || !*layers)