Remove ‘Useless use of "re" pragma’ warning

It’s wrong.

$ ./perl -Ilib -le 'use re; print re::regmust(qr/foo/)'
Useless use of "re" pragma at -e line 1.
foo

Useless, eh?  OK, then:

$ ./perl -Ilib -le 'print re::regmust(qr/foo/)'
Undefined subroutine &re::regmust called at -e line 1.

diff --git a/ext/re/re.pm b/ext/re/re.pm
index 223a4cd..9111129 100644 (file)
--- a/ext/re/re.pm
+++ b/ext/re/re.pm
@@ -108,10 +108,6 @@ sub _load_unload {
 sub bits {
     my $on = shift;
     my $bits = 0;
-    unless (@_) {
-       require Carp;
-       Carp::carp("Useless use of \"re\" pragma"); 
-    }
    ARG:
     foreach my $idx (0..$#_){
         my $s=$_[$idx];

diff --git a/ext/re/t/re.t b/ext/re/t/re.t
index 8e06ef5..5fbf3fd 100644 (file)
--- a/ext/re/t/re.t
+++ b/ext/re/t/re.t
@@ -10,7 +10,7 @@ BEGIN {
 
 use strict;
 
-use Test::More tests => 13;
+use Test::More tests => 14;
 require_ok( 're' );
 
 # setcolor
@@ -72,3 +72,12 @@ sub Tgetent {
 sub Tputs {
        return $_[1];
 }
+
+package main;
+
+{
+  my $w;
+  local $SIG{__WARN__} = sub { warn shift; ++$w };
+  re->import();
+  is $w, undef, 'no warning for "use re;" (which is not useless)';
+}