This is a live mirror of the Perl 5 development currently hosted at https://github.com/perl/perl5
pp_match: fix confusing layout in an if()
authorDavid Mitchell <davem@iabyn.com>
Wed, 1 Sep 2010 16:05:22 +0000 (17:05 +0100)
committerDavid Mitchell <davem@iabyn.com>
Wed, 1 Sep 2010 16:08:47 +0000 (17:08 +0100)
The
    if ((    !global
rather than
    if (    (!global
made it hard to follow the precedence.
Tidy up the rest of the expression while I'm at it.

pp_hot.c

index 25a804a..daaed7a 100644 (file)
--- a/pp_hot.c
+++ b/pp_hot.c
@@ -1335,9 +1335,9 @@ PP(pp_match)
        /g matches against large strings.  So far a solution to this problem
        appears to be quite tricky.
        Test for the unsafe vars are TODO for now. */
-    if ((  !global && RX_NPARENS(rx)) 
-           || SvTEMP(TARG) || SvAMAGIC(TARG) || PL_sawampersand ||
-           (RX_EXTFLAGS(rx) & (RXf_EVAL_SEEN|RXf_PMf_KEEPCOPY)))
+    if (       (!global && RX_NPARENS(rx))
+           || SvTEMP(TARG) || SvAMAGIC(TARG) || PL_sawampersand
+           || (RX_EXTFLAGS(rx) & (RXf_EVAL_SEEN|RXf_PMf_KEEPCOPY)))
        r_flags |= REXEC_COPY_STR;
     if (SvSCREAM(TARG))
        r_flags |= REXEC_SCREAM;