This is a live mirror of the Perl 5 development currently hosted at https://github.com/perl/perl5
make utf8::upgrade() of a REGEXP a NOOP
authorDavid Mitchell <davem@iabyn.com>
Fri, 4 Aug 2017 07:51:49 +0000 (08:51 +0100)
committerDavid Mitchell <davem@iabyn.com>
Fri, 4 Aug 2017 08:12:10 +0000 (09:12 +0100)
commitfde84d2e7382e53c871f09ac324785f8accc38b3
tree85ef3244f857762419f5871e9634d5f8af65f306
parent97f6857b5c2a8f177be8d0a3fad2b17f2178e448
make utf8::upgrade() of a REGEXP a NOOP

RT #131821

After my recent commit

    v5.27.2-30-gdf6b4bd, "give REGEXP SVs the POK flag again",

    $r = qr/.../; utf8::upgrade($$r);

was setting the utf8 flag on the compiled REGEXP SV, which made no sense,
as the regex was already compiled and individual nodes would remain
non-utf8.

The POK flag was removed from REGEXPs in 5.18.0, but before then it didn't
seem to matter if the utf8 flag got set later, but it does now - it broke
a Tk test.
sv.c
t/op/qr.t