This is a live mirror of the Perl 5 development currently hosted at https://github.com/perl/perl5
Lookup overloaded assignment operators when trying to swap the arguments
authorRafael Garcia-Suarez <rgs@consttype.org>
Tue, 20 Mar 2012 08:17:02 +0000 (09:17 +0100)
committerRafael Garcia-Suarez <rgs@consttype.org>
Tue, 22 May 2012 07:51:28 +0000 (09:51 +0200)
commitf041cf0f9c6469c41de8b73d5f7b426710c3ff8b
tree48959402387eaa4240dbb8f6bccfdbdc4e8848bb
parent12578451ab3883e1692ecd2814459f3e9f083028
Lookup overloaded assignment operators when trying to swap the arguments

This is in the case where we search for an overloaded operator when
passing the AMGf_assign flag (we're executing an assignment operator
like +=).

At the very beginning of Perl_amagic_call, if the flag AMGf_noleft is
not passed, we first try to look up the overload method corresponding
to the assignment operator, then the normal one if fallback is
authorized. However, if this fails, when trying later to find
overload magic with the arguments swapped (if AMGf_noright is not
passed), this procedure was not used and we looked up directly the base
operation from which the assignment operator might be derived.
As a consequence of what an operator like += might have looked
autogenerated even when fallback=>0 was passed.

This change only necessitates a minor adjustment in lib/overload.t,
where an overloaded += method wasn't corresponding semantically to the
overloaded + method of the same class, which can be seen as a
pathological case.
gv.c
lib/overload.t