This is a live mirror of the Perl 5 development currently hosted at https://github.com/perl/perl5
Make kill() fatal for non-numeric pids
authorDavid Golden <dagolden@cpan.org>
Wed, 8 Jul 2009 17:28:54 +0000 (13:28 -0400)
committerRafael Garcia-Suarez <rgarciasuarez@gmail.com>
Thu, 9 Jul 2009 13:33:40 +0000 (15:33 +0200)
commite2c0f81f627951896aca833460887e6e8f20aba6
tree48420005abab0f5a8a1ac5404d4c53fe45f79fd8
parent32878f30ba1216461c8932946f0868cda9920d62
Make kill() fatal for non-numeric pids

As the debate over the best way to deal with floating point
pids stalled, this is just for non-numeric, which at least
squashes the bug even if it's not the Platonic ideal for
everyone.

It also doesn't address overloaded objects that might not have
IV, NV or PV appropriately set, but the approach mirrors what is
done elsewhere in doio.c so I recommend applying this patch now and
fixing the problem of overloaded objects at some other time when
it can be done more globally, either through an improvement or
replacement of looks_like_number

Also updated POD for kill when process is 0 or negative and
fixed Test-Harness tests that used kill with a string pid.
(Test-Harness test fix also submitted upstream)
doio.c
ext/Test-Harness/t/sample-tests/taint
ext/Test-Harness/t/sample-tests/taint_warn
pod/perl5110delta.pod
pod/perldiag.pod
pod/perlfunc.pod
t/op/kill0.t