This is a live mirror of the Perl 5 development currently hosted at https://github.com/perl/perl5
[perl #120657] Fix require PADTMP when @INC=(sub{},sub{})
authorFather Chrysostomos <sprout@cpan.org>
Sat, 4 Jan 2014 14:05:41 +0000 (06:05 -0800)
committerFather Chrysostomos <sprout@cpan.org>
Sat, 4 Jan 2014 14:06:03 +0000 (06:06 -0800)
commit901ee108fe1f8070e4722d8313bf202d0eb843b0
tree01871bec19b77e5310c10592d7a76fc35895a84e
parenta76c354d5bbd0beffab91da21869cc5a9ef5ee30
[perl #120657] Fix require PADTMP when @INC=(sub{},sub{})

It was passing a freed scalar to subsequent subs, breaking
Test::Without::Module:

sub fake_module {
    my (undef,$module_file) = @_;
    !1
}
unshift @INC, (\&fake_module)x2;
require "${\'whatever'}";
__END__
panic: attempt to copy freed scalar 7fe8d0829820 to 7fe8d082a0f0 at - line 3.

Obviously, doing:

    SAVETMPS;
    ...
    nsv = sv_newmortal();
    ...
    FREETMPS; # free all tmps created since SAVETMPS

inside a loop that only assigns to nsv the first time through will
cause nsv to point to a freed scalar on subsequent iterations.

It was stupid of me to make that mistake in commit 9ffd39a to
begin with.

The extra file name SV here will simply have to last until the
require call finishes, something I was trying to avoid by putting it
after SAVETMPS.
pp_ctl.c
t/op/inccode.t