This is a live mirror of the Perl 5 development currently hosted at https://github.com/perl/perl5
S_doparseform() should return void, not OP*, as it should use Perl_die not DIE
authorNicholas Clark <nick@ccl4.org>
Tue, 26 Apr 2011 10:02:45 +0000 (11:02 +0100)
committerNicholas Clark <nick@ccl4.org>
Wed, 18 May 2011 18:11:03 +0000 (19:11 +0100)
commit75f63940310204509f2935729c2b989e3be7c00d
tree4da30ce68217ea31dd520fafb4ddcaf5a333d6b7
parente72ec78c220651d4143e9b3398dd951c602d880e
S_doparseform() should return void, not OP*, as it should use Perl_die not DIE

a1b950687051c32e added an error condition in S_doparseform() but used DIE(...)
to report it. DIE is defined as C<return Perl_die>, which acts as a hint to the
compiler about the control flow [as Perl_die() never returns], but also forces
the return type to be OP *. Whilst this is appropriate for pp functions, it's
not for S_doparseform() - a1b950687051c32e had to change the return type to OP*
and return NULL, just to appease DIE(). Hence use Perl_die() instead, remove
return statements, and remove the didn't-return-NULL (dead) code from
pp_formline.
embed.fnc
pp_ctl.c
proto.h