This is a live mirror of the Perl 5 development currently hosted at https://github.com/perl/perl5
Replace multiple 'use vars' by 'our' in dist
authorNicolas R <atoomic@cpan.org>
Tue, 12 Sep 2017 19:20:25 +0000 (13:20 -0600)
committerTodd Rinaldo <toddr@cpan.org>
Sat, 11 Nov 2017 07:07:18 +0000 (01:07 -0600)
commit1a58b39af83e11fcbeef7ae4cd90c565b1f6b8cb
tree542b8e3ec768e2b3a533354d694d53c6c161e8e5
parent33394adc9b131beee7dbbaf29bc7e8e02900f654
Replace multiple 'use vars' by 'our' in dist

Using vars pragma is discouraged and has been superseded
by 'our' declarations available in Perl v5.6.0 or later.

Additionally using 'vars' pragma increase the memory consumption of a
program by about 700 kB for no good reason.

This commit is about replacing the usage of 'vars' pragma
by 'our' in blead where it makes sense. ( leaving 'cpan' directory
outside of the scope )

-- using vars
perl -e 'use vars qw(@ISA $AUTOLOAD $VERSION); print qx{grep RSS /proc/$$/status} '
VmRSS:        2588 kB

-- using our instead
perl -e 'our (@ISA, $AUTOLOAD, $VERSION); print qx{grep RSS /proc/$$/status} '
VmRSS:        1864 kB
62 files changed:
dist/Attribute-Handlers/lib/Attribute/Handlers.pm
dist/Data-Dumper/t/pair.t
dist/Dumpvalue/t/Dumpvalue.t
dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder.pm
dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Unix.pm
dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/VMS.pm
dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Windows.pm
dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/aix.pm
dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/android.pm
dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/cygwin.pm
dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/darwin.pm
dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/dec_osf.pm
dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/os2.pm
dist/ExtUtils-CBuilder/t/01-basic.t
dist/Filter-Simple/lib/Filter/Simple.pm
dist/I18N-LangTags/lib/I18N/LangTags.pm
dist/I18N-LangTags/lib/I18N/LangTags/Detect.pm
dist/I18N-LangTags/lib/I18N/LangTags/List.pm
dist/Locale-Maketext/lib/Locale/Maketext.pm
dist/Locale-Maketext/lib/Locale/Maketext.pod
dist/Locale-Maketext/t/60_super.t
dist/Locale-Maketext/t/70_fail_auto.t
dist/Module-CoreList/identify-dependencies
dist/Module-CoreList/lib/Module/CoreList.pm
dist/Module-CoreList/lib/Module/CoreList/TieHashDelta.pm
dist/Module-CoreList/lib/Module/CoreList/Utils.pm
dist/Net-Ping/lib/Net/Ping.pm
dist/PathTools/Cwd.pm
dist/PathTools/lib/File/Spec.pm
dist/PathTools/lib/File/Spec/AmigaOS.pm
dist/PathTools/lib/File/Spec/Cygwin.pm
dist/PathTools/lib/File/Spec/Epoc.pm
dist/PathTools/lib/File/Spec/Functions.pm
dist/PathTools/lib/File/Spec/Mac.pm
dist/PathTools/lib/File/Spec/OS2.pm
dist/PathTools/lib/File/Spec/Unix.pm
dist/PathTools/lib/File/Spec/VMS.pm
dist/PathTools/lib/File/Spec/Win32.pm
dist/PathTools/t/Spec.t
dist/Safe/t/safe1.t
dist/Safe/t/safe2.t
dist/SelfLoader/lib/SelfLoader.pm
dist/Storable/Storable.pm
dist/Storable/t/canonical.t
dist/Storable/t/code.t
dist/Storable/t/downgrade.t
dist/Storable/t/interwork56.t
dist/Storable/t/malice.t
dist/Storable/t/recurse.t
dist/Storable/t/testlib.pl
dist/Storable/t/tied.t
dist/Storable/t/weak.t
dist/Test/lib/Test.pm
dist/Test/t/fail.t
dist/Test/t/onfail.t
dist/XSLoader/XSLoader_pm.PL
dist/base/lib/base.pm
dist/base/lib/fields.pm
dist/base/t/base.t
dist/base/t/fields-5_6_0.t
dist/base/t/fields-5_8_0.t
dist/constant/t/constant.t