X-Git-Url: https://perl5.git.perl.org/perl5.git/blobdiff_plain/5912531faf421dc0ccf67f600667fb8051dc62a5..6b3d80d96dabea375ff3bbdab42ec146622664dc:/perly.c diff --git a/perly.c b/perly.c index ad01d38..eff36d1 100644 --- a/perly.c +++ b/perly.c @@ -1,6 +1,6 @@ /* perly.c * - * Copyright (c) 2004, 2005, 2006 Larry Wall and others + * Copyright (c) 2004, 2005, 2006, 2007, 2008 by Larry Wall and others * * You may distribute under the terms of either the GNU General Public * License or the Artistic License, as specified in the README file. @@ -45,7 +45,6 @@ typedef signed char yysigned_char; # define YYSIZE_T size_t -#define YYEMPTY (-2) #define YYEOF 0 #define YYTERROR 1 @@ -106,13 +105,13 @@ yy_stack_print (pTHX_ const yy_parser *parser) { const yy_stack_frame *ps, *min; - min = parser->ps - 8; - if (min <= &parser->stack[0]) - min = &parser->stack[0] + 1; + min = parser->ps - 8 + 1; + if (min <= parser->stack) + min = parser->stack + 1; PerlIO_printf(Perl_debug_log, "\nindex:"); for (ps = min; ps <= parser->ps; ps++) - PerlIO_printf(Perl_debug_log, " %8d", ps - &parser->stack[0]); + PerlIO_printf(Perl_debug_log, " %8d", (int)(ps - parser->stack)); PerlIO_printf(Perl_debug_log, "\nstate:"); for (ps = min; ps <= parser->ps; ps++) @@ -187,52 +186,50 @@ do { \ # define YY_REDUCE_PRINT(Rule) #endif /* !DEBUGGING */ - -/* YYINITDEPTH -- initial size of the parser's stacks. */ -#define YYINITDEPTH 200 - /* called during cleanup (via SAVEDESTRUCTOR_X) to free any items on the * parse stack, thus avoiding leaks if we die */ static void -S_clear_yystack(pTHX_ const void *p) +S_clear_yystack(pTHX_ const yy_parser *parser) { - yy_parser *parser = (yy_parser*) SvPVX((SV*)p); yy_stack_frame *ps = parser->ps; - int i; + int i = 0; - if (ps == &parser->stack[0]) + if (!parser->stack || ps == parser->stack) return; YYDPRINTF ((Perl_debug_log, "clearing the parse stack\n")); - /* Freeing ops on the stack, and the op_latefree/op_latefreed flags: + /* Freeing ops on the stack, and the op_latefree / op_latefreed / + * op_attached flags: * * When we pop tokens off the stack during error recovery, or when * we pop all the tokens off the stack after a die during a shift or - * reduce (ie Perl_croak somewhere in yylex(), or in one of the - * newFOO() functions, then its possible that some of these tokens are + * reduce (i.e. Perl_croak somewhere in yylex() or in one of the + * newFOO() functions), then it's possible that some of these tokens are * of type opval, pointing to an OP. All these ops are orphans; each is * its own miniature subtree that has not yet been attached to a - * larger tree. In this case, we shoould clearly free the op (making - * sure, for each op we free thyat we have PL_comppad pointing to the + * larger tree. In this case, we should clearly free the op (making + * sure, for each op we free that we have PL_comppad pointing to the * right place for freeing any SVs attached to the op in threaded * builds. * - * However, there is a particular problem if we die in newFOO called + * However, there is a particular problem if we die in newFOO() called * by a reducing action; e.g. * * foo : bar baz boz * { $$ = newFOO($1,$2,$3) } * * where - * OP *newFOO { .... croak .... } + * OP *newFOO { ....; if (...) croak; .... } * * In this case, when we come to clean bar baz and boz off the stack, * we don't know whether newFOO() has already: * * freed them - * * left them as it + * * left them as is * * attached them to part of a larger tree + * * attached them to PL_compcv + * * attached them to PL_compcv then freed it (as in BEGIN {die } ) * * To get round this problem, we set the flag op_latefree on every op * that gets pushed onto the parser stack. If op_free() sees this @@ -243,26 +240,57 @@ S_clear_yystack(pTHX_ const void *p) * reduced, call op_free with op_latefree=1. This ensures that all ops * hanging off these op are freed, but the reducing ops themselces are * just undefed. Then we set op_latefreed=0 on *all* ops on the stack - * and free them. A little though should convince you that this - * two-part approach to the reducing ops should handle all three cases - * above safely. - */ + * and free them. A little thought should convince you that this + * two-part approach to the reducing ops should handle the first three + * cases above safely. + * + * In the case of attaching to PL_compcv (currently just newATTRSUB + * does this), then we set the op_attached flag on the op that has + * been so attached, then avoid doing the final op_free during + * cleanup, on the assumption that it will happen (or has already + * happened) when PL_compcv is freed. + * + * Note this is fairly fragile mechanism. A more robust approach + * would be to use two of these flag bits as 2-bit reference count + * field for each op, indicating whether it is pointed to from: + * * a parent op + * * the parser stack + * * a CV + * but this would involve reworking all code (core and external) that + * manipulate op trees. + * + * XXX DAPM 17/1/07 I've decided its too fragile for now, and so have + * disabled it */ + +#define DISABLE_STACK_FREE - /* free any reducing ops (1st pass) */ + +#ifdef DISABLE_STACK_FREE + ps -= parser->yylen; + PERL_UNUSED_VAR(i); +#else + /* clear any reducing ops (1st pass) */ for (i=0; i< parser->yylen; i++) { + LEAVE_SCOPE(ps[-i].savestack_ix); if (yy_type_tab[yystos[ps[-i].state]] == toketype_opval && ps[-i].val.opval) { - if (ps[-i].comppad != PL_comppad) { - PAD_RESTORE_LOCAL(ps[-i].comppad); + if ( ! (ps[-i].val.opval->op_attached + && !ps[-i].val.opval->op_latefreed)) + { + if (ps[-i].comppad != PL_comppad) { + PAD_RESTORE_LOCAL(ps[-i].comppad); + } + op_free(ps[-i].val.opval); } - op_free(ps[-i].val.opval); } } +#endif /* now free whole the stack, including the just-reduced ops */ - while (ps > &parser->stack[0]) { + while (ps > parser->stack) { + LEAVE_SCOPE(ps->savestack_ix); if (yy_type_tab[yystos[ps->state]] == toketype_opval && ps->val.opval) { @@ -270,15 +298,17 @@ S_clear_yystack(pTHX_ const void *p) PAD_RESTORE_LOCAL(ps->comppad); } YYDPRINTF ((Perl_debug_log, "(freeing op)\n")); +#ifndef DISABLE_STACK_FREE ps->val.opval->op_latefree = 0; - op_free(ps->val.opval); + if (!(ps->val.opval->op_attached && !ps->val.opval->op_latefreed)) +#endif + op_free(ps->val.opval); } ps--; } } - /*----------. | yyparse. | `----------*/ @@ -296,16 +326,15 @@ Perl_yyparse (pTHX) int yyresult; /* Lookahead token as an internal (translated) token number. */ - int yytoken; + int yytoken = 0; - SV *parser_sv; /* SV whose PVX holds the parser object */ register yy_parser *parser; /* the parser object */ register yy_stack_frame *ps; /* current parser stack frame */ #define YYPOPSTACK parser->ps = --ps #define YYPUSHSTACK parser->ps = ++ps - /* The variables used to return semantic value and location from the + /* The variable used to return semantic value and location from the action routines: ie $$. */ YYSTYPE yyval; @@ -318,25 +347,11 @@ Perl_yyparse (pTHX) YYDPRINTF ((Perl_debug_log, "Starting parse\n")); - ENTER; /* force stack free before we return */ - SAVEVPTR(PL_parser); - - parser_sv = newSV(sizeof(yy_parser) - + (YYINITDEPTH-1) * sizeof(yy_stack_frame)); - SAVEFREESV(parser_sv); - PL_parser = parser = (yy_parser*) SvPVX(parser_sv); - ps = (yy_stack_frame*) &parser->stack[0]; - parser->ps = ps; - - parser->stack_size = YYINITDEPTH; + parser = PL_parser; + ps = parser->ps; - /* cleanup the parse stack on premature exit */ - SAVEDESTRUCTOR_X(S_clear_yystack, (void*) parser_sv); - - - ps->state = 0; - parser->yyerrstatus = 0; - parser->yychar = YYEMPTY; /* Cause a token to be read. */ + ENTER; /* force parser stack cleanup before we return */ + SAVEDESTRUCTOR_X(S_clear_yystack, parser); /*------------------------------------------------------------. | yynewstate -- Push a new state, which is found in yystate. | @@ -347,28 +362,26 @@ Perl_yyparse (pTHX) YYDPRINTF ((Perl_debug_log, "Entering state %d\n", yystate)); +#ifndef DISABLE_STACK_FREE if (yy_type_tab[yystos[yystate]] == toketype_opval && ps->val.opval) { ps->val.opval->op_latefree = 1; ps->val.opval->op_latefreed = 0; } +#endif parser->yylen = 0; { - size_t size = ps - &parser->stack[0] + 1; + size_t size = ps - parser->stack + 1; /* grow the stack? We always leave 1 spare slot, * in case of a '' -> 'foo' reduction */ - if (size >= parser->stack_size - 1) { + if (size >= (size_t)parser->stack_size - 1) { /* this will croak on insufficient memory */ parser->stack_size *= 2; - PL_parser = parser = - (yy_parser*) SvGROW(parser_sv, sizeof(yy_parser) - + (parser->stack_size-1) * sizeof(yy_stack_frame)); - - /* readdress any pointers into realloced parser object */ - ps = parser->ps = &parser->stack[0] + size -1; + Renew(parser->stack, parser->stack_size, yy_stack_frame); + ps = parser->ps = parser->stack + size -1; YYDPRINTF((Perl_debug_log, "parser stack size increased to %lu frames\n", @@ -439,6 +452,7 @@ Perl_yyparse (pTHX) ps->state = yyn; ps->val = parser->yylval; ps->comppad = PL_comppad; + ps->savestack_ix = PL_savestack_ix; #ifdef DEBUGGING ps->name = (const char *)(yytname[yytoken]); #endif @@ -511,6 +525,7 @@ Perl_yyparse (pTHX) } +#ifndef DISABLE_STACK_FREE /* any just-reduced ops with the op_latefreed flag cleared need to be * freed; the rest need the flag resetting */ { @@ -525,6 +540,7 @@ Perl_yyparse (pTHX) } } } +#endif parser->ps = ps -= (parser->yylen-1); @@ -534,6 +550,7 @@ Perl_yyparse (pTHX) ps->val = yyval; ps->comppad = PL_comppad; + ps->savestack_ix = PL_savestack_ix; #ifdef DEBUGGING ps->name = (const char *)(yytname [yyr1[yyn]]); #endif @@ -569,8 +586,9 @@ Perl_yyparse (pTHX) /* Pop the error token. */ YYPOPSTACK; /* Pop the rest of the stack. */ - while (ps > &parser->stack[0]) { + while (ps > parser->stack) { YYDSYMPRINTF ("Error: popping", yystos[ps->state], &ps->val); + LEAVE_SCOPE(ps->savestack_ix); if (yy_type_tab[yystos[ps->state]] == toketype_opval && ps->val.opval) { @@ -614,10 +632,11 @@ Perl_yyparse (pTHX) } /* Pop the current state because it cannot handle the error token. */ - if (ps == &parser->stack[0]) + if (ps == parser->stack) YYABORT; YYDSYMPRINTF ("Error: popping", yystos[ps->state], &ps->val); + LEAVE_SCOPE(ps->savestack_ix); if (yy_type_tab[yystos[ps->state]] == toketype_opval && ps->val.opval) { YYDPRINTF ((Perl_debug_log, "(freeing op)\n")); if (ps->comppad != PL_comppad) { @@ -641,6 +660,7 @@ Perl_yyparse (pTHX) ps->state = yyn; ps->val = parser->yylval; ps->comppad = PL_comppad; + ps->savestack_ix = PL_savestack_ix; #ifdef DEBUGGING ps->name =""; #endif @@ -653,7 +673,7 @@ Perl_yyparse (pTHX) `-------------------------------------*/ yyacceptlab: yyresult = 0; - parser->ps = &parser->stack[0]; /* disable cleanup */ + parser->ps = parser->stack; /* disable cleanup */ goto yyreturn; /*-----------------------------------. @@ -664,7 +684,7 @@ Perl_yyparse (pTHX) goto yyreturn; yyreturn: - LEAVE; /* force stack free before we return */ + LEAVE; /* force parser stack cleanup before we return */ return yyresult; }