X-Git-Url: https://perl5.git.perl.org/perl5.git/blobdiff_plain/20822f61cc01ab34be1e17db483aceb9d5ec8fb7..17a3df4c6a07533e2c03c46fdd27e3ee295d61d0:/t/op/method.t

diff --git a/t/op/method.t b/t/op/method.t
old mode 100755
new mode 100644
index be4df75..b602ca2
--- a/t/op/method.t
+++ b/t/op/method.t
@@ -6,10 +6,11 @@
 
 BEGIN {
     chdir 't' if -d 't';
-    @INC = '../lib';
+    @INC = qw(. ../lib);
+    require "test.pl";
 }
 
-print "1..53\n";
+print "1..79\n";
 
 @A::ISA = 'B';
 @B::ISA = 'C';
@@ -17,67 +18,63 @@ print "1..53\n";
 sub C::d {"C::d"}
 sub D::d {"D::d"}
 
-my $cnt = 0;
-sub test {
-  print "# got `$_[0]', expected `$_[1]'\nnot " unless $_[0] eq $_[1]; 
-  # print "not " unless shift eq shift;
-  print "ok ", ++$cnt, "\n"
-}
-
 # First, some basic checks of method-calling syntax:
 $obj = bless [], "Pack";
 sub Pack::method { shift; join(",", "method", @_) }
 $mname = "method";
 
-test(Pack->method("a","b","c"), "method,a,b,c");
-test(Pack->$mname("a","b","c"), "method,a,b,c");
-test(method Pack ("a","b","c"), "method,a,b,c");
-test((method Pack "a","b","c"), "method,a,b,c");
+is(Pack->method("a","b","c"), "method,a,b,c");
+is(Pack->$mname("a","b","c"), "method,a,b,c");
+is(method Pack ("a","b","c"), "method,a,b,c");
+is((method Pack "a","b","c"), "method,a,b,c");
+
+is(Pack->method(), "method");
+is(Pack->$mname(), "method");
+is(method Pack (), "method");
+is(Pack->method, "method");
+is(Pack->$mname, "method");
+is(method Pack, "method");
 
-test(Pack->method(), "method");
-test(Pack->$mname(), "method");
-test(method Pack (), "method");
-test(Pack->method, "method");
-test(Pack->$mname, "method");
-test(method Pack, "method");
+is($obj->method("a","b","c"), "method,a,b,c");
+is($obj->$mname("a","b","c"), "method,a,b,c");
+is((method $obj ("a","b","c")), "method,a,b,c");
+is((method $obj "a","b","c"), "method,a,b,c");
 
-test($obj->method("a","b","c"), "method,a,b,c");
-test($obj->$mname("a","b","c"), "method,a,b,c");
-test((method $obj ("a","b","c")), "method,a,b,c");
-test((method $obj "a","b","c"), "method,a,b,c");
+is($obj->method(0), "method,0");
+is($obj->method(1), "method,1");
 
-test($obj->method(), "method");
-test($obj->$mname(), "method");
-test((method $obj ()), "method");
-test($obj->method, "method");
-test($obj->$mname, "method");
-test(method $obj, "method");
+is($obj->method(), "method");
+is($obj->$mname(), "method");
+is((method $obj ()), "method");
+is($obj->method, "method");
+is($obj->$mname, "method");
+is(method $obj, "method");
 
-test( A->d, "C::d");		# Update hash table;
+is( A->d, "C::d");		# Update hash table;
 
 *B::d = \&D::d;			# Import now.
-test (A->d, "D::d");		# Update hash table;
+is(A->d, "D::d");		# Update hash table;
 
 {
     local @A::ISA = qw(C);	# Update hash table with split() assignment
-    test (A->d, "C::d");
+    is(A->d, "C::d");
     $#A::ISA = -1;
-    test (eval { A->d } || "fail", "fail");
+    is(eval { A->d } || "fail", "fail");
 }
-test (A->d, "D::d");
+is(A->d, "D::d");
 
 {
     local *B::d;
     eval 'sub B::d {"B::d1"}';	# Import now.
-    test (A->d, "B::d1");	# Update hash table;
+    is(A->d, "B::d1");	# Update hash table;
     undef &B::d;
-    test ((eval { A->d }, ($@ =~ /Undefined subroutine/)), 1);
+    is((eval { A->d }, ($@ =~ /Undefined subroutine/)), 1);
 }
 
-test (A->d, "D::d");		# Back to previous state
+is(A->d, "D::d");		# Back to previous state
 
 eval 'sub B::d {"B::d2"}';	# Import now.
-test (A->d, "B::d2");		# Update hash table;
+is(A->d, "B::d2");		# Update hash table;
 
 # What follows is hardly guarantied to work, since the names in scripts
 # are already linked to "pruned" globs. Say, `undef &B::d' if it were
@@ -85,30 +82,30 @@ test (A->d, "B::d2");		# Update hash table;
 
 undef &B::d;
 delete $B::{d};
-test (A->d, "C::d");		# Update hash table;
+is(A->d, "C::d");		# Update hash table;
 
 eval 'sub B::d {"B::d3"}';	# Import now.
-test (A->d, "B::d3");		# Update hash table;
+is(A->d, "B::d3");		# Update hash table;
 
 delete $B::{d};
 *dummy::dummy = sub {};		# Mark as updated
-test (A->d, "C::d");
+is(A->d, "C::d");
 
 eval 'sub B::d {"B::d4"}';	# Import now.
-test (A->d, "B::d4");		# Update hash table;
+is(A->d, "B::d4");		# Update hash table;
 
 delete $B::{d};			# Should work without any help too
-test (A->d, "C::d");
+is(A->d, "C::d");
 
 {
     local *C::d;
-    test (eval { A->d } || "nope", "nope");
+    is(eval { A->d } || "nope", "nope");
 }
-test (A->d, "C::d");
+is(A->d, "C::d");
 
 *A::x = *A::d;			# See if cache incorrectly follows synonyms
 A->d;
-test (eval { A->x } || "nope", "nope");
+is(eval { A->x } || "nope", "nope");
 
 eval <<'EOF';
 sub C::e;
@@ -135,14 +132,14 @@ sub C::AUTOLOAD {
 }
 EOF
 
-test(A->e(), "C: In C::e, 1");	# We get a correct autoload
-test(A->e(), "C: In C::e, 1");	# Which sticks
+is(A->e(), "C: In C::e, 1");	# We get a correct autoload
+is(A->e(), "C: In C::e, 1");	# Which sticks
 
-test(A->ee(), "B: In A::ee, 2"); # We get a generic autoload, method in top
-test(A->ee(), "B: In A::ee, 2"); # Which sticks
+is(A->ee(), "B: In A::ee, 2"); # We get a generic autoload, method in top
+is(A->ee(), "B: In A::ee, 2"); # Which sticks
 
-test(Y->f(), "B: In Y::f, 3");	# We vivify a correct method
-test(Y->f(), "B: In Y::f, 3");	# Which sticks
+is(Y->f(), "B: In Y::f, 3");	# We vivify a correct method
+is(Y->f(), "B: In Y::f, 3");	# Which sticks
 
 # This test is not intended to be reasonable. It is here just to let you
 # know that you broke some old construction. Feel free to rewrite the test
@@ -155,11 +152,11 @@ test(Y->f(), "B: In Y::f, 3");	# Which sticks
   goto &$AUTOLOAD;
 };
 
-test(A->eee(), "new B: In A::eee, 4");	# We get a correct $autoload
-test(A->eee(), "new B: In A::eee, 4");	# Which sticks
+is(A->eee(), "new B: In A::eee, 4");	# We get a correct $autoload
+is(A->eee(), "new B: In A::eee, 4");	# Which sticks
 
 # this test added due to bug discovery
-test(defined(@{"unknown_package::ISA"}) ? "defined" : "undefined", "undefined");
+is(defined(@{"unknown_package::ISA"}) ? "defined" : "undefined", "undefined");
 
 # test that failed subroutine calls don't affect method calls
 {
@@ -168,20 +165,143 @@ test(defined(@{"unknown_package::ISA"}) ? "defined" : "undefined", "undefined");
     package A2;
     @ISA = 'A1';
     package main;
-    test(A2->foo(), "foo");
-    test(do { eval 'A2::foo()'; $@ ? 1 : 0}, 1);
-    test(A2->foo(), "foo");
+    is(A2->foo(), "foo");
+    is(do { eval 'A2::foo()'; $@ ? 1 : 0}, 1);
+    is(A2->foo(), "foo");
 }
 
+## This test was totally misguided.  It passed before only because the
+## code to determine if a package was loaded used to look for the hash
+## %Foo::Bar instead of the package Foo::Bar:: -- and Config.pm just
+## happens to export %Config.
+#  {
+#      is(do { use Config; eval 'Config->foo()';
+#  	      $@ =~ /^\QCan't locate object method "foo" via package "Config" at/ ? 1 : $@}, 1);
+#      is(do { use Config; eval '$d = bless {}, "Config"; $d->foo()';
+#  	      $@ =~ /^\QCan't locate object method "foo" via package "Config" at/ ? 1 : $@}, 1);
+#  }
+
+
+# test error messages if method loading fails
+eval '$e = bless {}, "E::A"; E::A->foo()';
+like ($@, qr/^\QCan't locate object method "foo" via package "E::A" at/);
+eval '$e = bless {}, "E::B"; $e->foo()';  
+like ($@, qr/^\QCan't locate object method "foo" via package "E::B" at/);
+eval 'E::C->foo()';
+like ($@, qr/^\QCan't locate object method "foo" via package "E::C" (perhaps /);
+
+eval 'UNIVERSAL->E::D::foo()';
+like ($@, qr/^\QCan't locate object method "foo" via package "E::D" (perhaps /);
+eval '$e = bless {}, "UNIVERSAL"; $e->E::E::foo()';
+like ($@, qr/^\QCan't locate object method "foo" via package "E::E" (perhaps /);
+
+$e = bless {}, "E::F";  # force package to exist
+eval 'UNIVERSAL->E::F::foo()';
+like ($@, qr/^\QCan't locate object method "foo" via package "E::F" at/);
+eval '$e = bless {}, "UNIVERSAL"; $e->E::F::foo()';
+like ($@, qr/^\QCan't locate object method "foo" via package "E::F" at/);
+
+# TODO: we need some tests for the SUPER:: pseudoclass
+
+# failed method call or UNIVERSAL::can() should not autovivify packages
+is( $::{"Foo::"} || "none", "none");  # sanity check 1
+is( $::{"Foo::"} || "none", "none");  # sanity check 2
+
+is( UNIVERSAL::can("Foo", "boogie") ? "yes":"no", "no" );
+is( $::{"Foo::"} || "none", "none");  # still missing?
+
+is( Foo->UNIVERSAL::can("boogie")   ? "yes":"no", "no" );
+is( $::{"Foo::"} || "none", "none");  # still missing?
+
+is( Foo->can("boogie")              ? "yes":"no", "no" );
+is( $::{"Foo::"} || "none", "none");  # still missing?
+
+is( eval 'Foo->boogie(); 1'         ? "yes":"no", "no" );
+is( $::{"Foo::"} || "none", "none");  # still missing?
+
+is(do { eval 'Foo->boogie()';
+	  $@ =~ /^\QCan't locate object method "boogie" via package "Foo" (perhaps / ? 1 : $@}, 1);
+
+eval 'sub Foo::boogie { "yes, sir!" }';
+is( $::{"Foo::"} ? "ok" : "none", "ok");  # should exist now
+is( Foo->boogie(), "yes, sir!");
+
+# TODO: universal.t should test NoSuchPackage->isa()/can()
+
+# This is actually testing parsing of indirect objects and undefined subs
+#   print foo("bar") where foo does not exist is not an indirect object.
+#   print foo "bar"  where foo does not exist is an indirect object.
+eval 'sub AUTOLOAD { "ok ", shift, "\n"; }';
+ok(1);
+
+# Bug ID 20010902.002
+is(
+    eval q[
+	$x = 'x';
+	sub Foo::x : lvalue { $x }
+	Foo->$x = 'ok';
+    ] || $@, 'ok'
+);
+
+# An autoloaded, inherited DESTROY may be invoked differently than normal
+# methods, and has been known to give rise to spurious warnings
+# eg <200203121600.QAA11064@gizmo.fdgroup.co.uk>
+
 {
-    test(do { use Config; eval 'Config->foo()';
-	      $@ =~ /^\QCan't locate object method "foo" via package "Config" at/ ? 1 : $@}, 1);
-    test(do { use Config; eval '$d = bless {}, "Config"; $d->foo()';
-	      $@ =~ /^\QCan't locate object method "foo" via package "Config" at/ ? 1 : $@}, 1);
+    use warnings;
+    my $w = '';
+    local $SIG{__WARN__} = sub { $w = $_[0] };
+
+    sub AutoDest::Base::AUTOLOAD {}
+    @AutoDest::ISA = qw(AutoDest::Base);
+    { my $x = bless {}, 'AutoDest'; }
+    $w =~ s/\n//g;
+    is($w, '');
 }
 
-test(do { eval 'E->foo()';
-	  $@ =~ /^\QCan't locate object method "foo" via package "E" (perhaps / ? 1 : $@}, 1);
-test(do { eval '$e = bless {}, "E"; $e->foo()';
-	  $@ =~ /^\QCan't locate object method "foo" via package "E" (perhaps / ? 1 : $@}, 1);
+# [ID 20020305.025] PACKAGE::SUPER doesn't work anymore
+
+package main;
+our @X;
+package Amajor;
+sub test {
+    push @main::X, 'Amajor', @_;
+}
+package Bminor;
+use base qw(Amajor);
+package main;
+sub Bminor::test {
+    $_[0]->Bminor::SUPER::test('x', 'y');
+    push @main::X, 'Bminor', @_;
+}
+Bminor->test('y', 'z');
+is("@X", "Amajor Bminor x y Bminor Bminor y z");
+
+package main;
+for my $meth (['Bar', 'Foo::Bar'],
+	      ['SUPER::Bar', 'main::SUPER::Bar'],
+	      ['Xyz::SUPER::Bar', 'Xyz::SUPER::Bar'])
+{
+    fresh_perl_is(<<EOT,
+package UNIVERSAL; sub AUTOLOAD { my \$c = shift; print "\$c \$AUTOLOAD\\n" }
+package Xyz;
+package main; Foo->$meth->[0]();
+EOT
+	"Foo $meth->[1]",
+	{ switches => [ '-w' ] },
+	"check if UNIVERSAL::AUTOLOAD works",
+    );
+}
+
+# Test for #71952: crash when looking for a nonexistent destructor
+# Regression introduced by fbb3ee5af3d4
+{
+    fresh_perl_is(<<'EOT',
+sub M::DESTROY; bless {}, "M" ; print "survived\n";
+EOT
+    "survived",
+    {},
+	"no crash with a declared but missing DESTROY method"
+    );
+}