BEGIN {
chdir 't' if -d 't';
- @INC = '../lib' if -d '../lib';
+ @INC = '../lib';
}
use strict;
use Config;
+use File::Spec::Functions;
-my $Is_VMS = $^O eq 'VMS';
-my $Is_MSWin32 = $^O eq 'MSWin32';
-my $Invoke_Perl = $Is_VMS ? 'MCR Sys$Disk:[]Perl.' :
- $Is_MSWin32 ? '.\perl' : './perl';
+BEGIN { require './test.pl'; }
+plan tests => 255;
+
+$| = 1;
+
+use vars qw($ipcsysv); # did we manage to load IPC::SysV?
+
+BEGIN {
+ if ($^O eq 'VMS' && !defined($Config{d_setenv})) {
+ $ENV{PATH} = $ENV{PATH};
+ $ENV{TERM} = $ENV{TERM} ne ''? $ENV{TERM} : 'dummy';
+ }
+ if ($Config{'extensions'} =~ /\bIPC\/SysV\b/
+ && ($Config{d_shm} || $Config{d_msg})) {
+ eval { require IPC::SysV };
+ unless ($@) {
+ $ipcsysv++;
+ IPC::SysV->import(qw(IPC_PRIVATE IPC_RMID IPC_CREAT S_IRWXU IPC_NOWAIT));
+ }
+ }
+}
+
+my $Is_MacOS = $^O eq 'MacOS';
+my $Is_VMS = $^O eq 'VMS';
+my $Is_MSWin32 = $^O eq 'MSWin32';
+my $Is_NetWare = $^O eq 'NetWare';
+my $Is_Dos = $^O eq 'dos';
+my $Is_Cygwin = $^O eq 'cygwin';
+my $Is_OpenBSD = $^O eq 'openbsd';
+my $Invoke_Perl = $Is_VMS ? 'MCR Sys$Disk:[]Perl.' :
+ $Is_MSWin32 ? '.\perl' :
+ $Is_MacOS ? ':perl' :
+ $Is_NetWare ? 'perl' :
+ './perl' ;
my @MoreEnv = qw/IFS CDPATH ENV BASH_ENV/;
if ($Is_VMS) {
}
eval <<EndOfCleanup;
END {
- \$ENV{PATH} = '';
+ \$ENV{PATH} = '' if $Config{d_setenv};
warn "# Note: logical name 'PATH' may have been deleted\n";
- @ENV{keys %old} = values %old;
+ \@ENV{keys %old} = values %old;
}
EndOfCleanup
}
# The empty tainted value, for tainting strings
my $TAINT = substr($^X, 0, 0);
# A tainted zero, useful for tainting numbers
-my $TAINT0 = 0 + $TAINT;
+my $TAINT0;
+{
+ no warnings;
+ $TAINT0 = 0 + $TAINT;
+}
# This taints each argument passed. All must be lvalues.
# Side effect: It also stringifies them. :-(
1;
}
-sub test ($$;$) {
- my($serial, $boolean, $diag) = @_;
- if ($boolean) {
- print "ok $serial\n";
+
+sub test ($;$) {
+ my($ok, $diag) = @_;
+
+ my $curr_test = curr_test();
+
+ if ($ok) {
+ print "ok $curr_test\n";
} else {
- print "not ok $serial\n";
+ print "not ok $curr_test\n";
+ printf "# Failed test at line %d\n", (caller)[2];
for (split m/^/m, $diag) {
print "# $_";
}
$diag eq ''
or substr($diag, -1) eq "\n";
}
+
+ next_test();
+
+ return $ok;
}
# We need an external program to call.
-my $ECHO = ($Is_MSWin32 ? ".\\echo$$" : "./echo$$");
+my $ECHO = ($Is_MSWin32 ? ".\\echo$$" : $Is_MacOS ? ":echo$$" : ($Is_NetWare ? "echo$$" : "./echo$$"));
END { unlink $ECHO }
open PROG, "> $ECHO" or die "Can't create $ECHO: $!";
print PROG 'print "@ARGV\n"', "\n";
close PROG;
my $echo = "$Invoke_Perl $ECHO";
-print "1..140\n";
+my $TEST = catfile(curdir(), 'TEST');
# First, let's make sure that Perl is checking the dangerous
# environment variables. Maybe they aren't set yet, so we'll
{
$ENV{'DCL$PATH'} = '' if $Is_VMS;
+ if ($Is_MSWin32 && $Config{ccname} =~ /bcc32/ && ! -f 'cc3250mt.dll') {
+ my $bcc_dir;
+ foreach my $dir (split /$Config{path_sep}/, $ENV{PATH}) {
+ if (-f "$dir/cc3250mt.dll") {
+ $bcc_dir = $dir and last;
+ }
+ }
+ if (defined $bcc_dir) {
+ require File::Copy;
+ File::Copy::copy("$bcc_dir/cc3250mt.dll", '.') or
+ die "$0: failed to copy cc3250mt.dll: $!\n";
+ eval q{
+ END { unlink "cc3250mt.dll" }
+ };
+ }
+ }
+
$ENV{PATH} = '';
delete @ENV{@MoreEnv};
$ENV{TERM} = 'dumb';
- test 1, eval { `$echo 1` } eq "1\n";
+ if ($Is_Cygwin && ! -f 'cygwin1.dll') {
+ system("/usr/bin/cp /usr/bin/cygwin1.dll .") &&
+ die "$0: failed to cp cygwin1.dll: $!\n";
+ eval q{
+ END { unlink "cygwin1.dll" }
+ };
+ }
- if ($Is_MSWin32 || $Is_VMS) {
- print "# Environment tainting tests skipped\n";
- for (2..5) { print "ok $_\n" }
+ if ($Is_Cygwin && ! -f 'cygcrypt-0.dll' && -f '/usr/bin/cygcrypt-0.dll') {
+ system("/usr/bin/cp /usr/bin/cygcrypt-0.dll .") &&
+ die "$0: failed to cp cygcrypt-0.dll: $!\n";
+ eval q{
+ END { unlink "cygcrypt-0.dll" }
+ };
}
- else {
+
+ test eval { `$echo 1` } eq "1\n";
+
+ SKIP: {
+ skip "Environment tainting tests skipped", 4
+ if $Is_MSWin32 || $Is_NetWare || $Is_VMS || $Is_Dos || $Is_MacOS;
+
my @vars = ('PATH', @MoreEnv);
while (my $v = $vars[0]) {
local $ENV{$v} = $TAINT;
last unless $@ =~ /^Insecure \$ENV{$v}/;
shift @vars;
}
- test 2, !@vars, "\$$vars[0]";
+ test !@vars, "@vars";
# tainted $TERM is unsafe only if it contains metachars
local $ENV{TERM};
$ENV{TERM} = 'e=mc2';
- test 3, eval { `$echo 1` } eq "1\n";
+ test eval { `$echo 1` } eq "1\n";
$ENV{TERM} = 'e=mc2' . $TAINT;
- test 4, eval { `$echo 1` } eq '';
- test 5, $@ =~ /^Insecure \$ENV{TERM}/, $@;
+ test !eval { `$echo 1` };
+ test $@ =~ /^Insecure \$ENV{TERM}/, $@;
}
my $tmp;
- if ($^O eq 'os2' || $^O eq 'amigaos' || $Is_MSWin32) {
+ if ($^O eq 'os2' || $^O eq 'amigaos' || $Is_MSWin32 || $Is_NetWare || $Is_Dos) {
print "# all directories are writeable\n";
}
else {
$tmp = (grep { defined and -d and (stat _)[2] & 2 }
- qw(/tmp /var/tmp /usr/tmp /sys$scratch),
+ qw(sys$scratch /tmp /var/tmp /usr/tmp),
@ENV{qw(TMP TEMP)})[0]
or print "# can't find world-writeable directory to test PATH\n";
}
- if ($tmp) {
+ SKIP: {
+ skip "all directories are writeable", 2 unless $tmp;
+
local $ENV{PATH} = $tmp;
- test 6, eval { `$echo 1` } eq '';
- test 7, $@ =~ /^Insecure directory in \$ENV{PATH}/, $@;
- }
- else {
- for (6..7) { print "ok $_\n" }
+ test !eval { `$echo 1` };
+ test $@ =~ /^Insecure directory in \$ENV{PATH}/, $@;
}
- if ($Is_VMS) {
+ SKIP: {
+ skip "This is not VMS", 4 unless $Is_VMS;
+
$ENV{'DCL$PATH'} = $TAINT;
- test 8, eval { `$echo 1` } eq '';
- test 9, $@ =~ /^Insecure \$ENV{DCL\$PATH}/, $@;
- if ($tmp) {
+ test eval { `$echo 1` } eq '';
+ test $@ =~ /^Insecure \$ENV{DCL\$PATH}/, $@;
+ SKIP: {
+ skip q[can't find world-writeable directory to test DCL$PATH], 2
+ unless $tmp;
+
$ENV{'DCL$PATH'} = $tmp;
- test 10, eval { `$echo 1` } eq '';
- test 11, $@ =~ /^Insecure directory in \$ENV{DCL\$PATH}/, $@;
- }
- else {
- print "# can't find world-writeable directory to test DCL\$PATH\n";
- for (10..11) { print "ok $_\n" }
+ test eval { `$echo 1` } eq '';
+ test $@ =~ /^Insecure directory in \$ENV{DCL\$PATH}/, $@;
}
$ENV{'DCL$PATH'} = '';
}
- else {
- print "# This is not VMS\n";
- for (8..11) { print "ok $_\n"; }
- }
}
# Let's see that we can taint and untaint as needed.
{
my $foo = $TAINT;
- test 12, tainted $foo;
+ test tainted $foo;
# That was a sanity check. If it failed, stop the insanity!
die "Taint checks don't seem to be enabled" unless tainted $foo;
$foo = "foo";
- test 13, not tainted $foo;
+ test not tainted $foo;
taint_these($foo);
- test 14, tainted $foo;
+ test tainted $foo;
my @list = 1..10;
- test 15, not any_tainted @list;
+ test not any_tainted @list;
taint_these @list[1,3,5,7,9];
- test 16, any_tainted @list;
- test 17, all_tainted @list[1,3,5,7,9];
- test 18, not any_tainted @list[0,2,4,6,8];
+ test any_tainted @list;
+ test all_tainted @list[1,3,5,7,9];
+ test not any_tainted @list[0,2,4,6,8];
($foo) = $foo =~ /(.+)/;
- test 19, not tainted $foo;
+ test not tainted $foo;
$foo = $1 if ('bar' . $TAINT) =~ /(.+)/;
- test 20, not tainted $foo;
- test 21, $foo eq 'bar';
+ test not tainted $foo;
+ test $foo eq 'bar';
+
+ {
+ use re 'taint';
+
+ ($foo) = ('bar' . $TAINT) =~ /(.+)/;
+ test tainted $foo;
+ test $foo eq 'bar';
+
+ $foo = $1 if ('bar' . $TAINT) =~ /(.+)/;
+ test tainted $foo;
+ test $foo eq 'bar';
+ }
+
+ $foo = $1 if 'bar' =~ /(.+)$TAINT/;
+ test tainted $foo;
+ test $foo eq 'bar';
my $pi = 4 * atan2(1,1) + $TAINT0;
- test 22, tainted $pi;
+ test tainted $pi;
($pi) = $pi =~ /(\d+\.\d+)/;
- test 23, not tainted $pi;
- test 24, sprintf("%.5f", $pi) eq '3.14159';
+ test not tainted $pi;
+ test sprintf("%.5f", $pi) eq '3.14159';
}
# How about command-line arguments? The problem is that we don't
# always get some, so we'll run another process with some.
-{
- my $arg = "./arg$$";
+SKIP: {
+ my $arg = catfile(curdir(), "arg$$");
open PROG, "> $arg" or die "Can't create $arg: $!";
print PROG q{
eval { join('', @ARGV), kill 0 };
};
close PROG;
print `$Invoke_Perl "-T" $arg and some suspect arguments`;
- test 25, !$?, "Exited with status $?";
+ test !$?, "Exited with status $?";
unlink $arg;
}
# Reading from a file should be tainted
{
- my $file = './TEST';
- test 26, open(FILE, $file), "Couldn't open '$file': $!";
+ test open(FILE, $TEST), "Couldn't open '$TEST': $!";
my $block;
sysread(FILE, $block, 100);
my $line = <FILE>;
close FILE;
- test 27, tainted $block;
- test 28, tainted $line;
+ test tainted $block;
+ test tainted $line;
}
# Globs should be forbidden, except under VMS,
# which doesn't spawn an external program.
-if ($Is_VMS) {
- for (29..30) { print "ok $_\n"; }
-}
-else {
+SKIP: {
+ skip "globs should be forbidden", 2 if 1 or $Is_VMS;
+
my @globs = eval { <*> };
- test 29, @globs == 0 && $@ =~ /^Insecure dependency/;
+ test @globs == 0 && $@ =~ /^Insecure dependency/;
@globs = eval { glob '*' };
- test 30, @globs == 0 && $@ =~ /^Insecure dependency/;
+ test @globs == 0 && $@ =~ /^Insecure dependency/;
}
# Output of commands should be tainted
{
my $foo = `$echo abc`;
- test 31, tainted $foo;
+ test tainted $foo;
}
# Certain system variables should be tainted
{
- test 32, all_tainted $^X, $0;
+ test all_tainted $^X, $0;
}
# Results of matching should all be untainted
{
my $foo = "abcdefghi" . $TAINT;
- test 33, tainted $foo;
+ test tainted $foo;
$foo =~ /def/;
- test 34, not any_tainted $`, $&, $';
+ test not any_tainted $`, $&, $';
$foo =~ /(...)(...)(...)/;
- test 35, not any_tainted $1, $2, $3, $+;
+ test not any_tainted $1, $2, $3, $+;
my @bar = $foo =~ /(...)(...)(...)/;
- test 36, not any_tainted @bar;
+ test not any_tainted @bar;
- test 37, tainted $foo; # $foo should still be tainted!
- test 38, $foo eq "abcdefghi";
+ test tainted $foo; # $foo should still be tainted!
+ test $foo eq "abcdefghi";
}
# Operations which affect files can't use tainted data.
{
- test 39, eval { chmod 0, $TAINT } eq '', 'chmod';
- test 40, $@ =~ /^Insecure dependency/, $@;
+ test !eval { chmod 0, $TAINT }, 'chmod';
+ test $@ =~ /^Insecure dependency/, $@;
# There is no feature test in $Config{} for truncate,
# so we allow for the possibility that it's missing.
- test 41, eval { truncate 'NoSuChFiLe', $TAINT0 } eq '', 'truncate';
- test 42, $@ =~ /^(?:Insecure dependency|truncate not implemented)/, $@;
+ test !eval { truncate 'NoSuChFiLe', $TAINT0 }, 'truncate';
+ test $@ =~ /^(?:Insecure dependency|truncate not implemented)/, $@;
- test 43, eval { rename '', $TAINT } eq '', 'rename';
- test 44, $@ =~ /^Insecure dependency/, $@;
+ test !eval { rename '', $TAINT }, 'rename';
+ test $@ =~ /^Insecure dependency/, $@;
- test 45, eval { unlink $TAINT } eq '', 'unlink';
- test 46, $@ =~ /^Insecure dependency/, $@;
+ test !eval { unlink $TAINT }, 'unlink';
+ test $@ =~ /^Insecure dependency/, $@;
- test 47, eval { utime $TAINT } eq '', 'utime';
- test 48, $@ =~ /^Insecure dependency/, $@;
+ test !eval { utime $TAINT }, 'utime';
+ test $@ =~ /^Insecure dependency/, $@;
- if ($Config{d_chown}) {
- test 49, eval { chown -1, -1, $TAINT } eq '', 'chown';
- test 50, $@ =~ /^Insecure dependency/, $@;
- }
- else {
- print "# chown() is not available\n";
- for (49..50) { print "ok $_\n" }
- }
+ SKIP: {
+ skip "chown() is not available", 2 unless $Config{d_chown};
- if ($Config{d_link}) {
- test 51, eval { link $TAINT, '' } eq '', 'link';
- test 52, $@ =~ /^Insecure dependency/, $@;
- }
- else {
- print "# link() is not available\n";
- for (51..52) { print "ok $_\n" }
+ test !eval { chown -1, -1, $TAINT }, 'chown';
+ test $@ =~ /^Insecure dependency/, $@;
}
- if ($Config{d_symlink}) {
- test 53, eval { symlink $TAINT, '' } eq '', 'symlink';
- test 54, $@ =~ /^Insecure dependency/, $@;
+ SKIP: {
+ skip "link() is not available", 2 unless $Config{d_link};
+
+ test !eval { link $TAINT, '' }, 'link';
+ test $@ =~ /^Insecure dependency/, $@;
}
- else {
- print "# symlink() is not available\n";
- for (53..54) { print "ok $_\n" }
+
+ SKIP: {
+ skip "symlink() is not available", 2 unless $Config{d_symlink};
+
+ test !eval { symlink $TAINT, '' }, 'symlink';
+ test $@ =~ /^Insecure dependency/, $@;
}
}
# Operations which affect directories can't use tainted data.
{
- test 55, eval { mkdir $TAINT0, $TAINT } eq '', 'mkdir';
- test 56, $@ =~ /^Insecure dependency/, $@;
+ test !eval { mkdir "foo".$TAINT, 0755.$TAINT0 }, 'mkdir';
+ test $@ =~ /^Insecure dependency/, $@;
- test 57, eval { rmdir $TAINT } eq '', 'rmdir';
- test 58, $@ =~ /^Insecure dependency/, $@;
+ test !eval { rmdir $TAINT }, 'rmdir';
+ test $@ =~ /^Insecure dependency/, $@;
- test 59, eval { chdir $TAINT } eq '', 'chdir';
- test 60, $@ =~ /^Insecure dependency/, $@;
+ test !eval { chdir "foo".$TAINT }, 'chdir';
+ test $@ =~ /^Insecure dependency/, $@;
- if ($Config{d_chroot}) {
- test 61, eval { chroot $TAINT } eq '', 'chroot';
- test 62, $@ =~ /^Insecure dependency/, $@;
- }
- else {
- print "# chroot() is not available\n";
- for (61..62) { print "ok $_\n" }
+ SKIP: {
+ skip "chroot() is not available", 2 unless $Config{d_chroot};
+
+ test !eval { chroot $TAINT }, 'chroot';
+ test $@ =~ /^Insecure dependency/, $@;
}
}
# Some operations using files can't use tainted data.
{
my $foo = "imaginary library" . $TAINT;
- test 63, eval { require $foo } eq '', 'require';
- test 64, $@ =~ /^Insecure dependency/, $@;
+ test !eval { require $foo }, 'require';
+ test $@ =~ /^Insecure dependency/, $@;
my $filename = "./taintB$$"; # NB: $filename isn't tainted!
END { unlink $filename if defined $filename }
$foo = $filename . $TAINT;
unlink $filename; # in any case
- test 65, eval { open FOO, $foo } eq '', 'open for read';
- test 66, $@ eq '', $@; # NB: This should be allowed
- test 67, $! == 2; # File not found
+ test !eval { open FOO, $foo }, 'open for read';
+ test $@ eq '', $@; # NB: This should be allowed
+
+ # Try first new style but allow also old style.
+ # We do not want the whole taint.t to fail
+ # just because Errno possibly failing.
+ test eval('$!{ENOENT}') ||
+ $! == 2 || # File not found
+ ($Is_Dos && $! == 22) ||
+ ($^O eq 'mint' && $! == 33);
- test 68, eval { open FOO, "> $foo" } eq '', 'open for write';
- test 69, $@ =~ /^Insecure dependency/, $@;
+ test !eval { open FOO, "> $foo" }, 'open for write';
+ test $@ =~ /^Insecure dependency/, $@;
}
# Commands to the system can't use tainted data
{
my $foo = $TAINT;
- if ($^O eq 'amigaos') {
- print "# open(\"|\") is not available\n";
- for (70..73) { print "ok $_\n" }
- }
- else {
- test 70, eval { open FOO, "| $foo" } eq '', 'popen to';
- test 71, $@ =~ /^Insecure dependency/, $@;
+ SKIP: {
+ skip "open('|') is not available", 4 if $^O eq 'amigaos';
+
+ test !eval { open FOO, "| x$foo" }, 'popen to';
+ test $@ =~ /^Insecure dependency/, $@;
- test 72, eval { open FOO, "$foo |" } eq '', 'popen from';
- test 73, $@ =~ /^Insecure dependency/, $@;
+ test !eval { open FOO, "x$foo |" }, 'popen from';
+ test $@ =~ /^Insecure dependency/, $@;
}
- test 74, eval { exec $TAINT } eq '', 'exec';
- test 75, $@ =~ /^Insecure dependency/, $@;
+ test !eval { exec $TAINT }, 'exec';
+ test $@ =~ /^Insecure dependency/, $@;
- test 76, eval { system $TAINT } eq '', 'system';
- test 77, $@ =~ /^Insecure dependency/, $@;
+ test !eval { system $TAINT }, 'system';
+ test $@ =~ /^Insecure dependency/, $@;
$foo = "*";
taint_these $foo;
- test 78, eval { `$echo 1$foo` } eq '', 'backticks';
- test 79, $@ =~ /^Insecure dependency/, $@;
+ test !eval { `$echo 1$foo` }, 'backticks';
+ test $@ =~ /^Insecure dependency/, $@;
- if ($Is_VMS) { # wildcard expansion doesn't invoke shell, so is safe
- test 80, join('', eval { glob $foo } ) ne '', 'globbing';
- test 81, $@ eq '', $@;
- }
- else {
- for (80..81) { print "ok $_\n"; }
+ SKIP: {
+ # wildcard expansion doesn't invoke shell on VMS, so is safe
+ skip "This is not VMS", 2 unless $Is_VMS;
+
+ test join('', eval { glob $foo } ) ne '', 'globbing';
+ test $@ eq '', $@;
}
}
# Operations which affect processes can't use tainted data.
{
- test 82, eval { kill 0, $TAINT } eq '', 'kill';
- test 83, $@ =~ /^Insecure dependency/, $@;
+ test !eval { kill 0, $TAINT }, 'kill';
+ test $@ =~ /^Insecure dependency/, $@;
- if ($Config{d_setpgrp}) {
- test 84, eval { setpgrp 0, $TAINT } eq '', 'setpgrp';
- test 85, $@ =~ /^Insecure dependency/, $@;
- }
- else {
- print "# setpgrp() is not available\n";
- for (84..85) { print "ok $_\n" }
- }
+ SKIP: {
+ skip "setpgrp() is not available", 2 unless $Config{d_setpgrp};
- if ($Config{d_setprior}) {
- test 86, eval { setpriority 0, $TAINT, $TAINT } eq '', 'setpriority';
- test 87, $@ =~ /^Insecure dependency/, $@;
+ test !eval { setpgrp 0, $TAINT0 }, 'setpgrp';
+ test $@ =~ /^Insecure dependency/, $@;
}
- else {
- print "# setpriority() is not available\n";
- for (86..87) { print "ok $_\n" }
+
+ SKIP: {
+ skip "setpriority() is not available", 2 unless $Config{d_setprior};
+
+ test !eval { setpriority 0, $TAINT0, $TAINT0 }, 'setpriority';
+ test $@ =~ /^Insecure dependency/, $@;
}
}
# Some miscellaneous operations can't use tainted data.
{
- if ($Config{d_syscall}) {
- test 88, eval { syscall $TAINT } eq '', 'syscall';
- test 89, $@ =~ /^Insecure dependency/, $@;
- }
- else {
- print "# syscall() is not available\n";
- for (88..89) { print "ok $_\n" }
+ SKIP: {
+ skip "syscall() is not available", 2 unless $Config{d_syscall};
+
+ test !eval { syscall $TAINT }, 'syscall';
+ test $@ =~ /^Insecure dependency/, $@;
}
{
local *FOO;
my $temp = "./taintC$$";
END { unlink $temp }
- test 90, open(FOO, "> $temp"), "Couldn't open $temp for write: $!";
+ test open(FOO, "> $temp"), "Couldn't open $temp for write: $!";
- test 91, eval { ioctl FOO, $TAINT, $foo } eq '', 'ioctl';
- test 92, $@ =~ /^Insecure dependency/, $@;
+ test !eval { ioctl FOO, $TAINT0, $foo }, 'ioctl';
+ test $@ =~ /^Insecure dependency/, $@;
- if ($Config{d_fcntl}) {
- test 93, eval { fcntl FOO, $TAINT, $foo } eq '', 'fcntl';
- test 94, $@ =~ /^Insecure dependency/, $@;
- }
- else {
- print "# fcntl() is not available\n";
- for (93..94) { print "ok $_\n" }
+ SKIP: {
+ skip "fcntl() is not available", 2 unless $Config{d_fcntl};
+
+ test !eval { fcntl FOO, $TAINT0, $foo }, 'fcntl';
+ test $@ =~ /^Insecure dependency/, $@;
}
close FOO;
{
my $foo = 'abc' . $TAINT;
my $fooref = \$foo;
- test 95, not tainted $fooref;
- test 96, tainted $$fooref;
- test 97, tainted $foo;
+ test not tainted $fooref;
+ test tainted $$fooref;
+ test tainted $foo;
}
# Some tests involving assignment
{
my $foo = $TAINT0;
my $bar = $foo;
- test 98, all_tainted $foo, $bar;
- test 99, tainted($foo = $bar);
- test 100, tainted($bar = $bar);
- test 101, tainted($bar += $bar);
- test 102, tainted($bar -= $bar);
- test 103, tainted($bar *= $bar);
- test 104, tainted($bar++);
- test 105, tainted($bar /= $bar);
- test 106, tainted($bar += 0);
- test 107, tainted($bar -= 2);
- test 108, tainted($bar *= -1);
- test 109, tainted($bar /= 1);
- test 110, tainted($bar--);
- test 111, $bar == 0;
+ test all_tainted $foo, $bar;
+ test tainted($foo = $bar);
+ test tainted($bar = $bar);
+ test tainted($bar += $bar);
+ test tainted($bar -= $bar);
+ test tainted($bar *= $bar);
+ test tainted($bar++);
+ test tainted($bar /= $bar);
+ test tainted($bar += 0);
+ test tainted($bar -= 2);
+ test tainted($bar *= -1);
+ test tainted($bar /= 1);
+ test tainted($bar--);
+ test $bar == 0;
}
# Test assignment and return of lists
{
my @foo = ("A", "tainted" . $TAINT, "B");
- test 112, not tainted $foo[0];
- test 113, tainted $foo[1];
- test 114, not tainted $foo[2];
+ test not tainted $foo[0];
+ test tainted $foo[1];
+ test not tainted $foo[2];
my @bar = @foo;
- test 115, not tainted $bar[0];
- test 116, tainted $bar[1];
- test 117, not tainted $bar[2];
+ test not tainted $bar[0];
+ test tainted $bar[1];
+ test not tainted $bar[2];
my @baz = eval { "A", "tainted" . $TAINT, "B" };
- test 118, not tainted $baz[0];
- test 119, tainted $baz[1];
- test 120, not tainted $baz[2];
+ test not tainted $baz[0];
+ test tainted $baz[1];
+ test not tainted $baz[2];
my @plugh = eval q[ "A", "tainted" . $TAINT, "B" ];
- test 121, not tainted $plugh[0];
- test 122, tainted $plugh[1];
- test 123, not tainted $plugh[2];
+ test not tainted $plugh[0];
+ test tainted $plugh[1];
+ test not tainted $plugh[2];
my $nautilus = sub { "A", "tainted" . $TAINT, "B" };
- test 124, not tainted ((&$nautilus)[0]);
- test 125, tainted ((&$nautilus)[1]);
- test 126, not tainted ((&$nautilus)[2]);
+ test not tainted ((&$nautilus)[0]);
+ test tainted ((&$nautilus)[1]);
+ test not tainted ((&$nautilus)[2]);
my @xyzzy = &$nautilus;
- test 127, not tainted $xyzzy[0];
- test 128, tainted $xyzzy[1];
- test 129, not tainted $xyzzy[2];
+ test not tainted $xyzzy[0];
+ test tainted $xyzzy[1];
+ test not tainted $xyzzy[2];
my $red_october = sub { return "A", "tainted" . $TAINT, "B" };
- test 130, not tainted ((&$red_october)[0]);
- test 131, tainted ((&$red_october)[1]);
- test 132, not tainted ((&$red_october)[2]);
+ test not tainted ((&$red_october)[0]);
+ test tainted ((&$red_october)[1]);
+ test not tainted ((&$red_october)[2]);
my @corge = &$red_october;
- test 133, not tainted $corge[0];
- test 134, tainted $corge[1];
- test 135, not tainted $corge[2];
+ test not tainted $corge[0];
+ test tainted $corge[1];
+ test not tainted $corge[2];
}
# Test for system/library calls returning string data of dubious origin.
{
# No reliable %Config check for getpw*
- if (eval { setpwent(); getpwent(); 1 }) {
+ SKIP: {
+ skip "getpwent() is not available", 1 unless
+ eval { setpwent(); getpwent() };
+
setpwent();
my @getpwent = getpwent();
die "getpwent: $!\n" unless (@getpwent);
- test 136,( not tainted $getpwent[0]
- and not tainted $getpwent[1]
+ test ( not tainted $getpwent[0]
+ and tainted $getpwent[1]
and not tainted $getpwent[2]
and not tainted $getpwent[3]
and not tainted $getpwent[4]
and not tainted $getpwent[5]
- and tainted $getpwent[6] # gecos
+ and tainted $getpwent[6] # ge?cos
and not tainted $getpwent[7]
- and not tainted $getpwent[8]);
+ and tainted $getpwent[8]); # shell
endpwent();
- } else {
- print "# getpwent() is not available\n";
- print "ok 136\n";
}
- if ($Config{d_readdir}) { # pretty hard to imagine not
+ SKIP: {
+ # pretty hard to imagine not
+ skip "readdir() is not available", 1 unless $Config{d_readdir};
+
local(*D);
opendir(D, "op") or die "opendir: $!\n";
my $readdir = readdir(D);
- test 137, tainted $readdir;
- closedir(OP);
- } else {
- print "# readdir() is not available\n";
- print "ok 137\n";
+ test tainted $readdir;
+ closedir(D);
}
- if ($Config{d_readlink} && $Config{d_symlink}) {
+ SKIP: {
+ skip "readlink() or symlink() is not available" unless
+ $Config{d_readlink} && $Config{d_symlink};
+
my $symlink = "sl$$";
unlink($symlink);
- symlink("/something/naughty", $symlink) or die "symlink: $!\n";
+ my $sl = "/something/naughty";
+ # it has to be a real path on Mac OS
+ $sl = MacPerl::MakePath((MacPerl::Volumes())[0]) if $Is_MacOS;
+ symlink($sl, $symlink) or die "symlink: $!\n";
my $readlink = readlink($symlink);
- test 138, tainted $readlink;
+ test tainted $readlink;
unlink($symlink);
- } else {
- print "# readlink() or symlink() is not available\n";
- print "ok 138\n";
}
}
{
my $why = "y";
my $j = "x" | $why;
- test 139, not tainted $j;
+ test not tainted $j;
$why = $TAINT."y";
$j = "x" | $why;
- test 140, tainted $j;
+ test tainted $j;
+}
+
+# test target of substitution (regression bug)
+{
+ my $why = $TAINT."y";
+ $why =~ s/y/z/;
+ test tainted $why;
+
+ my $z = "[z]";
+ $why =~ s/$z/zee/;
+ test tainted $why;
+
+ $why =~ s/e/'-'.$$/ge;
+ test tainted $why;
}
+
+SKIP: {
+ skip "no IPC::SysV", 2 unless $ipcsysv;
+
+ # test shmread
+ SKIP: {
+ skip "shm*() not available", 1 unless $Config{d_shm};
+
+ no strict 'subs';
+ my $sent = "foobar";
+ my $rcvd;
+ my $size = 2000;
+ my $id = shmget(IPC_PRIVATE, $size, S_IRWXU);
+
+ if (defined $id) {
+ if (shmwrite($id, $sent, 0, 60)) {
+ if (shmread($id, $rcvd, 0, 60)) {
+ substr($rcvd, index($rcvd, "\0")) = '';
+ } else {
+ warn "# shmread failed: $!\n";
+ }
+ } else {
+ warn "# shmwrite failed: $!\n";
+ }
+ shmctl($id, IPC_RMID, 0) or warn "# shmctl failed: $!\n";
+ } else {
+ warn "# shmget failed: $!\n";
+ }
+
+ skip "SysV shared memory operation failed", 1 unless
+ $rcvd eq $sent;
+
+ test tainted $rcvd;
+ }
+
+
+ # test msgrcv
+ SKIP: {
+ skip "msg*() not available", 1 unless $Config{d_msg};
+
+ no strict 'subs';
+ my $id = msgget(IPC_PRIVATE, IPC_CREAT | S_IRWXU);
+
+ my $sent = "message";
+ my $type_sent = 1234;
+ my $rcvd;
+ my $type_rcvd;
+
+ if (defined $id) {
+ if (msgsnd($id, pack("l! a*", $type_sent, $sent), IPC_NOWAIT)) {
+ if (msgrcv($id, $rcvd, 60, 0, IPC_NOWAIT)) {
+ ($type_rcvd, $rcvd) = unpack("l! a*", $rcvd);
+ } else {
+ warn "# msgrcv failed: $!\n";
+ }
+ } else {
+ warn "# msgsnd failed: $!\n";
+ }
+ msgctl($id, IPC_RMID, 0) or warn "# msgctl failed: $!\n";
+ } else {
+ warn "# msgget failed\n";
+ }
+
+ SKIP: {
+ skip "SysV message queue operation failed", 1
+ unless $rcvd eq $sent && $type_sent == $type_rcvd;
+
+ test tainted $rcvd;
+ }
+ }
+}
+
+{
+ # bug id 20001004.006
+
+ open IN, $TEST or warn "$0: cannot read $TEST: $!" ;
+ local $/;
+ my $a = <IN>;
+ my $b = <IN>;
+
+ ok tainted($a) && tainted($b) && !defined($b);
+
+ close IN;
+}
+
+{
+ # bug id 20001004.007
+
+ open IN, $TEST or warn "$0: cannot read $TEST: $!" ;
+ my $a = <IN>;
+
+ my $c = { a => 42,
+ b => $a };
+
+ ok !tainted($c->{a}) && tainted($c->{b});
+
+
+ my $d = { a => $a,
+ b => 42 };
+ ok tainted($d->{a}) && !tainted($d->{b});
+
+
+ my $e = { a => 42,
+ b => { c => $a, d => 42 } };
+ ok !tainted($e->{a}) &&
+ !tainted($e->{b}) &&
+ tainted($e->{b}->{c}) &&
+ !tainted($e->{b}->{d});
+
+ close IN;
+}
+
+{
+ # bug id 20010519.003
+
+ BEGIN {
+ use vars qw($has_fcntl);
+ eval { require Fcntl; import Fcntl; };
+ unless ($@) {
+ $has_fcntl = 1;
+ }
+ }
+
+ SKIP: {
+ skip "no Fcntl", 18 unless $has_fcntl;
+
+ my $evil = "foo" . $TAINT;
+
+ eval { sysopen(my $ro, $evil, &O_RDONLY) };
+ test $@ !~ /^Insecure dependency/, $@;
+
+ eval { sysopen(my $wo, $evil, &O_WRONLY) };
+ test $@ =~ /^Insecure dependency/, $@;
+
+ eval { sysopen(my $rw, $evil, &O_RDWR) };
+ test $@ =~ /^Insecure dependency/, $@;
+
+ eval { sysopen(my $ap, $evil, &O_APPEND) };
+ test $@ =~ /^Insecure dependency/, $@;
+
+ eval { sysopen(my $cr, $evil, &O_CREAT) };
+ test $@ =~ /^Insecure dependency/, $@;
+
+ eval { sysopen(my $tr, $evil, &O_TRUNC) };
+ test $@ =~ /^Insecure dependency/, $@;
+
+ eval { sysopen(my $ro, "foo", &O_RDONLY | $TAINT0) };
+ test $@ !~ /^Insecure dependency/, $@;
+
+ eval { sysopen(my $wo, "foo", &O_WRONLY | $TAINT0) };
+ test $@ =~ /^Insecure dependency/, $@;
+
+ eval { sysopen(my $rw, "foo", &O_RDWR | $TAINT0) };
+ test $@ =~ /^Insecure dependency/, $@;
+
+ eval { sysopen(my $ap, "foo", &O_APPEND | $TAINT0) };
+ test $@ =~ /^Insecure dependency/, $@;
+
+ eval { sysopen(my $cr, "foo", &O_CREAT | $TAINT0) };
+ test $@ =~ /^Insecure dependency/, $@;
+
+ eval { sysopen(my $tr, "foo", &O_TRUNC | $TAINT0) };
+ test $@ =~ /^Insecure dependency/, $@;
+
+ eval { sysopen(my $ro, "foo", &O_RDONLY, $TAINT0) };
+ test $@ !~ /^Insecure dependency/, $@;
+
+ eval { sysopen(my $wo, "foo", &O_WRONLY, $TAINT0) };
+ test $@ =~ /^Insecure dependency/, $@;
+
+ eval { sysopen(my $rw, "foo", &O_RDWR, $TAINT0) };
+ test $@ =~ /^Insecure dependency/, $@;
+
+ eval { sysopen(my $ap, "foo", &O_APPEND, $TAINT0) };
+ test $@ =~ /^Insecure dependency/, $@;
+
+ eval { sysopen(my $cr, "foo", &O_CREAT, $TAINT0) };
+ test $@ =~ /^Insecure dependency/, $@;
+
+ eval { sysopen(my $tr, "foo", &O_TRUNC, $TAINT0) };
+ test $@ =~ /^Insecure dependency/, $@;
+
+ unlink("foo"); # not unlink($evil), because that would fail...
+ }
+}
+
+{
+ # bug 20010526.004
+
+ use warnings;
+
+ my $saw_warning = 0;
+ local $SIG{__WARN__} = sub { $saw_warning = 1 };
+
+ sub fmi {
+ my $divnum = shift()/1;
+ sprintf("%1.1f\n", $divnum);
+ }
+
+ fmi(21 . $TAINT);
+ fmi(37);
+ fmi(248);
+
+ test !$saw_warning;
+}
+
+
+{
+ # Bug ID 20010730.010
+
+ my $i = 0;
+
+ sub Tie::TIESCALAR {
+ my $class = shift;
+ my $arg = shift;
+
+ bless \$arg => $class;
+ }
+
+ sub Tie::FETCH {
+ $i ++;
+ ${$_ [0]}
+ }
+
+
+ package main;
+
+ my $bar = "The Big Bright Green Pleasure Machine";
+ taint_these $bar;
+ tie my ($foo), Tie => $bar;
+
+ my $baz = $foo;
+
+ ok $i == 1;
+}
+
+{
+ # Check that all environment variables are tainted.
+ my @untainted;
+ while (my ($k, $v) = each %ENV) {
+ if (!tainted($v) &&
+ # These we have explicitly untainted or set earlier.
+ $k !~ /^(BASH_ENV|CDPATH|ENV|IFS|PATH|PERL_CORE|TEMP|TERM|TMP)$/) {
+ push @untainted, "# '$k' = '$v'\n";
+ }
+ }
+ test @untainted == 0, "untainted:\n @untainted";
+}
+
+
+ok( ${^TAINT} == 1, '$^TAINT is on' );
+
+eval { ${^TAINT} = 0 };
+ok( ${^TAINT}, '$^TAINT is not assignable' );
+ok( $@ =~ /^Modification of a read-only value attempted/,
+ 'Assigning to ${^TAINT} fails' );
+
+{
+ # bug 20011111.105
+
+ my $re1 = qr/x$TAINT/;
+ test tainted $re1;
+
+ my $re2 = qr/^$re1\z/;
+ test tainted $re2;
+
+ my $re3 = "$re2";
+ test tainted $re3;
+}
+
+SKIP: {
+ skip "system {} has different semantics on Win32", 1 if $Is_MSWin32;
+
+ # bug 20010221.005
+ local $ENV{PATH} .= $TAINT;
+ eval { system { "echo" } "/arg0", "arg1" };
+ test $@ =~ /^Insecure \$ENV/;
+}
+
+TODO: {
+ todo_skip 'tainted %ENV warning occludes tainted arguments warning', 22
+ if $Is_VMS;
+
+ # bug 20020208.005 plus some single arg exec/system extras
+ my $err = qr/^Insecure dependency/ ;
+ test !eval { exec $TAINT, $TAINT }, 'exec';
+ test $@ =~ $err, $@;
+ test !eval { exec $TAINT $TAINT }, 'exec';
+ test $@ =~ $err, $@;
+ test !eval { exec $TAINT $TAINT, $TAINT }, 'exec';
+ test $@ =~ $err, $@;
+ test !eval { exec $TAINT 'notaint' }, 'exec';
+ test $@ =~ $err, $@;
+ test !eval { exec {'notaint'} $TAINT }, 'exec';
+ test $@ =~ $err, $@;
+
+ test !eval { system $TAINT, $TAINT }, 'system';
+ test $@ =~ $err, $@;
+ test !eval { system $TAINT $TAINT }, 'system';
+ test $@ =~ $err, $@;
+ test !eval { system $TAINT $TAINT, $TAINT }, 'system';
+ test $@ =~ $err, $@;
+ test !eval { system $TAINT 'notaint' }, 'system';
+ test $@ =~ $err, $@;
+ test !eval { system {'notaint'} $TAINT }, 'system';
+ test $@ =~ $err, $@;
+
+ eval {
+ no warnings;
+ system("lskdfj does not exist","with","args");
+ };
+ test !$@;
+
+ SKIP: {
+ skip "no exec() on MacOS Classic" if $Is_MacOS;
+
+ eval {
+ no warnings;
+ exec("lskdfj does not exist","with","args");
+ };
+ test !$@;
+ }
+
+ # If you add tests here update also the above skip block for VMS.
+}
+
+{
+ # [ID 20020704.001] taint propagation failure
+ use re 'taint';
+ $TAINT =~ /(.*)/;
+ test tainted(my $foo = $1);
+}
+
+{
+ # [perl #24291] this used to dump core
+ our %nonmagicalenv = ( PATH => "util" );
+ local *ENV = \%nonmagicalenv;
+ eval { system("lskdfj"); };
+ test $@ =~ /^%ENV is aliased to another variable while running with -T switch/;
+ local *ENV = *nonmagicalenv;
+ eval { system("lskdfj"); };
+ test $@ =~ /^%ENV is aliased to %nonmagicalenv while running with -T switch/;
+}
+{
+ # [perl #24248]
+ $TAINT =~ /(.*)/;
+ test !tainted($1);
+ my $notaint = $1;
+ test !tainted($notaint);
+
+ my $l;
+ $notaint =~ /($notaint)/;
+ $l = $1;
+ test !tainted($1);
+ test !tainted($l);
+ $notaint =~ /($TAINT)/;
+ $l = $1;
+ test tainted($1);
+ test tainted($l);
+
+ $TAINT =~ /($notaint)/;
+ $l = $1;
+ test !tainted($1);
+ test !tainted($l);
+ $TAINT =~ /($TAINT)/;
+ $l = $1;
+ test tainted($1);
+ test tainted($l);
+
+ my $r;
+ ($r = $TAINT) =~ /($notaint)/;
+ test !tainted($1);
+ ($r = $TAINT) =~ /($TAINT)/;
+ test tainted($1);
+
+ # [perl #24674]
+ # accessing $^O shoudn't taint it as a side-effect;
+ # assigning tainted data to it is now an error
+
+ test !tainted($^O);
+ if (!$^X) { } elsif ($^O eq 'bar') { }
+ test !tainted($^O);
+ eval '$^O = $^X';
+ test $@ =~ /Insecure dependency in/;
+}
+
+EFFECTIVELY_CONSTANTS: {
+ my $tainted_number = 12 + $TAINT0;
+ test tainted( $tainted_number );
+
+ # Even though it's always 0, it's still tainted
+ my $tainted_product = $tainted_number * 0;
+ test tainted( $tainted_product );
+ test $tainted_product == 0;
+}
+
+TERNARY_CONDITIONALS: {
+ my $tainted_true = $TAINT . "blah blah blah";
+ my $tainted_false = $TAINT0;
+ test tainted( $tainted_true );
+ test tainted( $tainted_false );
+
+ my $result = $tainted_true ? "True" : "False";
+ test $result eq "True";
+ test !tainted( $result );
+
+ $result = $tainted_false ? "True" : "False";
+ test $result eq "False";
+ test !tainted( $result );
+
+ my $untainted_whatever = "The Fabulous Johnny Cash";
+ my $tainted_whatever = "Soft Cell" . $TAINT;
+
+ $result = $tainted_true ? $tainted_whatever : $untainted_whatever;
+ test $result eq "Soft Cell";
+ test tainted( $result );
+
+ $result = $tainted_false ? $tainted_whatever : $untainted_whatever;
+ test $result eq "The Fabulous Johnny Cash";
+ test !tainted( $result );
+}
+
+{
+ # rt.perl.org 5900 $1 remains tainted if...
+ # 1) The regular expression contains a scalar variable AND
+ # 2) The regular expression appears in an elsif clause
+
+ my $foo = "abcdefghi" . $TAINT;
+
+ my $valid_chars = 'a-z';
+ if ( $foo eq '' ) {
+ }
+ elsif ( $foo =~ /([$valid_chars]+)/o ) {
+ test not tainted $1;
+ }
+
+ if ( $foo eq '' ) {
+ }
+ elsif ( my @bar = $foo =~ /([$valid_chars]+)/o ) {
+ test not any_tainted @bar;
+ }
+}
+
+# at scope exit, a restored localised value should have its old
+# taint status, not the taint status of the current statement
+
+{
+ our $x99 = $^X;
+ test tainted $x99;
+
+ $x99 = '';
+ test not tainted $x99;
+
+ my $c = do { local $x99; $^X };
+ test not tainted $x99;
+}
+{
+ our $x99 = $^X;
+ test tainted $x99;
+
+ my $c = do { local $x99; '' };
+ test tainted $x99;
+}
+
+# an mg_get of a tainted value during localization shouldn't taint the
+# statement
+
+{
+ eval { local $0, eval '1' };
+ test $@ eq '';
+}
+
+# [perl #8262] //g loops infinitely on tainted data
+
+{
+ my @a;
+ local $::TODO = 1;
+ $a[0] = $^X;
+ my $i = 0;
+ while($a[0]=~ m/(.)/g ) {
+ last if $i++ > 10000;
+ }
+ cmp_ok $i, '<', 10000, "infinite m//g";
+}
+
+SKIP:
+{
+ my $got_dualvar;
+ eval 'use Scalar::Util "dualvar"; $got_dualvar++';
+ skip "No Scalar::Util::dualvar" unless $got_dualvar;
+ my $a = Scalar::Util::dualvar(3, $^X);
+ my $b = $a + 5;
+ is ($b, 8, "Arithmetic on tainted dualvars works");
+}
+
+# opening '|-' should not trigger $ENV{PATH} check
+
+{
+ SKIP: {
+ skip "fork() is not available", 3 unless $Config{'d_fork'};
+ skip "opening |- is not stable on threaded OpenBSD with taint", 3
+ if $Config{useithreads} && $Is_OpenBSD;
+
+ $ENV{'PATH'} = $TAINT;
+ local $SIG{'PIPE'} = 'IGNORE';
+ eval {
+ my $pid = open my $pipe, '|-';
+ if (!defined $pid) {
+ die "open failed: $!";
+ }
+ if (!$pid) {
+ kill 'KILL', $$; # child suicide
+ }
+ close $pipe;
+ };
+ test $@ !~ /Insecure \$ENV/, 'fork triggers %ENV check';
+ test $@ eq '', 'pipe/fork/open/close failed';
+ eval {
+ open my $pipe, "|$Invoke_Perl -e 1";
+ close $pipe;
+ };
+ test $@ =~ /Insecure \$ENV/, 'popen neglects %ENV check';
+ }
+}
+
+{
+ package AUTOLOAD_TAINT;
+ sub AUTOLOAD {
+ our $AUTOLOAD;
+ return if $AUTOLOAD =~ /DESTROY/;
+ if ($AUTOLOAD =~ /untainted/) {
+ main::ok(!main::tainted($AUTOLOAD), '$AUTOLOAD can be untainted');
+ } else {
+ main::ok(main::tainted($AUTOLOAD), '$AUTOLOAD can be tainted');
+ }
+ }
+
+ package main;
+ my $o = bless [], 'AUTOLOAD_TAINT';
+ $o->$TAINT;
+ $o->untainted;
+}
+
+{
+ # tests for tainted format in s?printf
+ eval { printf($TAINT . "# %s\n", "foo") };
+ like($@, qr/^Insecure dependency in printf/, q/printf doesn't like tainted formats/);
+ eval { printf("# %s\n", $TAINT . "foo") };
+ ok(!$@, q/printf accepts other tainted args/);
+ eval { sprintf($TAINT . "# %s\n", "foo") };
+ like($@, qr/^Insecure dependency in sprintf/, q/sprintf doesn't like tainted formats/);
+ eval { sprintf("# %s\n", $TAINT . "foo") };
+ ok(!$@, q/sprintf accepts other tainted args/);
+}
https://perl5.git.perl.org / perl5.git / blobdiff