fix small nits

[perl5.git] / run.c

diff --git a/run.c b/run.c
index 543fb08..0d9f7cf 100644 (file)
--- a/run.c
+++ b/run.c
@@ -1,6 +1,6 @@
 /*    run.c
  *
- *    Copyright (c) 1991-1997, Larry Wall
+ *    Copyright (c) 1991-1999, Larry Wall
  *
  *    You may distribute under the terms of either the GNU General Public
  *    License or the Artistic License, as specified in the README file.
@@ -8,6 +8,7 @@
  */
 
 #include "EXTERN.h"
+#define PERL_IN_RUN_C
 #include "perl.h"
 
 /*
@@ -16,55 +17,58 @@
  * know.  Run now!  Hope is in speed!"  --Gandalf
  */
 
-dEXT char **watchaddr = 0;
-dEXT char *watchok;
+#ifdef PERL_OBJECT
+#define CALLOP this->*PL_op
+#else
+#define CALLOP *PL_op
+#endif
 
 int
-runops_standard(void) {
+Perl_runops_standard(pTHX)
+{
     dTHR;
-    SAVEI32(runlevel);
-    runlevel++;
 
-    while ( op = (*op->op_ppaddr)(ARGS) ) ;
+    while ( PL_op = (CALLOP->op_ppaddr)(aTHX) ) ;
 
     TAINT_NOT;
     return 0;
 }
 
-#ifdef DEBUGGING
-static void debprof _((OP*o));
-
 int
-runops_debug(void) {
+Perl_runops_debug(pTHX)
+{
+#ifdef DEBUGGING
     dTHR;
-    if (!op) {
-       warn("NULL OP IN RUN");
+    if (!PL_op) {
+       Perl_warn(aTHX_ "NULL OP IN RUN");
        return 0;
     }
 
-    SAVEI32(runlevel);
-    runlevel++;
-
     do {
-       if (debug) {
-           if (watchaddr != 0 && *watchaddr != watchok)
+       if (PL_debug) {
+           if (PL_watchaddr != 0 && *PL_watchaddr != PL_watchok)
                PerlIO_printf(Perl_debug_log, "WARNING: %lx changed from %lx to %lx\n",
-                   (long)watchaddr, (long)watchok, (long)*watchaddr);
+                   (long)PL_watchaddr, (long)PL_watchok, (long)*PL_watchaddr);
            DEBUG_s(debstack());
-           DEBUG_t(debop(op));
-           DEBUG_P(debprof(op));
+           DEBUG_t(debop(PL_op));
+           DEBUG_P(debprof(PL_op));
        }
-    } while ( op = (*op->op_ppaddr)(ARGS) );
+    } while ( PL_op = (CALLOP->op_ppaddr)(aTHX) );
 
     TAINT_NOT;
     return 0;
+#else
+    return runops_standard();
+#endif /* DEBUGGING */
 }
 
 I32
-debop(OP *o)
+Perl_debop(pTHX_ OP *o)
 {
+#ifdef DEBUGGING
     SV *sv;
-    deb("%s", op_name[o->op_type]);
+    STRLEN n_a;
+    Perl_deb(aTHX_ "%s", PL_op_name[o->op_type]);
     switch (o->op_type) {
     case OP_CONST:
        PerlIO_printf(Perl_debug_log, "(%s)", SvPEEK(cSVOPo->op_sv));
@@ -74,7 +78,7 @@ debop(OP *o)
        if (cGVOPo->op_gv) {
            sv = NEWSV(0,0);
            gv_fullname3(sv, cGVOPo->op_gv, Nullch);
-           PerlIO_printf(Perl_debug_log, "(%s)", SvPV(sv, na));
+           PerlIO_printf(Perl_debug_log, "(%s)", SvPV(sv, n_a));
            SvREFCNT_dec(sv);
        }
        else
@@ -84,38 +88,44 @@ debop(OP *o)
        break;
     }
     PerlIO_printf(Perl_debug_log, "\n");
+#endif /* DEBUGGING */
     return 0;
 }
 
 void
-watch(char **addr)
+Perl_watch(pTHX_ char **addr)
 {
-    watchaddr = addr;
-    watchok = *addr;
+#ifdef DEBUGGING
+    dTHR;
+    PL_watchaddr = addr;
+    PL_watchok = *addr;
     PerlIO_printf(Perl_debug_log, "WATCHING, %lx is currently %lx\n",
-       (long)watchaddr, (long)watchok);
+       (long)PL_watchaddr, (long)PL_watchok);
+#endif /* DEBUGGING */
 }
 
-static void
-debprof(OP *o)
+STATIC void
+S_debprof(pTHX_ OP *o)
 {
-    if (!profiledata)
-       New(000, profiledata, MAXO, U32);
-    ++profiledata[o->op_type];
+#ifdef DEBUGGING
+    if (!PL_profiledata)
+       Newz(000, PL_profiledata, MAXO, U32);
+    ++PL_profiledata[o->op_type];
+#endif /* DEBUGGING */
 }
 
 void
-debprofdump(void)
+Perl_debprofdump(pTHX)
 {
+#ifdef DEBUGGING
     unsigned i;
-    if (!profiledata)
+    if (!PL_profiledata)
        return;
     for (i = 0; i < MAXO; i++) {
-       if (profiledata[i])
+       if (PL_profiledata[i])
            PerlIO_printf(Perl_debug_log,
-                         "%u\t%lu\n", i, (unsigned long)profiledata[i]);
+                         "%5lu %s\n", (unsigned long)PL_profiledata[i],
+                                       PL_op_name[i]);
     }
+#endif /* DEBUGGING */
 }
-
-#endif
-