This is a live mirror of the Perl 5 development currently hosted at https://github.com/perl/perl5
Upgrade to MakeMaker 6.43_01
[perl5.git] / lib / ExtUtils / Changes
CommitLineData
a592ba15
RGS
16.43_01 Tue Jan 1 16:06:47 PST 2008
2 Bug Fixes
3 * Change the "is this really a Perl core library directory" checks to
4 look for strict instead of Exporter. Now that Exporter is on CPAN
5 it can wind up in site_perl.
6 * split_command() will now set aside a little more space for macro
7 expansion. This should help on systems with cramped command line
8 lengths. Specifically, Pugs on Win32. [rt.cpan.org 20145]
9
10 Installation
11 * MakeMaker would not install if the installed MakeMaker was too old,
12 like on 5.6.1. The installation process was still using the
13 installed MakeMaker in a few places. This has been fixed.
14 [rt.cpan.org 24746]
15
16 OS X
17 * "make dist" will no longer bundle up resource fork files (._foo).
18 [rt.cpan.org 29525]
19
20 Docs
21 * The documentation of VERSION_FROM was recommending vstrings (1.2.3)
22 which have never worked right.
23 * The documentation for the accepted values of LICENSE moved to
24 Module::Build::API. [rt.cpan.org 32020]
25
26 Tests
27 * The compilation test was testing the installed modules, not the
28 about-to-be-installed.
29 * xs.t would fail if ExtUtils::CBuilder was not installed.
30
31 Misc
32 * Cleanups brought to you by no more 5.5 compatibility!
33 * MakeMaker is now perlcritic clean at severity level 5... except
34 the really silly ones.
35 * DIE use vars DIE!
36 * Added some resources to the META.yml
37
6d6be53e
RGS
386.42 Fri Dec 7 17:00:14 PST 2007
39 Bug Fixes
40 - 6.33 moved PREREQ_FATAL to happen after CONFIGURE. This meant if
41 your CONFIGURE use a prereq it would fail and no PREREQ_FATAL
42 message would be displayed.
43 - Put the "nicetext" functionality back, VMS needs it to deal with
44 other people's custom make. But rename it to the more
45 accurate maketext_filter(), test it and fix a bug where it would
46 stop processing if it saw a macro declaration.
47
3a0105ce
RGS
486.40 Thu Dec 6 03:00:47 PST 2007
49 Bug Fixes
50 - Remove the dubious nicetext() Makefile formatting hack to account for
51 a lack of space between the target and colon needed on VMS. This
52 interfered with META.yml creation on VMS and possibly other output.
53 - Fix the remaining targets which don't have a space between the target
54 and the colon.
55
3e15aad5
RGS
566.38 Wed Nov 28 16:01:12 PST 2007
57 Releasing 6.37_03 as 6.38.
58
e9f47f3b
RGS
596.37_03 Mon Nov 26 14:15:34 PST 2007
60 Tests
61 - parse_version.t had wrong test count when version.pm isn't installed.
62 - Fixed some warnings in the XS module we're using for testing.
63 - "our $VERSION" test in parse_version.t was never running
64 - Quoting uses of 1.2.3 style versions in parse_version.t to protect
65 older perls.
66
67 Portability
68 - Moved the minimum required version up to 5.6.0.
69
c8d65f10
RGS
706.37_02 Sun Nov 25 23:33:14 PST 2007
71 Test Improvements
72 - Added a test for a basic XS build.
73
74 Bug Fixes
75 - A refactoring in 6.37_01 broke XS compilation.
76
776.37_01 Sun Nov 25 17:05:53 PST 2007
78 Improvements
79 - Upgraded the META.yml to version 1.3 of the spec (which really
80 doesn't change anything). Thanks bdfoy.
81 - MakeMaker now always includes the required 'author' field in
82 the META.yml even if it's undef to comply with the META.yml spec.
83 - Updated ExtUtils-Install to latest version (1.44)
84 - Unified the version numbers of all modules.
85
86 Test Fixes
87 - cd() test on VMS used non-native paths. [bleadperl 31534]
88 - Removed uses of "no_plan" in tests to remain compatible with
89 old versions of Test::Harness.
90 - writemakefile_args.t had the wrong test count if version.pm isn't
91 installed.
92
93 Bug Fixes
94 - $VERSION detection code would be confused by "sub version"
95 [rt.cpan.org 30747]
96 - LINKTYPE=static will now be propagated to child builds.
97 [bleadperl 31761]
98
99 Portability Fixes
100 - Add "dragonfly" to the list of BSDish operating systems
101 - BSD detection code would not pick up bsdos or internix
102 - Fix detection of shared libperl on NetBSD [bleadperl 31526]
103
104
1056.36 Tue Jul 3 01:06:40 PDT 2007
106 Test Fixes
107 - version.pm prior to 0.7203 caused Foo->VERSION to reformat
108 $Foo::VERSION. This caused prereq.t to fail.
109
1106.35 Sun Jul 1 20:53:38 PDT 2007
111 New Features
112 * MakeMaker will now try to "use version" before parsing $VERSION.
113 This allows "$VERSION = qv(1.2.3)" to work.
114
115 Test Fixes
116 - writemakefile_args.t now works with older versions of version.pm
117
1186.34 Sat Jun 30 11:06:54 CDT 2007
119 Test Fixes
120 - Accidentally hard coded the version of strict.pm [rt.cpan.org 27838]
121
1226.33 Fri Jun 29 17:15:34 CDT 2007
123 New Features
124 * VERSION now accepts version objects without warning.
125 [rt.cpan.org 26075]
126
127 Bug Fixes
128 - Properly not installing MANIFEST.SKIP when ExtUtils::Manifest is not
129 being installed. [rt.cpan.org 21318]
130 - fixin() no longer clobbers $/ [rt.cpan.org 26234]
131 - Fixed bug finding cross-compiled perls [bleadperl 31404]
132 - Looking up to 8 levels up to find uninstalled perls
133 [bleadperl 30932]
134 * A test failure in a sub-project would not cause "make test" to
135 fail. [rt.cpan.org 27804]
136
137 Windows
138 - Embed manifest files in EXEs and DLLs when building with VC++ 8.x
139 [bleadperl #29266] [rt.cpan.org 26208]
140 - Improved the subdir command code so DIR can do more than one level
141 down. [rt.cpan.org 25180]
142 - Fix static builds on Win32 by using -DPERLDLL [bleadperl 31229]
143
144 VMS
145 - Use linker flags rather than compiler flags to determine if the
146 perl sharable image was linked debug. This keeps OPTIMIZE from
147 confusing things. [rt.cpan.org 25268]
148 - Accidental use of $\ in a regex. [bleadperl 30521]
149
150 BSD
151 - If calling perl causes MakeMaker to emit warnings, then it
152 cannot find the location of its binary. [rt.cpan.org 23178]
153
154 Doc Improvements
155 - Typo fixes. $(TOUNIX) -> $(TO_UNIX). [rt.cpan.org 23495]
156 - The example for setting $VERSION from $Revision$ in SVN was
157 incorrect. (Thanks to ROBERTMAY@cpan.org) [rt.cpan.org 26995]
158 - Document what's wrong with PREFIX and what to use instead.
159 [rt.cpan.org 12919]
160 - Improve the PREREQ_FATAL docs to make it really clear that you
161 do NOT want to use this!
162
163 Misc
164 - Provide information during the install about whether we're using the
165 installed or provided dependency (ie. ExtUtils::Command).
166 - Updated included versions of ExtUtils::Manifest and Command.
167 - Add .bak and .old to veryclean [rt.cpan.org 21284]
168 - Improved the PREREQ_FATAL message.
169
1706.32 Wed Feb 21 07:59:57 PST 2007
171 New Features
172 - WriteEmptyMakefile() is now exportable upon request.
173
174 Bug Fixes
175 - Set binmode() when writing to files in Command.t for operating
176 systems which need that sort of thing. [bleadperl #29578]
177 - Fixed a minor duplication in manifypod_target(). [rt.cpan.org 22149]
178
179 Test Fixes
180 - The build_man.t test would fail if your Perl is configured to not
181 generate man pages ($Config{installman3dir} is set to none).
182
183 Doc Improvements
184 - Made the home dir install examples a little more friendly to non-Unix
185 folks.
186
187 Misc
188 - miniperl no longer has the Win32 functions.
189 - Turn on "use strict" where it was missing.
190
562c8117
SP
1916.31 Mon Oct 9 16:54:47 PDT 2006
192 - Update our META.yml to version 1.2 of the spec.
193 * Update the SEE ALSO to mention Module::Build, Module::Install,
194 ExtUtils::ModuleMaker and Module::Starter.
195 - Fix ARCHITECTURE tag in PPD generation for 5.8 (patch taken from
196 ActiveState 819). [rt.cpan.org 20566]
197 * Bring ExtUtils::Manifest up to 1.48
198
58d32538
RGS
1996.30_04 Mon Sep 11 16:14:06 EDT 2006
200 - EXTRA_META has been undocumented as I don't like the way the
201 interface works but I don't want to hold up 6.31. It will be
202 replaced with something better next version.
203 - Added explaination of distclean behavior and instructions on how to
204 blow away anything not in the MANIFEST to the FAQ.
205 * 6.30_01 broke overrides of PM. MakeMaker would add to a user
206 suplied PM rather than simply accepting it.
207 * Document INSTALL_BASE.
208 * Added "How do I install a module into my home directory?" to the FAQ
209 * Added "How do I get MakeMaker and Module::Build to install to the
210 same place?"
211 - Moving ExtUtils::Mksymlists and ExtUtils::Mkbootstrap back into
212 lib/ because no independent distribution has taken them over.
213
2146.30_03 Fri Sep 1 17:03:11 EDT 2006
215 - Minor fix to Command.t for Win32.
216
2176.30_02 Fri Sep 1 15:03:55 EDT 2006
218 - Updated to ExtUtils::Install 1.41
219 * Won't scan for and build man pages when MAN3PODS is deliberately set
220 empty.
221 - Minor VMS fixes. [bleadperl@26813]
222 - VMS->one_liner must quote "--" argument. [bleadperl@27613]
223 * Split INSTALLSCRIPT into INSTALLSCRIPT, INSTALLSITESCRIPT and
224 INSTALLVENDORSCRIPT so it now honors INSTALLDIRS. [bleadperl@26536]
225 - Minor fix to work with Pod::man 2.04. [bleadperl@26457]
226 - $Revision was broken.
227 - Updated our internal version of Test::More to catch a few warnings.
228 - ExtUtils::Command::test_f() test was broken.
229 - Clarified that test_f() exits.
230
2977d345
RGS
2316.30_01 Tue Aug 16 23:53:27 PDT 2005
232 * Fixed compiling modules using an uninstalled Perl on Win32 by using
233 the proper perl header location for Windows (which is different from
234 Unix). Looks like a very old bug. [bugs.perl.org 36128]
235 - $ExtUtils::MakeMaker::Revision accidentally left in a stray "Revision".
236 [thanks pdx.pm for noticing this]
237 - Fixed the $VERSION = $Revision$ example in the MakeMaker docs and the
238 FAQ. [thanks again, pdx.pm]
239 - Elaborated on the differences between CVS, SVN and others when using
240 $Revision$ based $VERSIONs.
241 * ExtUtils::Command, ExtUtils::Install, ExtUtils::Manifest,
242 ExtUtils::Mkbootstrap, ExtUtils::Mksymlists and ExtUtils::Packlist
243 are all now considered to be separate distributions. To avoid a
244 circular dependency, MakeMaker distributes its own versions but CPAN
245 should not index them and they will not overwrite a newer, installed
246 version.
247 * Added EXTRA_META option to allow module authors to append extra
248 text to the generated META.yml.
249 * Added a LICENSE field mirroring Module::Build's license.
250 * META.yml support updated to version 1.1. All required fields
251 now generated. (NOTE: 1.1 isn't yet complete but we're going with
252 it anyway. MakeMaker uses "author" instead of "authored_by" as its
253 expected the former will be used in 1.1 final).
254 * Non-conforming version_from and installdirs META.yml fields removed.
255 * META.yml distribution_type field now intelligent enough to guess at
256 the type rather than hard code 'module'.
257 * INSTALLBASE changed to INSTALL_BASE to match Module::Build.
258 * Added a MAKE parameter for Windows users to say if they're using
259 dmake or nmake.
260
4325052d
RGS
2616.30 Fri May 20 16:05:38 PDT 2005
262 * PL_FILES behavior tweak again to restore old behavior. Sometimes its
263 supposed to run before pm_to_blib, sometimes after.
264 - Some tests shipped with 'no_plan' which will break on older
265 Test::Harness.
266
41e5fcb0
RGS
2676.29 Thu May 19 14:15:21 PDT 2005
268 * The behavior of PL_FILES is restored to its pre-6.26 behavior as several
269 CPAN modules depend on this. PL programs run via PL_FILES have
270 INST_LIB and INST_ARCH in their @INC and so can load any just built
271 modules.
272 - Now honors PERL_CORE environment variable.
273 - Testing to ensure FIRST_MAKEFILE is honored.
274
76ca89ed
RGS
2756.28 Tue Apr 12 16:17:07 PDT 2005
276 - Fix realclean so it cleans up files installed from ext/ in the core
277 - Fix dir_target() so it doesn't warn should any of the INST_* paths
278 be the same (as with the ext/ modules in the core)
279 - Fix MANIFEST.SKIP so it skips not just _darcs/ but everything inside
280 it and any which happen to be in subdirs.
281 - MM_AIX forgot to import neatvalue() from E::MakeMaker.
282 (bleadperl@24185)
283 - Fixed a minor C<<>> POD nit (Scott Lanning)
284
7292dc67
RGS
2856.27 Mon Apr 4 16:36:14 PDT 2005
286 * Added _darcs to the list of revision control administrative
287 directories skipped both in libscan and in MANIFEST.SKIP.
288
2896.26_01 Mon Mar 28 21:34:39 PST 2005
290 * PL_FILES was broken in the last release. The .PL files were not being
291 passed the file they were to generate.
292 * How PL_FILES runs the programs and what it does with the value is
293 now documented.
294 * The default behavior of PL_FILES is now documented.
295
2966.26 Mon Mar 21 20:36:22 PST 2005
297
2986.25_12 Fri Mar 18 16:15:35 PST 2005
299 - Use the generic dmake search.cpan.org URL in the README so the newest
300 version is found.
301 - Fixed pm_to_blib trouble on VMS introduced in 6.25_10.
302
3036.25_11 Tue Mar 15 02:00:20 PST 2005
304 - Fixed minor parent class dependency loop in ExtUtils::MM_Any.
305 - Fixed a circular dependency on processed PL files introduced as part
306 of RT 6460 in 6.25_02.
307
3086.25_10 Sun Mar 13 16:14:04 PST 2005
309 - pm_to_blib.ts is gone, back to pm_to_blib (except on VMS). I
310 couldn't make it work and still retain backwards compatibility.
311 This fixes the recompilation problems that plagued _09 and various
312 previous alpha releases.
313
3146.25_09 Sat Mar 12 10:10:34 PST 2005
315 - Stubbing out PASTHRU on VMS. $(MMSQUALIFIERS) should do the equivalent
316 and better.
317 - Added test to check for the existence of a compiler so XS tests are
318 now possible.
319
3206.25_08 Tue Feb 8 09:04:36 EST 2005
321 - Fixing xsubpp on VMS. Had a foo/bar path in it.
322 - Turning XSUBPP into a runable command by the addition of PERLRUN
323 made it unusable as a dependency. Added XSUBPPRUN for that and left
324 XSUBPP alone.
325 - Removed DESTDIR from PASTHRU as install is not recursive and it can
326 make commands too long on VMS.
327 - Older versions of MMS cannot handle directory targets at all. Using
328 .exists files everywhere.
329 - Restore missing *.Opt clean on VMS.
330 - Fix .exists files accidentally getting caught in static builds.
331 - Older versions of MMS cannot handle directory targets at all.
332 - Add Interix support (bleadperl@33892)
333 - distsign target changed to distsignature to avoid clash with
334 Module::Install
335
3366.25_07 Fri Dec 31 03:47:20 EST 2004
337 - perllocal on VMS was inserting executables twice.
338 - No longer using $(IGNORE) macro. Turns out MMS/K was not honoring
339 it. Using "-$(NOECHO) command" which seems to make everybody happy.
340 - Executables with no extension weren't getting installed on VMS due to
341 a bug in rename(). Broken sometime in this series of alphas.
342
3436.25_06 Sun Dec 26 17:21:37 EST 2004
344 - Forgot to define BOOTDEP macro.
345 - .exists files are back. Directories cannot be used directly as
346 targets as their mod time changes too frequently.
347 * Added INSTALLBASE as an alternative to PREFIX but haven't documented
348 it yet. I'll do that next release.
349
3506.25_05 Wed Dec 22 07:59:02 EST 2004
351 - One of the 6.25 alphas broke BSD make. It doesn't like "- @ command".
352 Fixed by adding an $(IGNORE) macro.
353 - 6.25 alphas caused a Makefile to be added to the dist. Fixed.
354 - The new cd() code needed to be dependent on dmake or nmake for
355 Windows. Not Win9x vs WinNT/XP.
356
3576.25_04 Tue Dec 21 00:53:06 EST 2004
358 - 6.25_03 was always rebuilding XS modules.
359
3606.25_03 Mon Dec 20 23:04:22 EST 2004
361 - dir_target() is back. Now each directory to be created has its own
362 target like before, but no more .exists or blibdirs.ts files. This
363 ensures that each blib directory is created as necessary and fixes
364 things like SVN's perl bindings.
365
3666.25_02 Mon Dec 20 03:31:49 EST 2004
367 - Set PM_FILTER as late as possible so it can see all the earlier
368 macro definitions. Necessary for challenged make implementations
369 like nmake. Should fix Mail::SpamAssassin installs on Win32.
370 [rt.cpan.org 4545]
371 - clean and realclean are now more careful about accidentally deleting
372 directories instead of files. [rt.cpan.org 6851]
373 - small fix for parallel builds, make sure pm_to_blib has run before
374 we try to use stuff in blib. [rt.cpan.org 6460]
375 - MAKEFILE=foo appears to have been broken for recursive builds and
376 several other things. I think this was broken by 6.18.
377
3786.25_01 Fri Dec 17 21:29:04 EST 2004
379 * *.bak added to the default MANIFEST.SKIP.
380 * META.yml will no longer be generated in the build directory. It will
381 only appear in the distdir. This should make it easier on developers,
382 they don't have to worry about checking the file in all the time.
383 * Similarly, the SIGNATURE file will not be updated in the build
384 directory. It will only be generated in the distdir.
385 - A bunch of redundant Win9x and VMS code removed.
386 - 'make test' on Windows no longer pre-expands its list of test files.
387 This caused problems on large distributions like bioperl. Thanks to
388 Tim Bunce for suggesting the obvious fix.
389
5dca256e
RGS
3906.25 Wed Dec 15 06:59:46 EST 2004
391 - Build.PL was being considered like Module_pm.PL. Build.PL is now
392 ignored. [radek@karnet.pl] [rt.cpan.org 8809]
393 - Devel::Cover cover_db/ directory now ignored by MANIFEST.SKIP
394
3956.24_01 Thu Dec 9 00:44:48 EST 2004
396 - Docs encouraged possibly insecure use of /tmp [CAN-2004-0976 via Debian]
397 - Remove empty rpath from .so files [bleadperl@23183]
398 - At long last the core man page title has its apostrophe.
399 - BeOS tests fixed [Ingo Weinhold] [perlbug #32717]
400 - Putting a pm_to_blib target back (alias of pm_to_blib.ts) in case
401 anyone was depending on it being there (mod_perl was).
402
4036.24 Tue Nov 30 15:35:13 EST 2004
404 - dir_target() was accidentally named dir_targets() causing problems
405 installing some Tk modules.
406
4076.23 Fri Nov 26 16:01:50 EST 2004
408 - MM_MacOS lost its $VERSION causing some CPAN indexing problems. Enough
409 people noticed this to warrant a quick release.
410
4116.22 Tue Nov 23 22:22:22 EST 2004
412 - Minor glitch in Command.t test on Win32 [thanks Steve Hay]
413 * Fixed MANIFEST.SKIP so it avoids all the new *.ts files.
414 - Don't spuriously define pasthru arguments
415
4166.21_03 Sat Apr 3 2004
417 - pm_to_blib and blibdirs stamp files now pm_to_blib.ts and blibdirs.ts
418 everywhere because some filesystems insist you have a dot in the
419 filename. This eliminates a bunch of special case code.
03c94fc2
RGS
420 - Minor potential glitch in the version check logic.
421 - Making Makefile rebuild logic more resistant to inconsequential
422 errors when cleaning up things that are going to be rebuilt anyway.
423 - Adding SCCS to the list of directories in MANIFEST.SKIP.
5dca256e
RGS
424 * Fixing blibdirs so it doesn't rebuild every make run.
425 * Using a more conservative MAX_EXEC_LEN for Win98 to allow building
03c94fc2 426 large modules like Encode. [Greg Matheson]
5dca256e 427 * test target mangled by dmake. Doesn't seem to like q{}.
03c94fc2
RGS
428 [Greg Matheson]
429 - instmodsh now using Archive::Tar to create archives if available.
430 [Slaven Rezic]
431 - instmodsh now using more portable tar flags to create archives.
432 [Slaven Rezic]
433 - Added FAQ entry for "How do I use a module without installing it?"
434 and "How do I keep from installing man pages?" [Joe Cromie]
5dca256e
RGS
435 - Fixed finding the default MANIFEST.SKIP if its on a different volume
436 [Ilya Zakharevich]
437 - When building Perl, we had a chance of picking up the old installed
438 xsubpp from @INC [Andreas Koenig]
439 - makeaperl() now a bit more intellegent about ignoring perl libraries
440 not called libperl. [Ilya Zakharevich bleadperl@22032]
441 * MacOS Classic (MacPerl) is no longer supported. Please use
442 Module::Build instead.
443 * Restored pm_to_blib.ts so pm_to_blib generation will be quiessent on
444 VMS. [rt 4675]
445 - For simplicity, dir_target() is now a no-op. Should not effect any
446 existing uses.
447 - Converted utility commands from using $(PERLRUN) to $(ABSPERLRUN).
448 This allows distclean to work with SDBM_File. [rt 5616]
449 - realclean was using "rm -f" instead of "rm -rf" meaning directories
450 wouldn't be properly cleaned. Caused by bleadperl@7952. [rt 5208]
451 - fixpath() could undo wraplist() on VMS [rt 4955]
452 - ensure ExtUtils::Command::rm_f deletes all versions of a file on VMS
453 [rt 4687]
454 - hint.t generating improperly named hint files on OS's where $^O
455 contains a '.'. They should be converted to underscores. Test
456 mistake, not a bug. [rt 5365]
457 - Fixed ExtUtils::Command::chmod() so it will work on directories on
458 VMS. [rt 4676]
459 - parse_version.t was using no_plan causing trouble on older T::Hs.
460 [rt 5633]
03c94fc2 461
af7522e5 4626.21 Tue Nov 11 00:12:56 PST 2003
03c94fc2 463 - NetBSD was looking in INSTALLARCHLIB/CORE for libperl instead of
af7522e5
RGS
464 PERL_ARCHLIB/CORE. Would cause problems if INSTALLARCHLIB was changed
465 (ie. LIB or PREFIX used). [Jochen Eisinger]
466 - Turns out a handful of modules use dir_target(). Restored a version
467 for backwards compatibility.
468 - Moved blibdirs target from top_targets() to its own section. Lots of
469 modules rewrite top_targets() so blibdirs wouldn't be written.
470
dd0810f9
RGS
4716.20 Thu Nov 6 02:25:58 PST 2003
472 - Fixing dos2unix on Cygwin. In-place editing doesn't work 100% so we
473 take a more conservative approach.
474 - Small postamble.t test temp file cleanup fix for Cygwin and Windows.
475 - Small Command.t test fix for 5.5.3. No real bug [rt 4290]
476 - Small Liblist fix for Cygwin and import libraries [Gerrit P. Haase]
477 - metafile error message slightly mangled. Bare $! mistake confusing
478 nmake [rt 4285 4301]
479
a7d1454b
RGS
4806.19 Mon Nov 3 22:53:56 PST 2003
481 - Removed 00setup_dummy.t and zz_cleanup_dummy.t. Tests now setup and
482 teardown the dummy modules as needed.
483 - Little test glitch on systems without $Config{usevendorprefix} set
484 - INSTALL(SITE|VENDOR)MAN*DIR now fall back to $(INSTALLMAN*DIR)
485 instead of copying its value. This lets "perl Makefile.PL
486 INSTALLMAN1DIR=/some/man/man1" work like expected.
487
4886.18 Mon Nov 3 20:09:51 PST 2003
489 - parse_version() was blowing over $_ (Ilya Zakharevich)
490 - 5.6.2 has the same Cygwin shared lib name fix as 5.7.0. (Gerrit Haase)
491 * When $Config{install(site|vendor)man*dir} aren't set it will now
492 fall back to $Config{installman*dir}. Similar for
493 $Config{install(site|vendor)bin}. This preserves behavior for older
494 Perls.
495 * Eliminated the dependency on perl.h for pure-perl builds.
496 * Eliminated .exists files. Added blibdirs target using MKPATH instead.
497 - Removed now unused dir_target() method.
498 - Added a little documentation to instmodsh.
499 * Made sure PREFIX always has something in it. Module authors like to use
500 it when extending MakeMaker. Currently using one of
501 PERL/SITE/VENDORPREFIX based on the value of INSTALLDIRS.
502 * Added SIGN to generate module signatures with cpansign (Autrijus Tang)
503 - Slight tweaks to MAKEFILE_OLD and MAKE_APERL_FILE restoring a mistake
504 made around 6.06 to fix static builds on OS/2
505 - Added ExtUtils::Command::dos2unix()
506 * manicopy() would make the copied files read-only if 'cp' was used.
507 * Fixed prereq check for modules which are also keywords like if.pm and
508 open.pm (Autrijus Tang)
509 - Made ExtUtils::Command mv and cp return whether or not they succeeded.
510 * metafile_addtomanifest now mentions what its doing.
511 * metafile will not die if it can't write to META.yml, just emit a
512 warning. This lets 'make dist' continue with a read-only META.yml
513 - Small fix to identify UWIN on NT (Randy Sims)
514 * metafile will not touch the META.yml if it does not need to be changed
515 (Thanks to Tim Bunce for this idea)
516 * Fixed 'make uninstall' which looks like its been broken since last
517 November and nobody noticed.
518 - Fixing minor bug in VMS prefixification logic when PREFIX was not set
519 by the user.
520 - Fixing potential bug in prefixification for relative directories
521 * Documented UNINST=1
522
30361541
JH
5236.17 Sun Sep 14 20:52:45 PDT 2003
524 - Fixing LD so it can be set properly on Win32. (Orton Yves)
525 * Fixing the init_PERL() "tack $Config{exe_ext} onto $^X" logic so
526 it works on VMS allowing $^X to be found.
527 * Fixing make install UNINST=1 on Windows so it can search PERL5LIB
528 (Orton Yves)
529 - Fixing "could not open MANIFEST" test for OS/2 (and probably others)
530 where a read-only file cannot be deleted.
531 - Hacking around the fact that when built for debugging, VMS creates
532 ndbgperl.exe.
533 - Eliminating the never implemented "help" argument.
534
2c91f887
JH
5356.16 Mon Aug 18 01:39:51 PDT 2003
536 * Fixing the max exec length for Windows to account for old
537 versions of nmake (the one you can download for free from MS).
538 - Hack to normalize //foo//bar paths in ExtUtils::Installed.
539 [Sreeji K Das]
540 * Adding Module::Build utility files to MANIFEST.SKIP
541 - PREREQ_PRINT is supposed to exit after dumping. (Wolfgang Friebel
542 bleadperl@20530)
543 - maniadd() was trying to open the MANIFEST even if it didn't need to
544 causing unnecessary errors for read-only MANIFESTs (rt.cpan.org 3180)
545
64964e6d
JH
5466.15 Sun Aug 3 16:41:05 PDT 2003
547 - Make FIXIN on Win32 use the new pl2bat rather than an already
548 installed one when building the core (Mattia Barbon)
549
5506.14 Sun Aug 3 16:23:27 PDT 2003
551 - Adding a reference to the Module::Build META.yml spec in the META.yml
552 itself and the metafile documentation.
553 - Removed Begin/End comments from manifypods that were getting in the
554 way of users adding code to the manifypods target.
555 - Putting a POD2MAN macro back as an alias to POD2MAN_EXE and using
556 it instead of POD2MAN. This allows people to generate their own man
557 installation targets in a backwards compatible way.
558 * Adding reference to the Module::Build META file spec in the docs.
559
0fdc96ff
JH
5606.13 Thu Jul 31 16:48:01 PDT 2003
561 - Generated META.yml now has the prereqs in sorted order (Andy Lester)
562 - Arguments to child Makefile.PLs were still having .. prepended. This
563 was exposed by the earlier fix of rt.perl.org 4345.
564 - extralibs.ld (for static builds) wasn't being cleaned up.
565
1b0fc073
JH
5666.12 Tue Jul 29 22:19:38 PDT 2003
567 - Should any of your prefixes be /, MakeMaker might lose this and
568 prepend your prefix as "prefixyour/directory" rather than
569 "prefix/your/directory" (Ed Moy bleadperl 20283)
570 - Reversing "realclean was duplicating work already done by clean"
571 (CVS 1.124 MM_Unix.pm). Turns out it wasn't a duplication and this
572 was causing INST_* files to be left behind if your INST_LIB wasn't
573 blib/* as in the perl core. realclean now removes the files copied
574 to INST_*.
575 - Eliminating xsubpp_version(). No longer relevant. It was checking
576 for a feature added to xsubpp before 5.003_07 and doing it in a
577 really bizarre way.
578
5796.11 Thu Jul 24 01:24:37 PDT 2003
580 - Small grammatical doc touch up by Sean Burke
581 - Making basic.t clean up better after itself so it can be run
582 twice without setting up and cleaning up Big-Dummy again.
583 * Noting where to find make in the README
584 * Noting that MakeMaker does not produce a GNU make compatible Makefile
585 on Windows.
1b0fc073
JH
586
5876.10_08 Mon Jul 21 18:17:06 PDT 2003
588 * $Config{installvendorman*dir} was being ignored and our default
589 always used. [rt.cpan.org #2949]
590 * Setting NORECURS to true was still resulting in a Makefile which
591 tried to recurse into subdirectories which contained a Makefile.PL
592 (it simply wouldn't have run them to generate Makefile's).
593 This appears to be a rather old bug.
594 [rt.cpan.org #2951]
595 * [rt.perl.org #4345] Arguments passed to WriteMakefile() would get
596 stopped upon by $self->{PARENT} in recursive builds in the process
597 of prepending a .. onto it.
598 - Command.t now using its own temp directory when testing
599 expand_wildcards() so no stray files confuse it.
600 * No longer warning about 'postamble' attribute.
601 - Added installvars() to list INSTALL* variables so we don't keep
602 repeating the list all over the code.
603 - Added init_DEST() to create DESTINSTALL* variables for installing
604 with DESTDIR set.
605 * DESTDIR + PREFIX now does not duplicate DESTDIR. [Redhat #91892
606 and part of rt.cpan.org #2954]
607 * DESTDIR is now not directly prepended to the INSTALL* variables.
608 installation targets now use DESTINSTALL* instead. This prevents
609 the DESTDIR from showing up in places it shouldn't like perllocal.pod.
610 DESTDIR is still appearing in .packlist (bug). [rt.cpan.org #2954]
611 - MM_VMS->prefixify() wasn't honoring the %Config_Override causing
612 some MakeMaker generated config variables to be ignored.
613 - MM_VMS->prefixify() was only VMSifying part of its filepaths causing
614 internal comparisions to get confused and think it had to prefixify
615 when it didn't.
616
6176.10_07 Sat Jul 5 16:12:52 PDT 2003
618 * Fixing location of perllocal.pod so its always in INSTALLARCHLIB
619 instead of one for each perl, site and vendor.
e3aa3ecb
MS
620 - Sun's make treats escaped newlines oddly. Switching oneliner() back
621 to using multiple -e's.
622 * Bug in libscan() meant that any .pm containing RCS or CVS or SCCS
623 in its name (for example, RCS.pm) would be skipped.
624 - Command.t was getting confused in the core because it was reading
625 files from the core t/ directory, not MakeMaker's t/ directry.
626 - MM_OS2 PERL_ARCHIVE_AFTER test wrong for a.out systems (Ilya)
1b0fc073
JH
627 - Fixing perllocal.pod and XS installation on VMS. An extraneous
628 newline was introduced when changing the install macros over to
629 $(ECHO).
630 - Added $(ECHO_N) macro to emulate 'echo -n'
e3aa3ecb 631
c2990482
MS
6326.10_06 Sat Jun 7 00:55:29 PDT 2003
633 - Whoops, Liblist.t busted on VMS after I turned strict on in
634 ExtUtils::Liblist::Kid. Merely a test bug, not a real bug.
635 - Fixed metafile_addtomanifest failure so the proper error shows.
636 - Fixed metafile_addtomanifest failure diagnostic leaking out during
637 the basic.t test on Windows.
638
1df8d179
MS
6396.10_05 Fri Jun 6 18:15:30 PDT 2003
640 * Documenting META.yml, NO_META
641 * Documenting the fact that distdir will auto generate META.yml and
642 alter your manifest.
643 * Adding META.yml autogeneration to the FAQ
644 - Recognizing comments with leading whitespace in MANIFESTs better.
645 - Small ExtUtils::Liblist::Kid problem on VMS (Craig Berry)
646 * Fixed "make install UNINST=1". Appears to have been broken somewhere
647 around 6.06_01.
648 - Documented the fourth argument to ExtUtils::Install::install()
649 - install() will now honor a PERL5LIB change between ExtUtils::Install
650 loading and install() running when uninstalling shadows.
651 - META.yml generation deals gracefully when the MANIFEST is read-only
652 (Slaven rt.cpan.org 2723)
653 - Fixing tests on limited dir depth VMS systems by moving the
654 dummy-install dir one level up (Craig Berry rt.cpan.org 2747)
655
2530b651
MS
6566.10_04 Fri May 23 01:13:04 PDT 2003
657 - Working around BSD threaading bug in version check. [from bleadperl]
658 - Added the Makefile to the dist dependencies. (Slaven Rezic)
659 - Reversing the find_perl() version check failure warning introced in
660 6.10_03. Too talkative, warned when nothing was wrong.
661 * Fixing META.yml auto-addition when there's no newline at the end
662 of the MANIFEST [rt.cpan.org 2444]
663 * Making it a bit more obvious in the MANIFEST where META.yml comes from.
664 - Fixed $_ clobbering in ExtUtils::Manifest functions.
665 - [rt.cpan.org 2591] some LD_RUN_PATH thing (Marek Rouchal)
666 - Added core.\d+ files to 'make clean' [rt.cpan.org 2543] (Slaven Rezic)
667 - INST_* targets were expanded too early (Stas Bekman)
668 - Adding ExtUtils::MakeMaker::bytes (bytes.pm backwards compat wrapper)
669 - Fixing MM_MacOS so it will compile on 5.5.x machines (use bytes wrapper)
670 * Reducing perldepend set of CORE/*.h dependencies to what 5.5.3 has.
671 5.5.3 should be able to compile XS again.
672 * Eliminating fakethr.h and perlsfio.h from VMS's perldepend as they
673 sometimes don't get installed.
674 - ExtUtils::Install was making a few directories even with the
675 "don't really do it" switch on (Slaven Rezic)
676 * can build static linked perl binaries again. Probably damaged in
677 6.06_01 when $self->{MAKEFILE} became FIRST_MAKEFILE. (Nick Clark)
678
6796.10_03 Fri Apr 11 00:21:25 PDT 2003
680 * Added NO_META WriteMakefile() option to suppress generation of
681 META.yml. (Spoon, rt.cpan.org 2359)
682 - Spurious linebreak in uninstall_from_sitedirs on VMS (Craig Berry)
683 * A bit after 6.05 man page names would come out as lib::Foo::Bar
684 if the module name didn't contain a ::. Found with podulators.
685 Fixed.
686 * Skipping installation of RCS ,v files.
687 * 'make ci' was busted between 6.05 and 6.06_01. Fixed. (Andreas)
688 - 'make test' was broken when there's no tests. Introduced in 6.06_03.
689 (Stas Bekman)
690 - Solving some directory depth problems in tests on oldish VMS systems.
691 (Craig Berry)
692 - Fixing MM_MacOS so it compiles on UTF-8 systems. (Jarkko)
693 - Making find_perl() more talkative when the version check fails
694 miserably.
695 - Fixing PERL_ARCHIVE on VMS so XS can compile again (Craig Berry)
696
6976.10_02 Mon Apr 7 00:57:15 PDT 2003
698 * Removed 2>&1 experiment introduced in 6.10_01 for all non-Unixen
699 except for OS/2. Thought Perl might emulate `... 2>&1`. It doesn't.
700 Just on OS/2.
701
7026.10_01 Sun Apr 6 19:31:42 PDT 2003
703 - Making install "Skip ... (unchanged)" message happen consistently
704 - Checking file sizes as well as modification times when deciding
705 to skip installing a file.
706 - OS/2 was using $(RM) instead of $(RM_F) (Ilya)
707 - OS/2 needs .dll removed on failed build (Ilya)
708 - fixin() was assuming that rename() can overwrite the target (Ilya)
709 - manifypods target was empty if there are no pods to manify. Put in
710 at least $(NOECHO) $(NOOP)
711 - Cygwin test to check for finding pod2man when building the perl core
712 removed. No longer relevent.
713 - Small fixes for dmake (Mattia Barbon)
714 * Added "Reporting bugs" section to the PATCHING doc.
715 - Minor bug in compile test missed ExtUtils::Liblist::Kid
716 - Removing $(VERSION_FROM) from Makefile dependency. It was too
717 annoying to rebuild the Makefile every time the module changed.
718 Mentioned it in the FAQ instead.
719 - Fixing PERL_ARCHIVE macro on VMS. Apparently it never appeared
720 properly before. (Craig Berry)
721 - Fixing ECHO on dmake.
722 - Adding os_flavor() and os_flavor_is()
723 - Making basic.t error output combine STDOUT & STDERR for easier
724 reading.
725 * ExtUtils::Manifest will now work case insensitively.
726 - Fixed 'subroutine redefined' warnings in 00compile.t
727 - Fixed it so typemaps are only looked for in the perl core library.
728 * Hacking around VMS filesystem problems reconstructing package names
729 from filenames in ExtUtils::Installed. (Jesper Naur)
730
731# There was no 6.06, I jumped straight to 6.10_XX because there's been
732# so much change between 6.05 and now.
733
7346.06_05 Mon Mar 31 02:44:11 PST 2003
479d2113
MS
735 - Syncing into bleadperl. Minor nits revealed...
736 - AutoSplit open filehandle bug was fixed in bleadperl. Averted a
737 warning because of this.
738 - hint files were only being loaded if . happened to be in @INC.
739 A bug/feature of File::Spec was stripping off the current dir from
740 the front of hintfile paths causing Perl to look for them in @INC.
741 Worked around.
742 - Now checking $! for errors if a hint file returns undef
743 - compile test was testing all of perl! Scaling back to just ExtUtils/
744
7456.06_04 Sun Mar 30 20:34:39 PST 2003
746 - Now looking for ExtUtils::xsubpp through @INC rather than just
747 the perl core directories. This helps ExtUtils::ParseXS.
748 - Systems which don't put their libraries under their $Config{prefix}
749 (OS X, Debian) weren't putting their libraries in the spot declared
750 in Config. It was going under $Config{prefix}.
751 - Prerequisites check now deals better with X.Y_Z style alpha versions
752 - ExtUtils::Liblist->ext() was using $Config{perllibs} which is a 5.6.1
753 thing. Falling back to $Config{libs} if perllibs isn't there.
754 - ExtUtils::Command::MM now reads from @ARGV if called with no
755 args. Makes the one liner a bit simpler.
756 * Restored ExtUtils::Liblist::ext() for backwards compatibility.
757 Missing since 5.6.1.
758 - Switching to relative dirs for self-building to shorten
759 command line lengths.
760 - Fixing minor test warning on VMS when compiling ExtUtils::Manifest
761 - Skipping STDIN read prompt() tests on 5.5.3. Can't test due to
762 eof() not honor tied handles.
763 - Config.pm on 5.5.3 doesn't have any concept of vendor*. This was
764 causing warnings when generating the Makefile.
765
7666.06_03 Sat Mar 29 19:44:53 PST 2003
767 - Added AUTHOR and ABSTRACT_FROM info for ppd generation.
768 - Added echo() method to portably echo text to a file.
769 - Worked around 5.8.0 eval 'require Foo::Bar' bug causing MakeMaker
770 to think modules weren't installed.
771 - Modernized VMS doc_*_install targets
772 - Changed some $(PERL) -e "print ..." code to use $(ECHO).
773 - Replaced uses of Delete/NoLog/NoConfirm with $(RM_F) in MM_VMS
774 - Fixed some duplicate macros making MMS happy.
775 - Fixed $ExtUtils::MM_VMS::Revision. It was just the $VERSION before.
776 - Fixed ExtUtils::Command::MM::perllocal_install(), uninstall(),
777 warn_if_old_packlist().
778 * Pulling File::Spec::VMS::fixpath() and eliminate_macros() into MM_VMS
779 as the new cannonical location. They never should have been in F::S
780 in the first place.
781 * ExtUtils::Command::eqtime() would truncate the file being equalized!
782 Holdover from exclusive .exists usage.
783 - Cleaned up hard coded 'echo' and '@' to $(ECHO) and $(NOECHO)
784 - $(SAY) is now $(ECHO) on VMS
785 - Moved rogue initializations from tools_other() to init_others()
786 - Normalized MM_VMS's tools_other() to mostly use its superclass.
787 - split_command() was off-by-one when calculating max command line
788 lengths causing it to run over on VMS
789 - made split_command() a bit smarter, taking into account some macro
790 expansion
791 - Fixed initialization of OBJECT, DISTNAME and LDFROM on VMS
792 - Fixed *_install target uses of File::Spec.
793 - Added ExtUtils::MakeMaker::vmsish wrapper around vmsish so MM_VMS
794 can be compiled on non-VMS machines. For testing.
795 * Added ExtUtils::MakeMaker::Tutorial about writing modules with
796 MakeMaker.
797 - Removed "always use h2xs" dogma.
798 - Added compile & POD test
799 * 'make distdir' now generates META.yml module meta-data file.
800 Proof of concept. Have to syncronize with Module::Build.
801 * Added maniadd() to ExtUtils::Manifest to add entries to the MANIFEST
802 * ExtUtils::Command::chmod was not interpreting file permissions as
803 octal. Also, docs & tests slightly wrong (thanks Stas Bekman).
804 - ExtUtils::Install was hard coding blib/lib and blib/arch, unportable
805 [perl #21526]
806
8076.06_02 Mon Dec 23 20:39:57 PST 2002
808 * Lots of Win32 fixes busted between 6.05 and 6.06_01.
809 * split_command() tests still not happy on Win32. Problems with
810 shell vs Makefile escaping makes testing difficult.
811 * VMS still broken. Need to convert File::Spec method calls back to
812 object method calls so the weird FS::VMS->eliminate_macros() and
813 fixpath() work again.
814
8156.06_01 Thu Dec 19 00:14:49 PST 2002
816 - Andreas found that when building the core it is desirable for
817 MakeMaker to use a relative path to perl.
818 - File::Spec->catfile() has a bug where the resulting file may not be
819 canonicalized. This was causing problems when generating manpaths.
820 MakeMaker now uses its own fixed override for catfile().
821 - Fixed the POD recognition regex to properly catch /=head\d/ tags.
822 * Added a PATCHING guideline document.
823 - Updated the class hierarchy in NOTES.
824 - Installed.t now cleans up after itself better.
825 - Steve Purkis rewrote the manifypods system to use Pod::Man
826 rather than pod2man. Its now portable and manifypods() moved from
827 MM_Unix to MM_Any. As a result, lots of icky and redudant code went
828 away. This also removes the POD2MAN macro, but noone should be
829 using that.
830 - "make manifypods" now works on Win32
831 - "make manifypods" is now be faster
832 - Made MM_Unix->find_perl more portable. Eliminated MM_Win32->find_perl
833 override. MM_VMS->find_perl remains.
834 * find_perl() can now handle filenames with spaces in them (RT448)
835 * find_perl() on Win32 no longer produces spurious "File Creation error"
836 messages (perlbug ID 20020709.001)
837 - Removed unfinished and unused maybe_command_in_dirs()
838 - Removed dead SelfLoader cruft from MM_Unix.
839 - Fixed PPD generation when the ppd contains quotes (RT1473)
840 - Fixed PPD generation on VMS
841 - Moved Win9x specific subdir_x() code from MM_Unix to MM_Win95
842 * Craig Berry fixed hint files on VMS
843 - Added the perl_onliner() method to generate portable, safe one-liners
844 - Changing hardcoded $self->{MAKEFILE} to $(FIRST_MAKEFILE).
845 * Rafael Garcia-Suarez made MakeMaker ignore Subversion control files
846 by default.
847 - Added MAKEFILE_OLD macro.
848 * No longer generating man pages by default on VMS.
849 - Improved DISTNAME docs
850 * Documented DISTVNAME and VERSION_SYM
851 * Documented dist()
852 - Seperated dist_core() into dist, tardist, uutardist, tarfile,
853 zipdist, zipfile and shdist_target methods. Allows elimination
854 of redundant code in MM_VMS.
855 - Replaced WARN_IF_OLD_PACKLIST, DOC_INSTALL and UNINSTALL
856 one-liners with ExtUtils::Command::MM functions
857 - Replaced VMS hand-rolled perl code for TOUCH, CHMOD, RM_F and RM_RF
858 with ExtUtils::Command functions. Added TEST_F.
859 - Adding clean_subdirs target and clean_subdirs_target() method to
860 generate same. This allows easier overriding of an unportable part
861 of the clean target.
862 - Defined DEV_NULL for MacOS
863 - Removed ROOTEXT from MM_MacOS, apparently unused
864 - Added $(DIRFILESEP) macro and init_DIRFILESEP to avoid
865 hardcoding / or \. Reduces code duplication in the MM_* modules.
866 - Added init_platform() and platform_constants() for OS specific
867 macros. Moved OS specific macros from constants() overrides there.
868 - Added init_VERSION() to setup various *VERSION* macros.
869 - Added default wraplist() to make porting easier.
870 - Added makemakerdflt_target() to guarantee 'all' is the default
871 target.
872 - Added special_targets() to handle things like .PHONY and make sure
873 they come first.
874 - Added init_linker() to initialize linker relatied macros.
875 - MM_MacOS constants() disolves
876 Moved MACPERL_SRC, MACPERL_LIB, MACPERL_INC from init_main() to
877 init_platform().
878 Moved DEFINE and INC tweaking from constants() to init_main()
879 Moved DEFINE_VERSION & XS_DEFINE_VERSION from constants() to
880 init_VERSION().
881 Eliminated MODULES. Unused and its the same as TO_INST_PM
882 Moved .INCLUDE from constants() to special_targets()
883
884 - MM_NW5 constants() & init_others() disolves
885 Moved LIBPTH, BASE_IMPORT, NLM_VERSION, MPKTOOL, TOOLPATH from
886 init_others() to init_platform()
887 Moved INCLUDE and PATH definitions from constants() to
888 init_platform()
889 Moved BOOT_SYMBOL, NLM_SHORT_NAME, PATH and INCLUDE from
890 constants() to init_platform()
891
892 - MM_Unix constants() goes on a diet
893 Moved all macro definitions to init_* methods.
894 Added MM_REVISION for completeness
895 Using wraplist() instead of manual joining
896 Moved .NO_CONFIG_REC, .SUFFIXES and .PHONY to special_targets()
897 Moved makemakerdflt: to makemakerdeflt_target()
898 Moved INST_{STATIC,DYNAMIC,BOOT} to init_INST()
899 Moved EXPORT_LIST, PERL_ARCHIVE & PERL_ARCHIVE_AFTER to init_linker().
900 Moved PERL_MALLOC_DEF to init_platform()
901
902 - MM_VMS constants() goes on a diet
903 Moved DEFINE from constants() to init_main()
904 Moved OBJECT & LDFROM from constants() to init_others()
905 Moved MM_VMS_REVISION and PERL_VMS to init_platform
906 Added MM_VMS_VERSION
907 Moved DEFINE_VERSION, XS_DEFINE_VERSION and MAKEMAKER changes to
908 init_VERSION
909 Moved .SUFFIXES changes to special_targets() override.
910 Eliminated $self->{PM_TO_BLIB}. Its redundant with $self->{PM}.
911 constants() now consists only of fixpath() calls.
912
913 - MM_Win32 constants() goes away
914 Moved .USESHELL to special_targets() override.
915 Everything else was redundant.
916
917 - Added $(VERSION_FROM) to $(MAKEFILE) dependencies. Helpful for
918 XS builds where the version number is very sensitive.
919 - export_list(), perl_archive() and perl_archive_after() consolodated
920 into init_linker().
921 - Added MM_NW5_VERSION, MM_Unix_VERSION, MM_Win32_VERSION,
922 MM_VMS_VERSION.
923 - Eliminated duplicate code in constants() overrides
924 - Added all_target() for easier customization of what's run by default
925 - Eliminated duplicate top_targets() overrides
926 - Made tool_autosplit() method portable. Moved to MM_Any. Eliminated
927 overrides.
928 - Adding realclean_subdirs target and realclean_subdirs_target()
929 method to generate same. This allows easier overriding of an
930 unportable part of the realclean target.
931 - Added oneliner() to create portable perl one-liners.
932 - Craig Berry found some typos in ExtUtils::Liblist::Kid's VMS part
933 * ExtUtils::Install did not work on MacPerl due to a hardcoded '.'
934 * prompt() will now read from STDIN.
935 - Craig Berry made sure extliblist() is always called even if LIBS
936 is explicitly set to empty.
937 * Added DESTDIR to make repacking easier.
938 * $(*PREFIX) are returned to the INSTALL* variables.
939 * Split $(PREFIX) into $(PERLPREFIX) and $(PREFIX). The former
940 holds the location of the core libraries. The latter is the
941 optional override prefix supplied by the user.
942 * PREFIX overrides all other *PREFIXes when set in the Makefile.PL.
943 This restores "make install PREFIX=foo".
944 - Added quote_literal() to handle some shell quoting.
945 - ExtUtils::MM_VMS now compilable on non-VMS platforms.
946 - J. D. Laub made MakeMaker honor $Config{installstyle}
947 - Renaming on OS/2 requires the target file to be removed.
948 Partially fixed by Ilya, should be applied universally later.
949 - Default MANIFEST.SKIP not catching files in subdirs. Fixed by Ilya.
950 - Ilya fixed ExtUtils::Liblist->ext when called outside MakeMaker.
951 - realclean was duplicating work already done by clean
952 - Adding an explicit LICENSE
953 - Cleaning up ExtUtils::Install docs.
954 - ExtUtils::Install::uninstall() now has default verbose and
955 dont_execute arguments.
956 - Added some basic ExtUtils::Install tests
957 - Fixed ExtUtils::Install::install() for relative dirs
958 - Added split_command() and max_exec_len() to deal with long
959 commands.
960 - Seperated escape_newlines() from quote_literal(). This may
961 be pointless.
962 - pm_to_blib() now generated with split_command(). 3x speedup.
963 - added init_dist() to initialize distribution constants
964 - ExtUtils::Install::pm_to_blib() working around open filehandle
965 bug in AutoSplit for systems with mandatory file locking.
966
9676.05 Tue Aug 27 16:09:51 PDT 2002
968 - Output format of the hint file verbose diagnostic is now in
969 a format native to the OS, so it broke a test on non-Unixen.
970
9716.04 Mon Aug 26 18:31:11 PDT 2002
972 - Little fix for pre-5.8 Cygwin test to get the shared library names
973 right.
974 * disttest on Win9X broken because of forgotten tabs
975 * WriteMakefile argument verification should now be accurate
976 - Documented the LD flag.
977 * Documented prompt()
978 * vendor install was not adding to packlist or updating perllocal.
979 - Supporting $Config{vendorarchexp} and $Config{vendorlibexp}.
980 - Fixed conflict on VMS between logical names and directories
981 (bleadperl 17488)
982 - Fixed space-vs-tab bug on Netware (bleadperl 17579)
983 - Mysterious NetWare fix from Ananth (bleadperl 17376)
984 - Support OPTIMIZE in MacOS (bleadperl 17347)
985 - Support hints in MacOS (mutation of bleadperl 17347)
986 * Default man installation directories were using $(MAN*EXT) to
987 generate the directory name. This turned out to be wrong more
988 often than right, so we'll use man1 and man3 hard-coded.
989 - Debian folks fixed the doc_install targets so the Appending
990 diagnostic gives the correct directory for perllocal.pod
991 * Added ExtUtils::MakeMaker::FAQ
992 - Quieted some warnings on MacOS (bleadperl 17669)
993
a884ca7c
MS
9946.03 Wed Jun 19 17:06:14 EDT 2002
995 - Documented that we're clamping down on cargo-cult MakeMaker
996 programming.
997 - Eased up the parameter verification to leave errant values alone.
998 - Doug MacEachern documented LDDLFLAGS and added to known parameters.
999 - Possible fix for XS compiles on Cygwin for pre 5.8 perls.
1000
d5d4ec93
MS
10016.02 Sat Jun 15 19:46:06 EDT 2002
1002 - ExtUtils::Installed->modules() was broken in scalar context
1003 - Sync bleadperl 16922: Netware updates from Ananth Kesari.
1004 - Sync bleadperl 16922: MM_NW5 tests
1005 - Sync bleadperl 16938 & 16974: MM_MacOS->macify fixes from pudge.
1006 - Sync bleadperl 16989 & 16942: Small test fixes for MacPerl from pudge.
1007 - Improved WriteMakefile param verification to differenciate between
1008 parameters which don't exist and those that just take strings/numbers.
1009 [RT #707]
1010 * Documented TEST_VERBOSE
1011
69ff8adf
JH
10126.01 Thu May 30 14:48:57 EDT 2002
1013 - MacOS Classic fixes from Pudge: recursive make repair,
1014 post_initialize() now used, DEFINE & INC work with relative paths,
1015 removed dead hybrid method/function call code.
1016 * WriteMakefile now a bit more tolerant of wrong arguments, it will
1017 warn and try to soldier on rather than just vomiting.
1018 - Netware whitespace nits (bleadperl@16811)
1019 - Netware Perl version number tag when building dynamic libraries
1020 needs to match the current perl version instead of being hard coded
1021 (a mutation of bleadperl@16851)
1022 - OS/2 bug in TEST_F target found by John Poltorak (bleadperl@16839)
1023 - README in 6.00 still declared this as alpha.
1024
10256.00 Sat May 25 17:14:09 EDT 2002
1026 - VMS 8-level limit test tweak (bleadperl@16764)
1027 * Here goes nothing.
1028
a67d7a01
MS
10295.96_01 Wed May 22 19:11:09 EDT 2002
1030 - Fixed ExtUtils::testlib so it doesn't taint @INC.
1031 - Fixed ExtUtils::Command so it groks % shell wildcard on VMS.
1032 [RT 625]
1033 - MM now depends on Test::Harness 2.00 on VMS else tests with -T
1034 won't work, command line too long.
1035 - Added Craig's patch to fix limited level VMSs in the core.
1036
9ce33444
MS
10375.95_01 Sat May 18 14:40:12 EDT 2002
1038 - Fixed ExtUtils::testlib so it has a reasonable chance of working
1039 under taint mode.
1040
57b1a898
MS
10415.94_02 Fri May 17 17:16:04 EDT 2002
1042 - Fixing Manifest.t test for relative @INC when core testing.
1043
10445.94_01 Fri May 17 14:53:54 EDT 2002
1045 - Small NetWare change from Novell.
1046 - worked around 5.005_03's lack of a $Config{siteprefix} and
1047 $Config{sitebin}.
1048 - Small cross compilation changes (bleadperl 16582, 16548)
1049
1050 [[ Test Fixes ]]
1051 - Fixing ExtUtils::Command tests for VMS shell wildcard differences.
1052 - Fixing ExtUtils::Installed tests so they don't go looking at already
1053 installed installed lists.
1054
10555.93_01 Mon May 6 00:54:39 EDT 2002
1056 - fixed basic.t for limited depth VMS systems
1057 * MM_BeOS was totally hosed by a typo.
1058 - Made the ExtUtils::Command docs clear about how things come
1059 from @ARGV not @_.
1060 - Quieted nmake banners in disttest
1061
1062 * Backporting to 5.005_03
1063 - 'require 5.006' statements to 5.00503
1064 - Removing uses of File::Spec::Functions
1065 - Adding MODE arg to mkdir()
1066 - Changing uses of 'our' to 'use vars'
1067 - Changing uses of 'no warnings' to 'local $SIG{__WARN__}'
1068 - Changing 3-arg opens to 2-arg
1069 - Changing 'open my $fh' to 'open FH'
1070 - 5.005_03's File::Find doesn't have 'no_chdir'
1071
f582e489
MS
10725.92_01 Mon Apr 29 23:09:38 EDT 2002
1073 - Fixing case of modules with no .pm files on VMS.
1074 - LDLOADLIBS fix for NetBSD and easier overriding (bleadperl 16233)
1075 * syncing in MM_MacOS from pudge.
1076 - syncing in NetWare fixes (16266 & 16190)
1077 - Cleaning up MM_NW5.pm somewhat.
1078
45bc4d3a
JH
10795.91_02 Wed Apr 24 01:29:56 EDT 2002
1080 - Adjustments to tests for inclusion in the core.
1081
10825.91_01 Wed Apr 24 00:11:06 EDT 2002
1083 [[ API Changes ]]
1084 * A failing Makefile.PL in a subdir will now kill the whole
1085 makefile making process.
1086 * "make install PREFIX=something" will no longer work. Sorry.
1087 - Now supporting the usevendorprefix %Config setting
1088 - Tests now guaranteed to run in alphabetical order.
1089 - Allowing $VERSION = 0.
1090
1091 [[ Bug Fixes ]]
1092 - Missing prerequisite warning malformatted.
1093 - INSTALL*MAN*DIR and INST_MAN*DIR weren't allowed on the command
1094 line.
1095 * For years now skipcheck() has been returning a different
1096 value than what was documented.
1097 - Partially reversing Ken's "speed up ExtUtils::Manifest" patch
1098 from 5.51_01 so MANIFEST overrides MANIFEST.SKIP.
1099 * Fixed PREFIXification so it works on Win32.
1100 * Fixed PREFIXification so it works on VMS.
1101 - Fixed INSTALLMAN*DIR=none on VMS.
1102 * NetWare fixes (bleadperl@16076)
1103 - Craig Berry fixed some macro corruption on VMS.
1104 - Systems configured to not have man pages now honored thanks to
1105 Paul Green
1106 - Hack to allow 5.6.X versions of ExtUtils::Embed use MY implicitly.
1107 - Moved use of glob out of MM_Unix so MacPerl could build
1108
1109 [[ Test Changes ]]
1110 - Shortening directory levels to accomodate old VMS's
1111 - was using a slightly wrong prefix for the prefix tests
1112
1113 [[ Doc Fixes ]]
1114 - Documenting VERBINST
1115
5c161494
MS
11165.90_01 Thu Apr 11 01:11:54 EDT 2002
1117 [[ API Changes ]]
1118 * Implementation of the new PREFIX logic.
1119 * Added new INSTALL targets:
1120 INSTALLSITEBIN
1121 INSTALLSITEMAN1DIR INSTALLSITEMAN3DIR
1122 INSTALLVENDORMAN1DIR INSTALLVENDORMAN3DIR
1123 INSTALLVENDORBIN INSTALLVENDORLIB INSTALLVENDORARCH
1124 SITEPREFIX VENDORPREFIX
1125 * INSTALLDIRS=site now properly using $Config{siteprefixexp}
1126 (Thieved from Debian. Thanks!)
1127 * Added INSTALLDIRS=vendor & support for vendor directories
1128 (Thieved from Debian. Thanks!)
1129
1130 [[ Bug Fixes ]]
1131 - nmake syntax nits from Mattia Barbon
1132 - ExtUtils::Packlist fix for files with spaces in them from Jan Dubois
1133 (bleadperl@15800)
1134 - Old, old, old dmake bug in MM_Win32->pm_to_blib fixed by Nick
1135 (bleadperl 15847)
1136
1137 [[ Internals ]]
1138 - Purging leftover PDP compiler flags.
1139
11405.55_03 Sat Apr 6 21:57:01 EST 2002
1141 - Reversing "fix" for RT 444. It wasn't really fixed and it
1142 caused havoc with Compress::Zlib and Tk.
1143
e0678a30
MS
11445.55_02 Sat Apr 6 03:09:15 EST 2002
1145 [[ Bug Fixes ]]
1146 - Craig Berry fixed install on VMS (again, I munged the last patch)
1147 - MakeMaker might not be recognizing it's in PERL_SRC on Win32.
1148 Made safer.
1149 - For some reason MM_VMS was using $Config{arch} instead of
1150 $Config{archname}
1151 - Fix (well, hack) for creating ABSPERL on VMS.
5c161494
MS
1152 - Quieting some warnings revealed by ExtUtils::Constant
1153 - test_via_script had a typo and forgot INST_ARCHLIB
e0678a30
MS
1154
1155 [[ Test Fixes ]]
1156 - INST.t has to tell MakeMaker it's in the PERL_CORE
5c161494 1157 - Fixing expected values of INST_* when building the core.
e0678a30
MS
1158
11595.55_01 Thu Apr 4 23:58:06 EST 2002
1160 [[ API Changes ]]
1161 * Long deprecated INST_EXE completely removed.
1162 - Removing TEST_LIBS constant (never seen in a stable MM anyway)
1163 - Added $default argument to prefixify() for safer prefixification.
1164
1165 [[ Bug Fixes ]]
1166 - $mm->{PERM_*} were not being set
1167 - fixin() redundantly chmod'ing scripts. Let the Makefile do that.
1168 - The above means MM_Unix will now compile cleanly under strict
1169 * init_dirscan's search for Makefile.PL's will no longer look
1170 inside a distdir.
1171 * Fixed running tests when there are t/'s in subdirs.
1172 - MM_DOS inheriting from MM_Unix instead of MM_Win32. DJGPP
1173 appears to be unix-like (bleadperl@15650)
1174 - Escaping constants with # in them so they're not confused as
1175 make comments (bleadperl)
1176 * ExtUtils::MM_Win95 didn't return a true value
1177 - Fixing disttest when perl is a relative path.
1178 * Fixed disttest & tests in subdirs on Win95
1179 - Fixed recursive Makefile.PL scan on VMS so it skips the distdir
1180 - Fixed a bug when an alternative MAKEFILE is specified and you're
1181 using something other than a Makefile.PL (RT 444)
1182 - Quieting uninit warning when there are no tests.
1183
1184 [[ Doc Fixes ]]
1185 - Documented INSTALLMAN*DIR == 'none' feature.
1186
1187 [[ Test Fixes ]]
1188 - Paul Green's which_perl patch to build a proper Perl on systems
1189 that use command extensions.
1190 - basic.t's Makefile.PL PREFIX call wasn't properly quoted for VMS
1191 (Craig Berry)
1192 - little initialization glitch in MM_Win32.t
1193
1194 [[ Internals ]]
1195 - INST_* constants moved to init_INST
1196 - INSTALL* constants moved to inst_INSTALL
1197 * Internal warning supression removed.
1198 - Temporarily turning off SelfLoader in MM_Unix so warnings
1199 have the right line numbers.
1200
75e2e551
MS
12015.54_01 Sat Mar 30 02:32:44 EST 2002
1202 [[ New Features ]]
1203 * Added FULLPERLRUN and FULLPERLRUNINST
1204
1205 [[ Bug Fixes ]]
1206 - hint files were made a little too noisy in 5.53_01
1207
1208 [[ Test Fixes ]]
e0678a30 1209 - adjusting for NFS time drift
75e2e551
MS
1210 - basic.t was finding the wrong perl in the core
1211
e0678a30
MS
1212 [[ Internals ]]
1213 - FULLPERL* PERL* setup moved to init_PERL
1214
75e2e551
MS
12155.53_02 Fri Mar 29 04:47:44 EST 2002
1216 - Adjusted for Perl core. Synced into bleadperl.
1217
f6d6199c
MS
12185.53_01 Fri Mar 29 00:13:02 EST 2002
1219 [[ Bug Fixes ]]
1220 - Removed duplicate NAME macro definition
1221 - Fixed makemakerdflt target for VMS
1222 * bleadperl@11460 introduced a bug with recursive Makefile.PL's not
1223 having '.' in @INC. PDL should build now.
1224 * MANIFEST.SKIP only working on file names, not full relative paths.
1225 Only since 5.51_01 (RT 413)
1226 * make test TEST_VERBOSE=1 was busted by 5.50_01 (RT 423)
1227 * Error messages from dying Makefile.PL's and hint files were
1228 accidentally supressed in 5.48_04. Fixed.
1229 * Makefile.PL's are supposed to be run in package main. 5.48_04
1230 broke this. Fixed.
1231 * Fixing installing on VMS.
1232
12335.52_01 Tue Mar 26 00:24:26 EST 2002
1234 [[ Bug Fixes ]]
1235 * ActivePerl 5.6.1/build 631 now 100%
1236 - Fixed some SelfLoader warnings
1237 * ExtUtils::MM_Win32 not subclassed off of ExtUtils::MM_Any properly
1238 - Bug in local $ENV{FOO} was causing failures in MM_Win32 tests.
1239 Compensating for the bug.
1240 - $Config{prefixexp} is sometimes bad on ActivePerl, compensating
1241 - Accidentally left htmlifypods tests in MM_Win32 tests
1242
1243 [[ Doc Changes ]]
1244 - Expanding Known Good list
1245 - Adding Known Programs to README
1246
12475.51_01 Mon Mar 18 01:37:02 EST 2002
1248 [[ API Changes ]]
1249 - Removing xsubpp and typemap from the distribution. These are not
1250 Perl version independent files and should not be upgraded.
1251 - Removing ExtUtils::Embed. Version specific module and should
1252 not be updated.
1253 - Removing ExtUtils::Constant. Not directly tied to MakeMaker.
1254 Will be distributed seperately by Nick Clark.
1255
1256 [[ New Features ]]
1257 * realclean now deletes 'dist' directory.
1258
1259 [[ Bug Fixes ]]
1260 * Fixing ExtUtils::Installed for VMS
1261 * Fixed it so MakeMaker can build itself without needing an eariler
1262 version installed
1263 * Fixed ExtUtils::Installed so packlists work on VMS
1264 * ExtUtils::MM_VMS test had a stupid typo that prevented most
1265 of the tests from running.
1266 - Fixing VMS so 'mmk' is always 'mmk all' (bleadperl 15218)
1267 - ExtUtils::MM_Any->catfile was calling catdir
1268 - Added Ken William's "speed up ExtUtils::Manifest" patch.
1269 - Added Nick Clark's return value of manifest routines patch
1270 (bleadperl@14978)
1271 - Merging in bleadperl changes (14438, 14453, 14611, 14612, 14622,
1272 14655, 14677, 14688, 14902, 15023, 15187, 15367)
1273 - bleadperl change 15325 (VMS 'mmk all' hack) rejected.
1274 - ExtUtils::MM_Any->test_via_harness() now using -MExtUtils::testlib
1275 instead of -I's. This keeps the command line shorter on VMS, but
1276 it means TEST_LIB doesn't work anymore. May prove problematic.
1277 - PERLRUN now uses FULLPERL instead of PERL. This avoids
1278 accidental use of miniperl. May cause problems in the core.
1279 - Fixed test_via_harness() on VMS so it uses PERLRUN.
1280 - ExtUtils::Manifest wrongly handling MANIFEST on VMS.
1281 - ExtUtils::Manifest::maniskip broken due to misuse of /o on a regex.
1282
12835.50_01 Mon Mar 4 23:44:48 EST 2002
1284 [[ API Changes ]]
479d2113 1285 - htmlifypods and all HTML targets have been removed. It didn't
f6d6199c
MS
1286 work properly. A target for HTMLifying of docs will be
1287 added sometime in the future (read: send a patch).
1288 - Deprecated ROOTEXT variable removed (its been deprecated for
1289 more than five years).
1290 - Removed ExtUtils::Miniperl from the CPAN distribution. Can't
1291 see how its useful outside the core.
1292
1293 [[ New Features ]]
1294 * Emacs backup files (ie. *~) are no longer copied into blib
1295 (this means you won't get Foo.pm~ accidentally installed anymore).
1296 - prefixify() now returns if the prefixification worked or not.
1297 - added the Perl patchlevel info to the description embedded in DLLs
1298 (Ilya Zakharevich perl change 14810)
1299
1300 [[ Bug Fixes ]]
1301 * 5.49_01 broke anything that depended on the MM class to be loaded
1302 with ExtUtils::MakeMaker, like CPAN. Temporarily fixed.
1303 * Many places wrongfully assume MM methods can be called as class
1304 methods! Inside and outside of MakeMaker.
1305 * DOS now acts like Win32 instead of Unix. This should be less wrong.
1306 - Netware tweak from Ananth Kesari (perl change 14780)
1307
1308 [[ Doc Changes ]]
1309 * made the docs about the behavior of PREFIX a bit more vague
1310 reflecting its odd behavior.
1311 - Replaced references to %Config with things people are more likely
1312 to understand in PREFIX & LIB docs.
1313 - Put PREFIX before LIB in the docs.
1314
1315 [[ Internal Refactorings ]]
1316 - File::Spec wrappers consolidated in MM_Any
1317 - test_via_harness/script consolidated in MM_Any
1318 * Added ExtUtils::Command::MM to replace large -e "one-liners"
1319 * Added ExtUtils::MM_UWIN, took UWIN specific code out of MM_Unix.
1320 * Added ExtUtils::MM_DOS, took some DOS specific code out of MM_Unix
1321 - Added a dist() override to MM_OS2.
1322 - Took the OS/2 specific code out of MM_Unix's dist()
1323 - Starting to quote as many command line switches as possible
1324 to make VMS have to override less of MM_Unix.
1325
13265.49_01 Mon Feb 4 00:42:40 EST 2002
1327 - Default TEST_LIBS now contains absolute paths, so tests can
1328 chdir without breaking @INC.
1329 - Some bug fixes in MM_Win32 were missing in MM_NW5.
1330 - LLIBPERL was not being set.
1331 - Gisle Aas fixed a warning in prompt when the user hits ctrl-D
1332 or pipes STDIN to /dev/null.
1333 - VMS's test is now a proper ->can check.
1334 - Stray newline in Command.t causing havoc (bleadperl 14441)
1335
1336 * Lots of internal changes. Everything from here on is an internal
1337 change.
1338 - Broke ExtUtils::Liblist::Kid out into its own .pm. Temporary.
1339 - Broke MM and MY out into their own .pm's. Possibly temporary.
1340 - Broke ExtUtils::MM_Win95 out of ExtUtils::MM_Win32. MM_Win95
1341 is now an MM_Win32 subclass.
1342 - Removed wrapper methods from ExtUtils::Liblist that were
1343 defering File::Spec loading. Almost everything uses File::Spec
1344 - Changed most of the 'our's to 'use vars' in prep for 5.005_03
1345 backporting
1346 - Changed ExtUtils::MakeMaker->import(...) cargo-cultery in MM_*
1347 modules to proper "use ExtUtils::MakeMaker qw(...)"
1348 - All non-Unix MM_* modules now directly inherit from MM_Unix.
1349 They did this before, but in a round-about way.
1350 - MM_* modules no longer directly muck with @MM::ISA. Instead
1351 @MM::ISA does that itself.
1352 - Removed unnecessary require of Exporter in many MM_* modules.
1353 - MM_Cygwin was using an MM_Unix function directly without have
1354 explicitly required MM_Unix.
1355 - Most of MM_NW5 was redundant with MM_Win32. So MM_NW5 is now
1356 a subclass of Win32 and the reduendant code has been deleted.
1357 - Replaced lots of calls to File::Spec->updir, curdir and rootdir
1358 with a global in MM_Unix. Should make things a bit faster.
1359 - Untabified ExtUtils::MakeMaker. I hate tabs.
1360 - "Which MM subclass should I use" logic moved from EU::MakeMaker
1361 to EU::MM.
1362 - Deprecated EU::MakeMaker::Version_check deleted.
1363
13645.48_04 Mon Jan 21 19:28:38 EST 2002
1365 - No longer requiring Test::More
1366 - Now tested to work with a clean 5.6.1
5c161494 1367 - Stripped out $Revision based $VERSIONs.
f6d6199c
MS
1368 - Rolled in patches from p5p, vmsperl & VOS (14325, 14338, 14360, 14364)
1369 * hint files now run in a safer context. Only $self is available.
1370 - ExtUtils::testlib now provides absolute paths into @INC.
1371 No longer obsolete
1372 - Little test fixes
1373
39234879
MS
13745.48_03 Thu Jan 17 23:44:38 EST 2002
1375 * moved bin/inst to bin/instmodsh
1376 * Some Win32 backporting fixes. The -x switch doesn't seem to
1377 work on Win32/5.6.1.
1378 * Bug on Win32. MAKEMAKER variable not set properly.
1379 * _02 broke hints files. Now fixed.
1380 - Minor prereq error formatting glitch
1381 - ExtUtils::testlib no longer a thin wrapper around blib, now a
1382 thin wrapper around lib like it was. blib is noisy on 5.6.1.
1383 - Nick and chromatic found and fixed some warnings in the tests
1384
13855.48_02 Wed Jan 16 19:11:26 EST 2002
1386 - Fixed some Win32 warnings. Needs more work.
1387
e0678a30 13885.48_01 Wed Jan 16 15:10:28 EST 2002
39234879
MS
1389 * Adapted from bleadperl@14303
1390 * Backported to 5.6.1
1391 - inst and xsubpp moved out of lib/ and into bin/
1392 - ExtUtils::testlib obsoleted. Now a thin wrapper around blib.pm
1393 ***--> Non-Unix platforms not tested at all! Please test and report
1394 back. Tests probably only need minor fixes.
1395