This is a live mirror of the Perl 5 development currently hosted at https://github.com/perl/perl5
perlhack.pod: invoke git-format-patch with --attach
[perl5.git] / pod / perlhack.pod
CommitLineData
04c692a8 1=encoding utf8
35c336e6 2
04c692a8
DR
3=for comment
4Consistent formatting of this file is achieved with:
5 perl ./Porting/podtidy pod/perlhack.pod
35c336e6 6
04c692a8 7=head1 NAME
35c336e6 8
04c692a8 9perlhack - How to hack on Perl
35c336e6 10
04c692a8 11=head1 DESCRIPTION
35c336e6 12
04c692a8
DR
13This document explains how Perl development works. It includes details
14about the Perl 5 Porters email list, the Perl repository, the Perlbug
15bug tracker, patch guidelines, and commentary on Perl development
16philosophy.
f7e1e956 17
04c692a8 18=head1 SUPER QUICK PATCH GUIDE
f7e1e956 19
04c692a8
DR
20If you just want to submit a single small patch like a pod fix, a test
21for a bug, comment fixes, etc., it's easy! Here's how:
f7e1e956 22
04c692a8 23=over 4
e018f8be 24
04c692a8 25=item * Check out the source repository
e018f8be 26
04c692a8
DR
27The perl source is in a git repository. You can clone the repository
28with the following command:
e018f8be 29
04c692a8 30 % git clone git://perl5.git.perl.org/perl.git perl
e018f8be 31
04c692a8 32=item * Make your change
e018f8be 33
04c692a8 34Hack, hack, hack.
7205a85d 35
04c692a8 36=item * Test your change
e018f8be 37
04c692a8 38You can run all the tests with the following commands:
b26492ee 39
04c692a8
DR
40 % ./Configure -des -Dusedevel
41 % make test
7205a85d 42
04c692a8 43Keep hacking until the tests pass.
b26492ee 44
04c692a8 45=item * Commit your change
e018f8be 46
b6538e4f 47Committing your work will save the change I<on your local system>:
7205a85d 48
04c692a8 49 % git commit -a -m 'Commit message goes here'
e018f8be 50
04c692a8
DR
51Make sure the commit message describes your change in a single
52sentence. For example, "Fixed spelling errors in perlhack.pod".
e018f8be 53
04c692a8 54=item * Send your change to perlbug
7a834142 55
04c692a8
DR
56The next step is to submit your patch to the Perl core ticket system
57via email.
7a834142 58
5c70016e
JC
59Assuming your patch consists of a single git commit, the following
60writes the file as a MIME attachment, and sends it with a meaningful
61subject:
e018f8be 62
5c70016e 63 % git format-patch -1 --attach
d23ed4f3 64 % perlbug -s "[PATCH] $(git log -1 --oneline HEAD)" -f 0001-*.patch
e018f8be 65
04c692a8
DR
66The perlbug program will ask you a few questions about your email
67address and the patch you're submitting. Once you've answered them you
68can submit your patch.
e018f8be 69
04c692a8 70=item * Thank you
e018f8be 71
04c692a8
DR
72The porters appreciate the time you spent helping to make Perl better.
73Thank you!
e018f8be 74
cce04beb 75=back
e018f8be 76
04c692a8 77=head1 BUG REPORTING
cc0710ff 78
a8d15a22 79If you want to report a bug in Perl, you must use the F<perlbug> command
04c692a8
DR
80line tool. This tool will ensure that your bug report includes all the
81relevant system and configuration information.
7205a85d 82
04c692a8 83To browse existing Perl bugs and patches, you can use the web interface
a8d15a22 84at L<http://rt.perl.org/>.
244d9cb7 85
04c692a8
DR
86Please check the archive of the perl5-porters list (see below) and/or
87the bug tracking system before submitting a bug report. Often, you'll
88find that the bug has been reported already.
244d9cb7 89
04c692a8
DR
90You can log in to the bug tracking system and comment on existing bug
91reports. If you have additional information regarding an existing bug,
92please add it. This will help the porters fix the bug.
7205a85d 93
04c692a8 94=head1 PERL 5 PORTERS
7205a85d 95
04c692a8
DR
96The perl5-porters (p5p) mailing list is where the Perl standard
97distribution is maintained and developed. The people who maintain Perl
98are also referred to as the "Perl 5 Porters", or just the "porters".
a75f557c 99
04c692a8
DR
100A searchable archive of the list is available at
101L<http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/>. There is
102also another archive at
103L<http://archive.develooper.com/perl5-porters@perl.org/>.
7205a85d 104
04c692a8 105=head2 perl-changes mailing list
7205a85d 106
04c692a8
DR
107The perl5-changes mailing list receives a copy of each patch that gets
108submitted to the maintenance and development branches of the perl
109repository. See L<http://lists.perl.org/list/perl5-changes.html> for
110subscription and archive information.
244d9cb7 111
04c692a8 112=head1 GETTING THE PERL SOURCE
244d9cb7 113
04c692a8
DR
114All of Perl's source code is kept centrally in a Git repository at
115I<perl5.git.perl.org>. The repository contains many Perl revisions from
116Perl 1 onwards and all the revisions from Perforce, the previous
117version control system.
244d9cb7 118
04c692a8
DR
119For much more detail on using git with the Perl repository, please see
120L<perlgit>.
244d9cb7 121
04c692a8 122=head2 Read access via Git
244d9cb7 123
04c692a8
DR
124You will need a copy of Git for your computer. You can fetch a copy of
125the repository using the git protocol:
244d9cb7 126
04c692a8 127 % git clone git://perl5.git.perl.org/perl.git perl
244d9cb7 128
04c692a8
DR
129This clones the repository and makes a local copy in the F<perl>
130directory.
7205a85d 131
04c692a8
DR
132If you cannot use the git protocol for firewall reasons, you can also
133clone via http, though this is much slower:
7205a85d 134
04c692a8 135 % git clone http://perl5.git.perl.org/perl.git perl
7205a85d 136
04c692a8 137=head2 Read access via the web
7205a85d 138
04c692a8
DR
139You may access the repository over the web. This allows you to browse
140the tree, see recent commits, subscribe to RSS feeds for the changes,
141search for particular commits and more. You may access it at
142L<http://perl5.git.perl.org/perl.git>. A mirror of the repository is
a8d15a22 143found at L<http://github.com/mirrors/perl>.
7205a85d 144
04c692a8 145=head2 Read access via rsync
7205a85d 146
04c692a8
DR
147You can also choose to use rsync to get a copy of the current source
148tree for the bleadperl branch and all maintenance branches:
7205a85d 149
efdea7e2
R
150 % rsync -avz rsync://perl5.git.perl.org/perl-current .
151 % rsync -avz rsync://perl5.git.perl.org/perl-5.12.x .
152 % rsync -avz rsync://perl5.git.perl.org/perl-5.10.x .
153 % rsync -avz rsync://perl5.git.perl.org/perl-5.8.x .
154 % rsync -avz rsync://perl5.git.perl.org/perl-5.6.x .
155 % rsync -avz rsync://perl5.git.perl.org/perl-5.005xx .
7205a85d 156
a8d15a22 157(Add the C<--delete> option to remove leftover files.)
7205a85d 158
04c692a8 159To get a full list of the available sync points:
7205a85d 160
efdea7e2 161 % rsync perl5.git.perl.org::
7205a85d 162
04c692a8 163=head2 Write access via git
7205a85d 164
04c692a8
DR
165If you have a commit bit, please see L<perlgit> for more details on
166using git.
7205a85d 167
04c692a8 168=head1 PATCHING PERL
7205a85d 169
04c692a8
DR
170If you're planning to do more extensive work than a single small fix,
171we encourage you to read the documentation below. This will help you
172focus your work and make your patches easier to incorporate into the
173Perl source.
244d9cb7 174
04c692a8 175=head2 Submitting patches
244d9cb7 176
04c692a8
DR
177If you have a small patch to submit, please submit it via perlbug. You
178can also send email directly to perlbug@perl.org. Please note that
179messages sent to perlbug may be held in a moderation queue, so you
180won't receive a response immediately.
244d9cb7 181
04c692a8
DR
182You'll know your submission has been processed when you receive an
183email from our ticket tracking system. This email will give you a
184ticket number. Once your patch has made it to the ticket tracking
185system, it will also be sent to the perl5-porters@perl.org list.
244d9cb7 186
04c692a8
DR
187Patches are reviewed and discussed on the p5p list. Simple,
188uncontroversial patches will usually be applied without any discussion.
189When the patch is applied, the ticket will be updated and you will
190receive email. In addition, an email will be sent to the p5p list.
244d9cb7 191
04c692a8
DR
192In other cases, the patch will need more work or discussion. That will
193happen on the p5p list.
244d9cb7 194
04c692a8
DR
195You are encouraged to participate in the discussion and advocate for
196your patch. Sometimes your patch may get lost in the shuffle. It's
197appropriate to send a reminder email to p5p if no action has been taken
198in a month. Please remember that the Perl 5 developers are all
199volunteers, and be polite.
244d9cb7 200
04c692a8
DR
201Changes are always applied directly to the main development branch,
202called "blead". Some patches may be backported to a maintenance branch.
203If you think your patch is appropriate for the maintenance branch,
204please explain why when you submit it.
244d9cb7 205
04c692a8 206=head2 Getting your patch accepted
244d9cb7 207
04c692a8
DR
208If you are submitting a code patch there are several things that you
209can do to help the Perl 5 Porters accept your patch.
244d9cb7 210
a126fb62
DR
211=head3 Patch style
212
213If you used git to check out the Perl source, then using C<git
214format-patch> will produce a patch in a style suitable for Perl. The
215C<format-patch> command produces one patch file for each commit you
216made. If you prefer to send a single patch for all commits, you can use
217C<git diff>.
218
219 % git co blead
220 % git pull
221 % git diff blead my-branch-name
222
223This produces a patch based on the difference between blead and your
224current branch. It's important to make sure that blead is up to date
225before producing the diff, that's why we call C<git pull> first.
226
227We strongly recommend that you use git if possible. It will make your
228life easier, and ours as well.
229
230However, if you're not using git, you can still produce a suitable
231patch. You'll need a pristine copy of the Perl source to diff against.
232The porters prefer unified diffs. Using GNU C<diff>, you can produce a
233diff like this:
234
235 % diff -Npurd perl.pristine perl.mine
236
237Make sure that you C<make realclean> in your copy of Perl to remove any
238build artifacts, or you may get a confusing result.
239
04c692a8 240=head3 Commit message
244d9cb7 241
04c692a8
DR
242As you craft each patch you intend to submit to the Perl core, it's
243important to write a good commit message. This is especially important
244if your submission will consist of a series of commits.
244d9cb7 245
04c692a8
DR
246The first line of the commit message should be a short description
247without a period. It should be no longer than the subject line of an
a8d15a22 248email, 50 characters being a good rule of thumb.
f7e1e956 249
a8d15a22 250A lot of Git tools (Gitweb, GitHub, git log --pretty=oneline, ...) will
04c692a8
DR
251only display the first line (cut off at 50 characters) when presenting
252commit summaries.
7cd58830 253
04c692a8
DR
254The commit message should include a description of the problem that the
255patch corrects or new functionality that the patch adds.
7cd58830 256
04c692a8
DR
257As a general rule of thumb, your commit message should help a
258programmer who knows the Perl core quickly understand what you were
259trying to do, how you were trying to do it, and why the change matters
260to Perl.
7cd58830 261
04c692a8 262=over 4
7cd58830 263
04c692a8 264=item * Why
7cd58830 265
04c692a8
DR
266Your commit message should describe why the change you are making is
267important. When someone looks at your change in six months or six
268years, your intent should be clear.
7cd58830 269
04c692a8
DR
270If you're deprecating a feature with the intent of later simplifying
271another bit of code, say so. If you're fixing a performance problem or
272adding a new feature to support some other bit of the core, mention
273that.
7cd58830 274
04c692a8 275=item * What
7cd58830 276
04c692a8
DR
277Your commit message should describe what part of the Perl core you're
278changing and what you expect your patch to do.
7cd58830 279
04c692a8 280=item * How
7cd58830 281
04c692a8
DR
282While it's not necessary for documentation changes, new tests or
283trivial patches, it's often worth explaining how your change works.
284Even if it's clear to you today, it may not be clear to a porter next
285month or next year.
d7889f52 286
04c692a8 287=back
d7889f52 288
04c692a8
DR
289A commit message isn't intended to take the place of comments in your
290code. Commit messages should describe the change you made, while code
291comments should describe the current state of the code.
d7889f52 292
04c692a8
DR
293If you've just implemented a new feature, complete with doc, tests and
294well-commented code, a brief commit message will often suffice. If,
295however, you've just changed a single character deep in the parser or
296lexer, you might need to write a small novel to ensure that future
297readers understand what you did and why you did it.
d7889f52 298
04c692a8 299=head3 Comments, Comments, Comments
d7889f52 300
04c692a8
DR
301Be sure to adequately comment your code. While commenting every line is
302unnecessary, anything that takes advantage of side effects of
303operators, that creates changes that will be felt outside of the
304function being patched, or that others may find confusing should be
305documented. If you are going to err, it is better to err on the side of
306adding too many comments than too few.
d7889f52 307
04c692a8
DR
308The best comments explain I<why> the code does what it does, not I<what
309it does>.
d7889f52 310
04c692a8 311=head3 Style
d7889f52 312
04c692a8
DR
313In general, please follow the particular style of the code you are
314patching.
d7889f52 315
04c692a8
DR
316In particular, follow these general guidelines for patching Perl
317sources:
cce04beb 318
04c692a8 319=over 4
d7889f52
JH
320
321=item *
322
04c692a8 3238-wide tabs (no exceptions!)
d7889f52
JH
324
325=item *
326
04c692a8 3274-wide indents for code, 2-wide indents for nested CPP #defines
ee9468a2 328
cce04beb 329=item *
ee9468a2 330
04c692a8 331Try hard not to exceed 79-columns
bc028b6b 332
ee9468a2
RGS
333=item *
334
04c692a8 335ANSI C prototypes
d7889f52
JH
336
337=item *
338
04c692a8 339Uncuddled elses and "K&R" style for indenting control constructs
0bec6c03 340
04c692a8 341=item *
d7889f52 342
04c692a8 343No C++ style (//) comments
d7889f52
JH
344
345=item *
346
04c692a8 347Mark places that need to be revisited with XXX (and revisit often!)
27565cb6
JH
348
349=item *
350
04c692a8
DR
351Opening brace lines up with "if" when conditional spans multiple lines;
352should be at end-of-line otherwise
27565cb6 353
04c692a8 354=item *
27565cb6 355
04c692a8
DR
356In function definitions, name starts in column 0 (return value is on
357previous line)
27565cb6 358
04c692a8 359=item *
27565cb6 360
04c692a8
DR
361Single space after keywords that are followed by parens, no space
362between function name and following paren
606fd33d 363
27565cb6
JH
364=item *
365
04c692a8
DR
366Avoid assignments in conditionals, but if they're unavoidable, use
367extra paren, e.g. "if (a && (b = c)) ..."
27565cb6
JH
368
369=item *
370
04c692a8 371"return foo;" rather than "return(foo);"
27565cb6
JH
372
373=item *
374
04c692a8 375"if (!foo) ..." rather than "if (foo == FALSE) ..." etc.
606fd33d
JH
376
377=back
27565cb6 378
04c692a8 379=head3 Test suite
d7889f52 380
a8d15a22 381If your patch changes code (rather than just changing documentation),
04c692a8
DR
382you should also include one or more test cases which illustrate the bug
383you're fixing or validate the new functionality you're adding. In
384general, you should update an existing test file rather than create a
385new one.
2bbc8d55 386
04c692a8
DR
387Your test suite additions should generally follow these guidelines
388(courtesy of Gurusamy Sarathy <gsar@activestate.com>):
2bbc8d55 389
04c692a8 390=over 4
0bec6c03 391
04c692a8 392=item *
0bec6c03 393
04c692a8 394Know what you're testing. Read the docs, and the source.
ee9468a2
RGS
395
396=item *
397
04c692a8 398Tend to fail, not succeed.
0bec6c03 399
04c692a8 400=item *
0bec6c03 401
04c692a8 402Interpret results strictly.
27565cb6 403
04c692a8 404=item *
27565cb6 405
04c692a8 406Use unrelated features (this will flush out bizarre interactions).
27565cb6 407
04c692a8 408=item *
27565cb6 409
04c692a8 410Use non-standard idioms (otherwise you are not testing TIMTOWTDI).
27565cb6 411
04c692a8 412=item *
d7889f52 413
04c692a8
DR
414Avoid using hardcoded test numbers whenever possible (the EXPECTED/GOT
415found in t/op/tie.t is much more maintainable, and gives better failure
416reports).
d7889f52 417
04c692a8 418=item *
d7889f52 419
04c692a8 420Give meaningful error messages when a test fails.
d7889f52 421
04c692a8 422=item *
d7889f52 423
04c692a8
DR
424Avoid using qx// and system() unless you are testing for them. If you
425do use them, make sure that you cover _all_ perl platforms.
d7889f52 426
04c692a8 427=item *
0bec6c03 428
04c692a8 429Unlink any temporary files you create.
63796a85 430
04c692a8 431=item *
0bec6c03 432
04c692a8 433Promote unforeseen warnings to errors with $SIG{__WARN__}.
0bec6c03 434
04c692a8 435=item *
0bec6c03 436
04c692a8
DR
437Be sure to use the libraries and modules shipped with the version being
438tested, not those that were already installed.
d7889f52 439
04c692a8 440=item *
d7889f52 441
04c692a8 442Add comments to the code explaining what you are testing for.
d7889f52 443
04c692a8 444=item *
d7889f52 445
04c692a8
DR
446Make updating the '1..42' string unnecessary. Or make sure that you
447update it.
d7889f52 448
04c692a8 449=item *
d7889f52 450
04c692a8 451Test _all_ behaviors of a given operator, library, or function.
d7889f52 452
04c692a8 453Test all optional arguments.
d7889f52 454
04c692a8 455Test return values in various contexts (boolean, scalar, list, lvalue).
d7889f52 456
04c692a8 457Use both global and lexical variables.
d7889f52 458
04c692a8 459Don't forget the exceptional, pathological cases.
0bec6c03 460
cce04beb 461=back
0bec6c03 462
04c692a8 463=head2 Patching a core module
ee9468a2 464
04c692a8
DR
465This works just like patching anything else, with one extra
466consideration.
63796a85 467
04c692a8
DR
468Some core modules also live on CPAN and are maintained outside of the
469Perl core. When the author updates the module, the updates are simply
470copied into the core.
63796a85 471
a8d15a22 472Modules in the F<cpan/> directory of the source tree are maintained
04c692a8
DR
473outside of the Perl core. See that module's listing on documentation or
474its listing on L<http://search.cpan.org/> for more information on
475reporting bugs and submitting patches.
63796a85 476
04c692a8
DR
477In contrast, modules in the F<dist/> directory are maintained in the
478core.
63796a85 479
04c692a8 480=head2 Updating perldelta
63796a85 481
04c692a8
DR
482For changes significant enough to warrant a F<pod/perldelta.pod> entry,
483the porters will greatly appreciate it if you submit a delta entry
484along with your actual change. Significant changes include, but are not
485limited to:
63796a85 486
04c692a8 487=over 4
63796a85 488
04c692a8 489=item *
63796a85 490
04c692a8 491Adding, deprecating, or removing core features
ee9468a2 492
04c692a8 493=item *
ee9468a2 494
04c692a8 495Adding, deprecating, removing, or upgrading core or dual-life modules
ee9468a2 496
04c692a8 497=item *
ee9468a2 498
04c692a8 499Adding new core tests
ee9468a2 500
04c692a8 501=item *
ee9468a2 502
04c692a8 503Fixing security issues and user-visible bugs in the core
cce04beb 504
04c692a8 505=item *
ad7244db 506
04c692a8 507Changes that might break existing code, either on the perl or C level
ad7244db
JH
508
509=item *
510
04c692a8 511Significant performance improvements
ad7244db
JH
512
513=item *
514
04c692a8
DR
515Adding, removing, or significantly changing documentation in the
516F<pod/> directory
ad7244db 517
cce04beb 518=item *
ad7244db 519
04c692a8 520Important platform-specific changes
d7889f52 521
cce04beb
DG
522=back
523
04c692a8
DR
524Please make sure you add the perldelta entry to the right section
525within F<pod/perldelta.pod>. More information on how to write good
526perldelta entries is available in the C<Style> section of
527F<Porting/how_to_write_a_perldelta.pod>.
d7889f52 528
04c692a8 529=head2 What makes for a good patch?
d7889f52 530
04c692a8
DR
531New features and extensions to the language can be contentious. There
532is no specific set of criteria which determine what features get added,
533but here are some questions to consider when developing a patch:
d7889f52 534
04c692a8 535=head3 Does the concept match the general goals of Perl?
d7889f52 536
04c692a8 537Our goals include, but are not limited to:
d7889f52 538
04c692a8 539=over 4
d7889f52 540
04c692a8 541=item 1.
d7889f52 542
04c692a8 543Keep it fast, simple, and useful.
cce04beb 544
04c692a8 545=item 2.
cce04beb 546
04c692a8 547Keep features/concepts as orthogonal as possible.
902b9dbf 548
04c692a8 549=item 3.
902b9dbf 550
04c692a8 551No arbitrary limits (platforms, data sizes, cultures).
a958818a 552
04c692a8 553=item 4.
ac036724 554
04c692a8 555Keep it open and exciting to use/patch/advocate Perl everywhere.
a958818a 556
04c692a8 557=item 5.
a958818a 558
04c692a8 559Either assimilate new technologies, or build bridges to them.
a958818a 560
04c692a8 561=back
a958818a 562
04c692a8 563=head3 Where is the implementation?
a958818a 564
04c692a8
DR
565All the talk in the world is useless without an implementation. In
566almost every case, the person or people who argue for a new feature
567will be expected to be the ones who implement it. Porters capable of
568coding new features have their own agendas, and are not available to
569implement your (possibly good) idea.
a1b65709 570
04c692a8 571=head3 Backwards compatibility
37c0adeb 572
04c692a8
DR
573It's a cardinal sin to break existing Perl programs. New warnings can
574be contentious--some say that a program that emits warnings is not
575broken, while others say it is. Adding keywords has the potential to
576break programs, changing the meaning of existing token sequences or
577functions might break programs.
f50e5b73 578
04c692a8
DR
579The Perl 5 core includes mechanisms to help porters make backwards
580incompatible changes more compatible such as the L<feature> and
581L<deprecate> modules. Please use them when appropriate.
902b9dbf 582
04c692a8 583=head3 Could it be a module instead?
902b9dbf 584
04c692a8
DR
585Perl 5 has extension mechanisms, modules and XS, specifically to avoid
586the need to keep changing the Perl interpreter. You can write modules
587that export functions, you can give those functions prototypes so they
588can be called like built-in functions, you can even write XS code to
589mess with the runtime data structures of the Perl interpreter if you
590want to implement really complicated things.
902b9dbf 591
04c692a8
DR
592Whenever possible, new features should be prototyped in a CPAN module
593before they will be considered for the core.
902b9dbf 594
04c692a8 595=head3 Is the feature generic enough?
902b9dbf 596
04c692a8
DR
597Is this something that only the submitter wants added to the language,
598or is it broadly useful? Sometimes, instead of adding a feature with a
599tight focus, the porters might decide to wait until someone implements
600the more generalized feature.
902b9dbf 601
04c692a8 602=head3 Does it potentially introduce new bugs?
902b9dbf 603
04c692a8
DR
604Radical rewrites of large chunks of the Perl interpreter have the
605potential to introduce new bugs.
902b9dbf 606
04c692a8 607=head3 How big is it?
902b9dbf 608
04c692a8
DR
609The smaller and more localized the change, the better. Similarly, a
610series of small patches is greatly preferred over a single large patch.
902b9dbf 611
04c692a8 612=head3 Does it preclude other desirable features?
902b9dbf 613
04c692a8
DR
614A patch is likely to be rejected if it closes off future avenues of
615development. For instance, a patch that placed a true and final
616interpretation on prototypes is likely to be rejected because there are
617still options for the future of prototypes that haven't been addressed.
902b9dbf 618
04c692a8 619=head3 Is the implementation robust?
902b9dbf 620
04c692a8
DR
621Good patches (tight code, complete, correct) stand more chance of going
622in. Sloppy or incorrect patches might be placed on the back burner
623until the pumpking has time to fix, or might be discarded altogether
624without further notice.
902b9dbf 625
04c692a8 626=head3 Is the implementation generic enough to be portable?
902b9dbf 627
a8d15a22 628The worst patches make use of system-specific features. It's highly
04c692a8
DR
629unlikely that non-portable additions to the Perl language will be
630accepted.
902b9dbf 631
04c692a8 632=head3 Is the implementation tested?
902b9dbf 633
04c692a8
DR
634Patches which change behaviour (fixing bugs or introducing new
635features) must include regression tests to verify that everything works
636as expected.
902b9dbf 637
04c692a8
DR
638Without tests provided by the original author, how can anyone else
639changing perl in the future be sure that they haven't unwittingly
640broken the behaviour the patch implements? And without tests, how can
641the patch's author be confident that his/her hard work put into the
642patch won't be accidentally thrown away by someone in the future?
902b9dbf 643
04c692a8 644=head3 Is there enough documentation?
902b9dbf 645
04c692a8
DR
646Patches without documentation are probably ill-thought out or
647incomplete. No features can be added or changed without documentation,
648so submitting a patch for the appropriate pod docs as well as the
649source code is important.
902b9dbf 650
04c692a8 651=head3 Is there another way to do it?
902b9dbf 652
04c692a8
DR
653Larry said "Although the Perl Slogan is I<There's More Than One Way to
654Do It>, I hesitate to make 10 ways to do something". This is a tricky
655heuristic to navigate, though--one man's essential addition is another
656man's pointless cruft.
902b9dbf 657
04c692a8 658=head3 Does it create too much work?
902b9dbf 659
04c692a8
DR
660Work for the pumpking, work for Perl programmers, work for module
661authors, ... Perl is supposed to be easy.
902b9dbf 662
04c692a8 663=head3 Patches speak louder than words
902b9dbf 664
04c692a8
DR
665Working code is always preferred to pie-in-the-sky ideas. A patch to
666add a feature stands a much higher chance of making it to the language
667than does a random feature request, no matter how fervently argued the
668request might be. This ties into "Will it be useful?", as the fact that
669someone took the time to make the patch demonstrates a strong desire
670for the feature.
c406981e 671
04c692a8 672=head1 TESTING
c406981e 673
04c692a8
DR
674The core uses the same testing style as the rest of Perl, a simple
675"ok/not ok" run through Test::Harness, but there are a few special
676considerations.
c406981e 677
04c692a8
DR
678There are three ways to write a test in the core. L<Test::More>,
679F<t/test.pl> and ad hoc C<print $test ? "ok 42\n" : "not ok 42\n">. The
680decision of which to use depends on what part of the test suite you're
681working on. This is a measure to prevent a high-level failure (such as
682Config.pm breaking) from causing basic functionality tests to fail.
c406981e 683
04c692a8
DR
684The F<t/test.pl> library provides some of the features of
685L<Test::More>, but avoids loading most modules and uses as few core
686features as possible.
902b9dbf 687
d5d573ba 688If you write your own test, use the L<Test Anything Protocol|http://testanything.org>.
902b9dbf
MF
689
690=over 4
691
04c692a8 692=item * F<t/base> and F<t/comp>
902b9dbf 693
04c692a8
DR
694Since we don't know if require works, or even subroutines, use ad hoc
695tests for these two. Step carefully to avoid using the feature being
696tested.
902b9dbf 697
a8d15a22 698=item * F<t/cmd>, F<t/run>, F<t/io> and F<t/op>
902b9dbf 699
04c692a8
DR
700Now that basic require() and subroutines are tested, you can use the
701F<t/test.pl> library.
902b9dbf 702
a8d15a22 703You can also use certain libraries like Config conditionally, but be
04c692a8 704sure to skip the test gracefully if it's not there.
902b9dbf 705
04c692a8 706=item * Everything else
902b9dbf 707
04c692a8
DR
708Now that the core of Perl is tested, L<Test::More> can and should be
709used. You can also use the full suite of core modules in the tests.
902b9dbf
MF
710
711=back
712
a8d15a22
R
713When you say "make test", Perl uses the F<t/TEST> program to run the
714test suite (except under Win32 where it uses F<t/harness> instead). All
04c692a8
DR
715tests are run from the F<t/> directory, B<not> the directory which
716contains the test. This causes some problems with the tests in F<lib/>,
717so here's some opportunity for some patching.
902b9dbf 718
04c692a8
DR
719You must be triply conscious of cross-platform concerns. This usually
720boils down to using L<File::Spec> and avoiding things like C<fork()>
721and C<system()> unless absolutely necessary.
7a834142 722
04c692a8 723=head2 Special C<make test> targets
07aa3531 724
04c692a8
DR
725There are various special make targets that can be used to test Perl
726slightly differently than the standard "test" target. Not all them are
727expected to give a 100% success rate. Many of them have several
728aliases, and many of them are not available on certain operating
729systems.
07aa3531 730
04c692a8 731=over 4
d44161bf 732
04c692a8 733=item * test_porting
7a834142 734
04c692a8
DR
735This runs some basic sanity tests on the source tree and helps catch
736basic errors before you submit a patch.
7a834142 737
04c692a8 738=item * coretest
7a834142 739
04c692a8 740Run F<perl> on all core tests (F<t/*> and F<lib/[a-z]*> pragma tests).
09187cb1 741
04c692a8 742(Not available on Win32)
09187cb1 743
04c692a8 744=item * test.deparse
09187cb1 745
04c692a8 746Run all the tests through L<B::Deparse>. Not all tests will succeed.
64cea5fd 747
04c692a8 748(Not available on Win32)
64cea5fd 749
04c692a8 750=item * test.taintwarn
64cea5fd 751
04c692a8
DR
752Run all tests with the B<-t> command-line switch. Not all tests are
753expected to succeed (until they're specifically fixed, of course).
51a35ef1 754
04c692a8 755(Not available on Win32)
51a35ef1 756
04c692a8 757=item * minitest
51a35ef1 758
04c692a8
DR
759Run F<miniperl> on F<t/base>, F<t/comp>, F<t/cmd>, F<t/run>, F<t/io>,
760F<t/op>, F<t/uni> and F<t/mro> tests.
51a35ef1 761
04c692a8 762=item * test.valgrind check.valgrind utest.valgrind ucheck.valgrind
51a35ef1 763
04c692a8
DR
764(Only in Linux) Run all the tests using the memory leak + naughty
765memory access tool "valgrind". The log files will be named
766F<testname.valgrind>.
83f0ef60 767
04c692a8 768=item * test.torture torturetest
83f0ef60 769
a8d15a22 770Run all the usual tests and some extra tests. As of Perl 5.8.0, the only
04c692a8 771extra tests are Abigail's JAPHs, F<t/japh/abigail.t>.
83f0ef60 772
04c692a8
DR
773You can also run the torture test with F<t/harness> by giving
774C<-torture> argument to F<t/harness>.
83f0ef60 775
04c692a8 776=item * utest ucheck test.utf8 check.utf8
83f0ef60 777
04c692a8 778Run all the tests with -Mutf8. Not all tests will succeed.
83f0ef60 779
04c692a8 780(Not available on Win32)
83f0ef60 781
04c692a8 782=item * minitest.utf16 test.utf16
83f0ef60 783
04c692a8
DR
784Runs the tests with UTF-16 encoded scripts, encoded with different
785versions of this encoding.
83f0ef60 786
04c692a8
DR
787C<make utest.utf16> runs the test suite with a combination of C<-utf8>
788and C<-utf16> arguments to F<t/TEST>.
83f0ef60 789
04c692a8 790(Not available on Win32)
83f0ef60 791
04c692a8 792=item * test_harness
83f0ef60 793
04c692a8
DR
794Run the test suite with the F<t/harness> controlling program, instead
795of F<t/TEST>. F<t/harness> is more sophisticated, and uses the
796L<Test::Harness> module, thus using this test target supposes that perl
797mostly works. The main advantage for our purposes is that it prints a
798detailed summary of failed tests at the end. Also, unlike F<t/TEST>, it
799doesn't redirect stderr to stdout.
83f0ef60 800
04c692a8
DR
801Note that under Win32 F<t/harness> is always used instead of F<t/TEST>,
802so there is no special "test_harness" target.
83f0ef60 803
04c692a8
DR
804Under Win32's "test" target you may use the TEST_SWITCHES and
805TEST_FILES environment variables to control the behaviour of
806F<t/harness>. This means you can say
83f0ef60 807
04c692a8
DR
808 nmake test TEST_FILES="op/*.t"
809 nmake test TEST_SWITCHES="-torture" TEST_FILES="op/*.t"
83f0ef60 810
78087e0a
R
811=item * test-notty test_notty
812
813Sets PERL_SKIP_TTY_TEST to true before running normal test.
814
83f0ef60
JH
815=back
816
04c692a8 817=head2 Parallel tests
83f0ef60 818
04c692a8
DR
819The core distribution can now run its regression tests in parallel on
820Unix-like platforms. Instead of running C<make test>, set C<TEST_JOBS>
821in your environment to the number of tests to run in parallel, and run
822C<make test_harness>. On a Bourne-like shell, this can be done as
07aa3531 823
04c692a8 824 TEST_JOBS=3 make test_harness # Run 3 tests in parallel
07aa3531 825
04c692a8
DR
826An environment variable is used, rather than parallel make itself,
827because L<TAP::Harness> needs to be able to schedule individual
828non-conflicting test scripts itself, and there is no standard interface
829to C<make> utilities to interact with their job schedulers.
51a35ef1 830
04c692a8 831Note that currently some test scripts may fail when run in parallel (most
a8d15a22 832notably C<ext/IO/t/io_dir.t>). If necessary, run just the failing scripts
04c692a8 833again sequentially and see if the failures go away.
51a35ef1 834
04c692a8 835=head2 Running tests by hand
51a35ef1 836
a8d15a22
R
837You can run part of the test suite by hand by using one of the following
838commands from the F<t/> directory:
51a35ef1 839
04c692a8 840 ./perl -I../lib TEST list-of-.t-files
51a35ef1 841
04c692a8 842or
51a35ef1 843
04c692a8 844 ./perl -I../lib harness list-of-.t-files
51a35ef1 845
a8d15a22 846(If you don't specify test scripts, the whole test suite will be run.)
51a35ef1 847
04c692a8 848=head2 Using F<t/harness> for testing
51a35ef1 849
a8d15a22 850If you use C<harness> for testing, you have several command line options
04c692a8
DR
851available to you. The arguments are as follows, and are in the order
852that they must appear if used together.
51a35ef1 853
04c692a8
DR
854 harness -v -torture -re=pattern LIST OF FILES TO TEST
855 harness -v -torture -re LIST OF PATTERNS TO MATCH
07aa3531 856
a8d15a22 857If C<LIST OF FILES TO TEST> is omitted, the file list is obtained from
04c692a8
DR
858the manifest. The file list may include shell wildcards which will be
859expanded out.
07aa3531 860
04c692a8 861=over 4
4ae3d70a 862
04c692a8 863=item * -v
4ae3d70a 864
04c692a8
DR
865Run the tests under verbose mode so you can see what tests were run,
866and debug output.
51a35ef1 867
04c692a8 868=item * -torture
4ae3d70a 869
04c692a8 870Run the torture tests as well as the normal set.
4ae3d70a 871
04c692a8 872=item * -re=PATTERN
6c41479b 873
04c692a8
DR
874Filter the file list so that all the test files run match PATTERN. Note
875that this form is distinct from the B<-re LIST OF PATTERNS> form below
876in that it allows the file list to be provided as well.
6c41479b 877
04c692a8 878=item * -re LIST OF PATTERNS
6c41479b 879
04c692a8
DR
880Filter the file list so that all the test files run match
881/(LIST|OF|PATTERNS)/. Note that with this form the patterns are joined
882by '|' and you cannot supply a list of files, instead the test files
883are obtained from the MANIFEST.
6c41479b 884
04c692a8 885=back
6c41479b 886
04c692a8 887You can run an individual test by a command similar to
6c41479b 888
a8d15a22 889 ./perl -I../lib path/to/foo.t
6c41479b 890
04c692a8
DR
891except that the harnesses set up some environment variables that may
892affect the execution of the test:
6c41479b
JH
893
894=over 4
895
04c692a8 896=item * PERL_CORE=1
6c41479b 897
a8d15a22 898indicates that we're running this test as part of the perl core test
04c692a8 899suite. This is useful for modules that have a dual life on CPAN.
6c41479b 900
04c692a8 901=item * PERL_DESTRUCT_LEVEL=2
6c41479b 902
04c692a8 903is set to 2 if it isn't set already (see
a8d15a22 904L<perlhacktips/PERL_DESTRUCT_LEVEL>).
6c41479b 905
04c692a8 906=item * PERL
6c41479b 907
04c692a8
DR
908(used only by F<t/TEST>) if set, overrides the path to the perl
909executable that should be used to run the tests (the default being
910F<./perl>).
6c41479b 911
04c692a8 912=item * PERL_SKIP_TTY_TEST
6c41479b 913
04c692a8
DR
914if set, tells to skip the tests that need a terminal. It's actually set
915automatically by the Makefile, but can also be forced artificially by
916running 'make test_notty'.
6c41479b 917
04c692a8 918=back
6c41479b 919
04c692a8 920=head3 Other environment variables that may influence tests
6c41479b 921
04c692a8 922=over 4
6c41479b 923
04c692a8 924=item * PERL_TEST_Net_Ping
6c41479b 925
04c692a8
DR
926Setting this variable runs all the Net::Ping modules tests, otherwise
927some tests that interact with the outside world are skipped. See
928L<perl58delta>.
6c41479b 929
04c692a8 930=item * PERL_TEST_NOVREXX
cce04beb 931
04c692a8 932Setting this variable skips the vrexx.t tests for OS2::REXX.
cce04beb 933
04c692a8 934=item * PERL_TEST_NUMCONVERTS
cce04beb 935
04c692a8 936This sets a variable in op/numconvert.t.
cce04beb 937
04c692a8 938=back
cce04beb 939
04c692a8
DR
940See also the documentation for the Test and Test::Harness modules, for
941more environment variables that affect testing.
cce04beb 942
04c692a8 943=head1 MORE READING FOR GUTS HACKERS
cce04beb 944
04c692a8 945To hack on the Perl guts, you'll need to read the following things:
cce04beb 946
04c692a8 947=over 4
cce04beb 948
04c692a8 949=item * L<perlsource>
b8ddf6b3 950
04c692a8
DR
951An overview of the Perl source tree. This will help you find the files
952you're looking for.
b8ddf6b3 953
04c692a8 954=item * L<perlinterp>
b8ddf6b3 955
04c692a8
DR
956An overview of the Perl interpreter source code and some details on how
957Perl does what it does.
b8ddf6b3 958
04c692a8 959=item * L<perlhacktut>
b8ddf6b3 960
04c692a8
DR
961This document walks through the creation of a small patch to Perl's C
962code. If you're just getting started with Perl core hacking, this will
963help you understand how it works.
b8ddf6b3 964
04c692a8 965=item * L<perlhacktips>
b8ddf6b3 966
04c692a8
DR
967More details on hacking the Perl core. This document focuses on lower
968level details such as how to write tests, compilation issues,
969portability, debugging, etc.
b8ddf6b3 970
04c692a8 971If you plan on doing serious C hacking, make sure to read this.
b8ddf6b3 972
04c692a8 973=item * L<perlguts>
b8ddf6b3 974
04c692a8
DR
975This is of paramount importance, since it's the documentation of what
976goes where in the Perl source. Read it over a couple of times and it
977might start to make sense - don't worry if it doesn't yet, because the
978best way to study it is to read it in conjunction with poking at Perl
979source, and we'll do that later on.
b8ddf6b3 980
04c692a8
DR
981Gisle Aas's "illustrated perlguts", also known as I<illguts>, has very
982helpful pictures:
9965345d 983
04c692a8 984L<http://search.cpan.org/dist/illguts/>
9965345d 985
04c692a8 986=item * L<perlxstut> and L<perlxs>
f1fac472 987
04c692a8
DR
988A working knowledge of XSUB programming is incredibly useful for core
989hacking; XSUBs use techniques drawn from the PP code, the portion of
990the guts that actually executes a Perl program. It's a lot gentler to
991learn those techniques from simple examples and explanation than from
992the core itself.
f1fac472 993
04c692a8 994=item * L<perlapi>
f1fac472 995
04c692a8
DR
996The documentation for the Perl API explains what some of the internal
997functions do, as well as the many macros used in the source.
f1fac472 998
04c692a8 999=item * F<Porting/pumpkin.pod>
f1fac472 1000
04c692a8
DR
1001This is a collection of words of wisdom for a Perl porter; some of it
1002is only useful to the pumpkin holder, but most of it applies to anyone
1003wanting to go about Perl development.
f1fac472 1004
04c692a8 1005=item * The perl5-porters FAQ
f1fac472 1006
04c692a8
DR
1007This should be available from
1008http://dev.perl.org/perl5/docs/p5p-faq.html . It contains hints on
1009reading perl5-porters, information on how perl5-porters works and how
1010Perl development in general works.
f1fac472 1011
04c692a8 1012=back
f1fac472 1013
04c692a8 1014=head1 CPAN TESTERS AND PERL SMOKERS
f1fac472 1015
04c692a8
DR
1016The CPAN testers ( http://testers.cpan.org/ ) are a group of volunteers
1017who test CPAN modules on a variety of platforms.
b8ddf6b3 1018
a8d15a22 1019Perl Smokers ( http://www.nntp.perl.org/group/perl.daily-build/ and
04c692a8
DR
1020http://www.nntp.perl.org/group/perl.daily-build.reports/ )
1021automatically test Perl source releases on platforms with various
1022configurations.
f1fac472 1023
04c692a8
DR
1024Both efforts welcome volunteers. In order to get involved in smoke
1025testing of the perl itself visit
a8d15a22 1026L<http://search.cpan.org/dist/Test-Smoke/>. In order to start smoke
04c692a8
DR
1027testing CPAN modules visit
1028L<http://search.cpan.org/dist/CPANPLUS-YACSmoke/> or
1029L<http://search.cpan.org/dist/minismokebox/> or
1030L<http://search.cpan.org/dist/CPAN-Reporter/>.
f1fac472 1031
04c692a8 1032=head1 WHAT NEXT?
a422fd2d 1033
04c692a8
DR
1034If you've read all the documentation in the document and the ones
1035listed above, you're more than ready to hack on Perl.
a422fd2d 1036
04c692a8 1037Here's some more recommendations
a422fd2d 1038
04c692a8 1039=over 4
a422fd2d
SC
1040
1041=item *
1042
1043Subscribe to perl5-porters, follow the patches and try and understand
1044them; don't be afraid to ask if there's a portion you're not clear on -
1045who knows, you may unearth a bug in the patch...
1046
1047=item *
1048
04c692a8
DR
1049Do read the README associated with your operating system, e.g.
1050README.aix on the IBM AIX OS. Don't hesitate to supply patches to that
1051README if you find anything missing or changed over a new OS release.
a1f349fd
MB
1052
1053=item *
1054
a422fd2d
SC
1055Find an area of Perl that seems interesting to you, and see if you can
1056work out how it works. Scan through the source, and step over it in the
1057debugger. Play, poke, investigate, fiddle! You'll probably get to
04c692a8
DR
1058understand not just your chosen area but a much wider range of
1059F<perl>'s activity as well, and probably sooner than you'd think.
a422fd2d
SC
1060
1061=back
1062
04c692a8 1063=head2 "The Road goes ever on and on, down from the door where it began."
a422fd2d 1064
04c692a8
DR
1065If you can do these things, you've started on the long road to Perl
1066porting. Thanks for wanting to help make Perl better - and happy
1067hacking!
a422fd2d 1068
4ac71550
TC
1069=head2 Metaphoric Quotations
1070
1071If you recognized the quote about the Road above, you're in luck.
1072
04c692a8
DR
1073Most software projects begin each file with a literal description of
1074each file's purpose. Perl instead begins each with a literary allusion
1075to that file's purpose.
4ac71550 1076
04c692a8
DR
1077Like chapters in many books, all top-level Perl source files (along
1078with a few others here and there) begin with an epigramic inscription
1079that alludes, indirectly and metaphorically, to the material you're
1080about to read.
4ac71550 1081
a8d15a22 1082Quotations are taken from writings of J.R.R. Tolkien pertaining to his
04c692a8 1083Legendarium, almost always from I<The Lord of the Rings>. Chapters and
4ac71550
TC
1084page numbers are given using the following editions:
1085
1086=over 4
1087
04c692a8 1088=item *
4ac71550 1089
04c692a8
DR
1090I<The Hobbit>, by J.R.R. Tolkien. The hardcover, 70th-anniversary
1091edition of 2007 was used, published in the UK by Harper Collins
1092Publishers and in the US by the Houghton Mifflin Company.
4ac71550
TC
1093
1094=item *
1095
04c692a8
DR
1096I<The Lord of the Rings>, by J.R.R. Tolkien. The hardcover,
109750th-anniversary edition of 2004 was used, published in the UK by
1098Harper Collins Publishers and in the US by the Houghton Mifflin
1099Company.
4ac71550
TC
1100
1101=item *
1102
04c692a8
DR
1103I<The Lays of Beleriand>, by J.R.R. Tolkien and published posthumously
1104by his son and literary executor, C.J.R. Tolkien, being the 3rd of the
110512 volumes in Christopher's mammoth I<History of Middle Earth>. Page
1106numbers derive from the hardcover edition, first published in 1983 by
1107George Allen & Unwin; no page numbers changed for the special 3-volume
1108omnibus edition of 2002 or the various trade-paper editions, all again
1109now by Harper Collins or Houghton Mifflin.
4ac71550
TC
1110
1111=back
1112
04c692a8
DR
1113Other JRRT books fair game for quotes would thus include I<The
1114Adventures of Tom Bombadil>, I<The Silmarillion>, I<Unfinished Tales>,
1115and I<The Tale of the Children of Hurin>, all but the first
1116posthumously assembled by CJRT. But I<The Lord of the Rings> itself is
1117perfectly fine and probably best to quote from, provided you can find a
1118suitable quote there.
4ac71550 1119
04c692a8
DR
1120So if you were to supply a new, complete, top-level source file to add
1121to Perl, you should conform to this peculiar practice by yourself
1122selecting an appropriate quotation from Tolkien, retaining the original
1123spelling and punctuation and using the same format the rest of the
1124quotes are in. Indirect and oblique is just fine; remember, it's a
1125metaphor, so being meta is, after all, what it's for.
4ac71550 1126
e8cd7eae
GS
1127=head1 AUTHOR
1128
04c692a8
DR
1129This document was originally written by Nathan Torkington, and is
1130maintained by the perl5-porters mailing list.
b16c2e4a 1131