perl.git
8 years agoMake print_section a method
Steffen Mueller [Sat, 19 Feb 2011 15:51:18 +0000 (16:51 +0100)] 
Make print_section a method

As with previous changes, checking whether a localization of $_ or
something along those lines is acceptable remains to be done.

8 years agoTransform FOO_handlers to methods
Steffen Mueller [Sat, 19 Feb 2011 15:49:24 +0000 (16:49 +0100)] 
Transform FOO_handlers to methods

8 years agoMore methods (merge_section)
Steffen Mueller [Sat, 19 Feb 2011 15:38:13 +0000 (16:38 +0100)] 
More methods (merge_section)

8 years agoMake PushXSStack a method
Steffen Mueller [Sat, 19 Feb 2011 15:36:43 +0000 (16:36 +0100)] 
Make PushXSStack a method

8 years agoTransform some functions into methods on the proto-object
Steffen Mueller [Sat, 19 Feb 2011 15:34:57 +0000 (16:34 +0100)] 
Transform some functions into methods on the proto-object

8 years agoSome simple tests for errors
Steffen Mueller [Sat, 19 Feb 2011 13:02:03 +0000 (14:02 +0100)] 
Some simple tests for errors

8 years agoBetter error checking/handling
Steffen Mueller [Sat, 19 Feb 2011 13:01:48 +0000 (14:01 +0100)] 
Better error checking/handling

8 years agoEliminate four unsightly magical hash refs
Steffen Mueller [Fri, 18 Feb 2011 21:18:02 +0000 (22:18 +0100)] 
Eliminate four unsightly magical hash refs

Previously, we'd be generating and passing around four lookup tables for
C-type to XS-type (type kind), C-type to prototype, XS-type to input map
code, and XS-type to output map code. This is now all handled by
ExtUtils::Typemaps.

8 years agoMake trailing whitespace a newline at all times
Steffen Mueller [Sat, 19 Feb 2011 13:01:25 +0000 (14:01 +0100)] 
Make trailing whitespace a newline at all times

8 years agouse warnings
Steffen Mueller [Fri, 18 Feb 2011 21:17:50 +0000 (22:17 +0100)] 
use warnings

8 years agoMake get_(in|out)putmap more flexible
Steffen Mueller [Fri, 18 Feb 2011 20:36:32 +0000 (21:36 +0100)] 
Make get_(in|out)putmap more flexible

They now also accept ctypes which are resolved to xstypes via the
typemap section.

8 years agoAdd targetable method
Steffen Mueller [Sun, 13 Feb 2011 22:30:56 +0000 (23:30 +0100)] 
Add targetable method

This does the same thing for a simple output map as the make_targetable
function in ExtUtils::ParseXS::Utilities does for all output maps. The
latter function is intended to be superseded by this new method.

8 years agoAdd comment explaining where terrible code comes from
Steffen Mueller [Sun, 13 Feb 2011 10:22:15 +0000 (11:22 +0100)] 
Add comment explaining where terrible code comes from

... and it is not brought by the stork.

8 years agoDocument inception of EU::Typemaps
Steffen Mueller [Fri, 11 Feb 2011 18:01:18 +0000 (19:01 +0100)] 
Document inception of EU::Typemaps

8 years agoBless singleton
Steffen Mueller [Fri, 11 Feb 2011 17:42:53 +0000 (18:42 +0100)] 
Bless singleton

8 years agoNah, implicit is bad
Steffen Mueller [Fri, 11 Feb 2011 17:37:41 +0000 (18:37 +0100)] 
Nah, implicit is bad

8 years agoLose now obsolete process_single_typemap()
Steffen Mueller [Fri, 11 Feb 2011 17:35:31 +0000 (18:35 +0100)] 
Lose now obsolete process_single_typemap()

This was the actual typemap parser. It is now parsed by
ExtUtils::Typemaps, so we don't need it any more!

8 years agoMake ExtUtils::ParseXS use ExtUtils::Typemaps
Steffen Mueller [Fri, 11 Feb 2011 17:31:44 +0000 (18:31 +0100)] 
Make ExtUtils::ParseXS use ExtUtils::Typemaps

This is just the quick'n'dirty conversion to make it use
EU::Typemaps. Eventually, we want to use it in its full object-oriented
goodness!

8 years agoDo not use Carp, fix propagation of replace/skip
Steffen Mueller [Sun, 13 Feb 2011 20:00:53 +0000 (21:00 +0100)] 
Do not use Carp, fix propagation of replace/skip

Using Carp in a module this early in the toolchain can cause ugly
failure. Carp can trigger loading overload. overload::StrVal can trigger
loading Scalar::Util. Scalar::Util::PP requires B. miniperl doesn't like
loading shared libraries.

This problem with Carp just shadowed the underlying problem that the
replace/skip options weren't propagated correctly.

8 years agoDefer loading main module
Steffen Mueller [Sun, 13 Feb 2011 19:22:03 +0000 (20:22 +0100)] 
Defer loading main module

8 years agoMore whitespace bug-compatibility
Steffen Mueller [Sun, 13 Feb 2011 19:13:45 +0000 (20:13 +0100)] 
More whitespace bug-compatibility

8 years agoMore compatibility testing
Steffen Mueller [Sun, 13 Feb 2011 10:20:03 +0000 (11:20 +0100)] 
More compatibility testing

8 years agoAdd test of EU::Typemap output against old ParseXS code
Steffen Mueller [Sat, 12 Feb 2011 17:54:38 +0000 (18:54 +0100)] 
Add test of EU::Typemap output against old ParseXS code

This is testing for string equivalency, not code equivalency. But it's
better than nothing.

8 years agoMore bug-compatibility with old ExtUtils::ParseXS
Steffen Mueller [Sat, 12 Feb 2011 17:52:00 +0000 (18:52 +0100)] 
More bug-compatibility with old ExtUtils::ParseXS

8 years agoReinstate prototype default and warning about invalid prototypes
Steffen Mueller [Fri, 11 Feb 2011 21:52:30 +0000 (22:52 +0100)] 
Reinstate prototype default and warning about invalid prototypes

8 years agoAdd method to get ANSIfied code
Steffen Mueller [Fri, 11 Feb 2011 18:24:21 +0000 (19:24 +0100)] 
Add method to get ANSIfied code

This is done to all of the code in EU::PXS anyway, so why not
have a nice method for it?

8 years agoImplement 'skip' option for merging typemaps
Steffen Mueller [Fri, 11 Feb 2011 17:21:10 +0000 (18:21 +0100)] 
Implement 'skip' option for merging typemaps

This implements the 'first come first serve' style merging that
ExtUtils::ParseXS currently does: It prefers the typemap entries that
exist already over new ones. This is because the order of processed
typemaps is such that the default typemaps come last.

8 years agoImplement 'replace' option when merging typemaps
Steffen Mueller [Fri, 11 Feb 2011 16:20:17 +0000 (17:20 +0100)] 
Implement 'replace' option when merging typemaps

And by proxy, this had to be implemented in the three add_* methods.
Also adds more tests for merging with conflicts.

8 years agoAllow merging typemaps from file
Steffen Mueller [Fri, 11 Feb 2011 16:09:10 +0000 (17:09 +0100)] 
Allow merging typemaps from file

8 years agoAdd method to generate the prototype lookup hash
Steffen Mueller [Fri, 11 Feb 2011 15:50:12 +0000 (16:50 +0100)] 
Add method to generate the prototype lookup hash

Akin to the methods in the parent commit that generate the lookup hash
for TYPEMAP/INPUT/OUTPUT, this method will generate the lookup has for
typemap's prototypes as required by ExtUtils::ParseXS at this time.

8 years agoMethods to get typemaps in ParseXS compatible format
Steffen Mueller [Fri, 11 Feb 2011 15:42:46 +0000 (16:42 +0100)] 
Methods to get typemaps in ParseXS compatible format

Essentially, these extra methods export the typemap information in the
format expected by ExtUtils::ParseXS at this time. Down the road, we may
want EU::PXS to simply pass around an ExtUtils::Typemaps object.

8 years agoReduce code duplication by using the same prototype regexp
Steffen Mueller [Fri, 11 Feb 2011 13:37:33 +0000 (14:37 +0100)] 
Reduce code duplication by using the same prototype regexp

8 years agoTeach EU::Typemaps about the _ prototype
Steffen Mueller [Thu, 10 Feb 2011 16:12:23 +0000 (17:12 +0100)] 
Teach EU::Typemaps about the _ prototype

I am in a hurry and this makes things correct, but really, this should
maybe use EU::ParseXS' regular expression.

8 years agoBump ExtUtils::Typemaps version
Steffen Mueller [Thu, 10 Feb 2011 15:51:53 +0000 (16:51 +0100)] 
Bump ExtUtils::Typemaps version

Just to make sure there really will never be a confusion or
collision with the similarly named module that has been living
on CPAN.

8 years agoSimplify "remove" logic after previous refactoring
Steffen Mueller [Thu, 10 Feb 2011 15:51:18 +0000 (16:51 +0100)] 
Simplify "remove" logic after previous refactoring

8 years agoHash lookup for output sections
Steffen Mueller [Thu, 10 Feb 2011 15:45:29 +0000 (16:45 +0100)] 
Hash lookup for output sections

More O(1) for everyone.
Also fixes a tiny issue with an error message from the inputmap
conversion.

8 years agoConvert input sections to hash lookup
Steffen Mueller [Thu, 10 Feb 2011 15:41:09 +0000 (16:41 +0100)] 
Convert input sections to hash lookup

Die, O(n), die!

8 years agoStart refactoring EU::Typemaps
Steffen Mueller [Thu, 10 Feb 2011 15:26:10 +0000 (16:26 +0100)] 
Start refactoring EU::Typemaps

Use a hash lookup for avoiding collisions.

8 years agoRemove note about being untested
Steffen Mueller [Thu, 10 Feb 2011 13:19:54 +0000 (14:19 +0100)] 
Remove note about being untested

This code is actually in production use.

8 years agoupdate copyright
Steffen Mueller [Thu, 10 Feb 2011 13:18:57 +0000 (14:18 +0100)] 
update copyright

8 years agoAdd a trailing 's' to the name of EU::Typemap
Steffen Mueller [Thu, 10 Feb 2011 13:17:17 +0000 (14:17 +0100)] 
Add a trailing 's' to the name of EU::Typemap

This is to prevent collisions on case-insensitive file systems with
lib/typemap.

8 years agoExtract typemap-related code from ExtUtils::ParseXS
Steffen Mueller [Thu, 10 Feb 2011 12:51:54 +0000 (13:51 +0100)] 
Extract typemap-related code from ExtUtils::ParseXS

This was available from CPAN a while ago. The plan is to use it to make
the typemap parsing and manipulation saner and rip the parser from
ExtUtils::ParseXS' dead claws.

8 years agoCleanup of make_targetable smueller/strictpxs_fixups
Steffen Mueller [Sun, 13 Feb 2011 22:34:58 +0000 (23:34 +0100)] 
Cleanup of make_targetable

8 years agoFix function name in documentation
Steffen Mueller [Fri, 11 Feb 2011 18:01:39 +0000 (19:01 +0100)] 
Fix function name in documentation

8 years agoRemove unnecessary Data::Dumper loading
Steffen Mueller [Fri, 11 Feb 2011 21:47:59 +0000 (22:47 +0100)] 
Remove unnecessary Data::Dumper loading

8 years agoRevert "Revert "Moved prototype check to XS code, allowing the .pm file change from...
Steffen Mueller [Fri, 11 Feb 2011 17:55:12 +0000 (18:55 +0100)] 
Revert "Revert "Moved prototype check to XS code, allowing the .pm file change from yesterday""

This reverts commit cf8fc7eed929846d31d02d565b4d5f4480a18d69,
reinstating the move of the prototype check to XS code.

8 years agoStart documenting the EU::ParseXS changes
Steffen Mueller [Fri, 11 Feb 2011 17:55:04 +0000 (18:55 +0100)] 
Start documenting the EU::ParseXS changes

8 years agoDocumentation: maintainers & copyright
Steffen Mueller [Fri, 11 Feb 2011 17:43:12 +0000 (18:43 +0100)] 
Documentation: maintainers & copyright

Adding Jim Keenan and myself to the list of maintainers. Sorry, Jim!
Update copyright and prettify a note.

8 years agoDocumentation fix
Steffen Mueller [Fri, 11 Feb 2011 15:26:41 +0000 (16:26 +0100)] 
Documentation fix

Be more precise about the return values of process_typemaps().

8 years agoRename some ExtUtils::ParseXS 'constants'
Steffen Mueller [Fri, 11 Feb 2011 12:36:06 +0000 (13:36 +0100)] 
Rename some ExtUtils::ParseXS 'constants'

Make them have properly descriptive, camel case names.

8 years agoReapply the patch that tought EU::ParseXS about _ protos
Steffen Mueller [Thu, 10 Feb 2011 16:09:26 +0000 (17:09 +0100)] 
Reapply the patch that tought EU::ParseXS about _ protos

Even including a test!

8 years agoIgnore new ExtUtils::ParseXS files in lib
Steffen Mueller [Thu, 10 Feb 2011 10:14:28 +0000 (11:14 +0100)] 
Ignore new ExtUtils::ParseXS files in lib

8 years agoRe-apply ExtUtils::ParseXS portion of 1e8125c62127
Steffen Mueller [Thu, 10 Feb 2011 09:24:24 +0000 (10:24 +0100)] 
Re-apply ExtUtils::ParseXS portion of 1e8125c62127

Which had to be reverted as 634b52b92f42a6bb93c549
for a big rebase.

8 years agoRe-apply typo fixes from c4a6f826b3676d1fdbd99
Steffen Mueller [Thu, 10 Feb 2011 09:22:56 +0000 (10:22 +0100)] 
Re-apply typo fixes from c4a6f826b3676d1fdbd99

These had to be reverted for the ExtUtils::ParseXS rebase of Jim
Keenan's strictification work.

Originally reverted as 8e19e0c1f155990dc120199.

8 years agoRe-apply EU::ParseXS portion of c33e8be1506a75e
Steffen Mueller [Thu, 10 Feb 2011 09:20:11 +0000 (10:20 +0100)] 
Re-apply EU::ParseXS portion of c33e8be1506a75e

This is the unused-arg stuff in tests.
Originally reverted as 836ae07757f3a1a32212.

8 years agoA bit more documentation of make_targetable().
James E. Keenan [Thu, 15 Apr 2010 12:15:24 +0000 (08:15 -0400)] 
A bit more documentation of make_targetable().

8 years agoAdd documentation on the hashrefs produced by process_typemaps().
James E. Keenan [Thu, 15 Apr 2010 02:21:27 +0000 (22:21 -0400)] 
Add documentation on the hashrefs produced by process_typemaps().

8 years agoAdd documentation and additional tests
James E. Keenan [Thu, 15 Apr 2010 02:17:26 +0000 (22:17 -0400)] 
Add documentation and additional tests

... exploring relationship between typemaps and \%targetable.

8 years agoMostly adding tests and documentation.
James E. Keenan [Sun, 11 Apr 2010 20:48:23 +0000 (16:48 -0400)] 
Mostly adding tests and documentation.

Rename sub print_preprocessor_statements() to
analyze_preprocessor_statements().  Modify interface to map_type() and
re-work tests as needed.  Wrote documentation in Utilities.pm for
process_single_typemap(), map_type(), standard_XS_defs(),
assign_func_args(), analyze_preprocessor_statements().  Write tests
in t/109-standard_XS_defs.t, t/110-assign_func_args.t.

8 years agoMove several functions to Utilities.pm
James E. Keenan [Sun, 11 Apr 2010 17:52:39 +0000 (13:52 -0400)] 
Move several functions to Utilities.pm

Namely: check_conditional_preprocessor_statements(), Warn(),
blurt() and death() to Utilities.pm.

Add file to test blurt, death and Warn.  (death() is not
really testable yet due to hard-coded 'exit'.)  ovid++, rjbs++,
xdg+++ for assistance in developing tests."

8 years agoChange check_cpp() to check_conditional_preprocessor_statements()
James E. Keenan [Sun, 11 Apr 2010 14:35:40 +0000 (10:35 -0400)] 
Change check_cpp() to check_conditional_preprocessor_statements()

... to be more self-documenting.

Also: Explicitly pass $self to Warn(), blurt() and death().
Add skeletons of files to test functions moved (or planned to be
moved) to Utilities.pm.

8 years agoWas able to move $Packid into $self.
James E. Keenan [Sat, 10 Apr 2010 14:24:00 +0000 (10:24 -0400)] 
Was able to move $Packid into $self.

Note that I got build failures when I attempted to pull $Package into $self.

The distributions below because during various 'eval EXPR'
statements, I got a 'Global variable $Package ...' error.

cut -d '/' -f 7,8,9,10,11 research/problematic.builds.20100410.txt
D/DB/DBURDICK/BoostGraph/Boost-Graph-1.4.tar.gz
D/DE/DEEMON/Crypt-OpenSSL-SMIME-0.02.tar.gz
D/DL/DLOWE/Text-Tmpl-0.33.tar.gz
D/DM/DMAKI/Data-Valve-0.00010.tar.gz
D/DO/DORMANDO/Perlbal-XS-HTTPHeaders-0.20.tar.gz
E/ED/EDPRATOMO/Algorithm-Permute-0.12.tar.gz
J/JH/JHI/String-Approx-3.26.tar.gz
K/KA/KARMAN/Search-Tools-0.45.tar.gz
K/KI/KILINRAX/HTML-Strip-1.06.tar.gz
L/LA/LAIRDM/Algorithm-SVM-0.13.tar.gz
M/MA/MARKSMITH/HTTP-HeaderParser-XS-0.20.tar.gz
M/MC/MCEGLOWS/Search-ContextGraph-0.15.tar.gz
M/MH/MHX/Convert-Binary-C-0.74.tar.gz
M/MH/MHX/Tie-Hash-Indexed-0.05.tar.gz
M/MI/MIKEWONG/Table-ParentChild-0.05.tar.gz
M/MS/MSERGEANT/CDB_File-0.96.tar.gz
M/MS/MSERGEANT/IO-KQueue-0.34.tar.gz
P/PA/PAJAS/XML-LibXML-1.70.tar.gz
P/PM/PMQS/Filter-1.37.tar.gz
S/SA/SALVA/Compress-PPMd-0.11.tar.gz
S/SA/SAPER/Net-Pcap-0.16.tar.gz
S/SA/SAPER/Net-RawIP-0.25.tar.gz
S/SG/SGOELDNER/MonetDB-CLI-MapiXS-0.03.tar.gz
S/SM/SMUELLER/Math-SymbolicX-FastEvaluator-0.01.tar.gz
S/SM/SMUELLER/Parse-ExuberantCTags-1.01.tar.gz
S/SP/SPIDB/Net-ext-1.011.tar.gz
T/TJ/TJMATHER/Crypt-OpenSSL-DSA-0.13.tar.gz

8 years agoRefactor some code into sub set_cond()
James E. Keenan [Sat, 10 Apr 2010 13:24:33 +0000 (09:24 -0400)] 
Refactor some code into sub set_cond()

Eliminate instances of calling subs with '&'.

8 years agoAdd vim modeline entries.
James E. Keenan [Sat, 10 Apr 2010 12:56:06 +0000 (08:56 -0400)] 
Add vim modeline entries.

8 years agoMove sub print_preprocessor_statements() into Utilities.pm.
James E. Keenan [Sat, 10 Apr 2010 01:42:30 +0000 (21:42 -0400)] 
Move sub print_preprocessor_statements() into Utilities.pm.

8 years agoRefactor some code into sub assign_func_args().
James E. Keenan [Sat, 10 Apr 2010 01:38:57 +0000 (21:38 -0400)] 
Refactor some code into sub assign_func_args().

8 years agoDon't have to undef if it's never been assigned to.
James E. Keenan [Fri, 9 Apr 2010 03:02:50 +0000 (23:02 -0400)] 
Don't have to undef if it's never been assigned to.

8 years agoMove several variables found inside the PARAGRAPH loop
James E. Keenan [Fri, 9 Apr 2010 02:16:04 +0000 (22:16 -0400)] 
Move several variables found inside the PARAGRAPH loop

... closer to the point where each is first used.

8 years agoMove $orig_args closer to where it's used
James E. Keenan [Fri, 9 Apr 2010 01:04:51 +0000 (21:04 -0400)] 
Move $orig_args closer to where it's used

8 years agoMove $prepush_done closer to where it's used
James E. Keenan [Fri, 9 Apr 2010 00:39:05 +0000 (20:39 -0400)] 
Move $prepush_done closer to where it's used

8 years agoMove $func_header inside while loop closer to where it's used
James E. Keenan [Thu, 8 Apr 2010 12:18:14 +0000 (08:18 -0400)] 
Move $func_header inside while loop closer to where it's used

8 years agoMove two heredocs into Utilities::standard_XS_defs().
James E. Keenan [Tue, 6 Apr 2010 23:46:54 +0000 (19:46 -0400)] 
Move two heredocs into Utilities::standard_XS_defs().

8 years agoChange @outlist and %only_C_inlist into corresponding references
James E. Keenan [Sun, 4 Apr 2010 13:37:17 +0000 (09:37 -0400)] 
Change @outlist and %only_C_inlist into corresponding references

... in anticipation of upcoming refactorings,

8 years agoAdd messages to 3 tests which lacked them.
James E. Keenan [Sun, 4 Apr 2010 13:10:06 +0000 (09:10 -0400)] 
Add messages to 3 tests which lacked them.

8 years agoMove 4 elements in %args into $self
James E. Keenan [Sat, 3 Apr 2010 22:23:45 +0000 (18:23 -0400)] 
Move 4 elements in %args into $self

It was not yet possible to move $args{'s'} into $self because
of a quotemeta problem.

8 years agoNo evident need for 'for' loop in assignment from $args{filename}.
James E. Keenan [Sat, 3 Apr 2010 21:05:07 +0000 (17:05 -0400)] 
No evident need for 'for' loop in assignment from $args{filename}.

8 years agoExplicitly pass $self to check_cpp()
James E. Keenan [Sat, 3 Apr 2010 21:00:31 +0000 (17:00 -0400)] 
Explicitly pass $self to check_cpp()

Also explicitly return $self from print_preprocessor_statements().

8 years agoRefactor code inside process_file() into print_preprocessor_statements()
James E. Keenan [Sat, 3 Apr 2010 19:00:02 +0000 (15:00 -0400)] 
Refactor code inside process_file() into print_preprocessor_statements()

8 years agoChange \@BootCode to $BootCode_ref
James E. Keenan [Sat, 3 Apr 2010 14:00:52 +0000 (10:00 -0400)] 
Change \@BootCode to $BootCode_ref

to facilitate more refactoring of code into (somewhat) encapsulated
subs.

8 years agoEliminate some synthetic variables
James E. Keenan [Sat, 3 Apr 2010 13:25:55 +0000 (09:25 -0400)] 
Eliminate some synthetic variables

and move declarations of some lexicals closer to the point where
they are actually used.

8 years agoTypographical cleanup
James E. Keenan [Sat, 3 Apr 2010 13:05:13 +0000 (09:05 -0400)] 
Typographical cleanup

Mostly elimination of trailing whitespace.

8 years agoAdd $newXS to $self
James E. Keenan [Sat, 3 Apr 2010 02:39:15 +0000 (22:39 -0400)] 
Add $newXS to $self

Keeping fingers crossed!

8 years agoMove $proto into $self;
James E. Keenan [Thu, 1 Apr 2010 12:20:02 +0000 (08:20 -0400)] 
Move $proto into $self;

8 years agoAdd $Module_cname to $self.
James E. Keenan [Thu, 1 Apr 2010 11:08:35 +0000 (07:08 -0400)] 
Add $Module_cname to $self.

8 years agoMove %defaults to $self.
James E. Keenan [Thu, 1 Apr 2010 02:48:28 +0000 (22:48 -0400)] 
Move %defaults to $self.

8 years agoMove @line to $self.
James E. Keenan [Thu, 1 Apr 2010 01:55:17 +0000 (21:55 -0400)] 
Move @line to $self.

8 years agoMove @line_no, @Attributes, %outargs, @XSStack to $self.
James E. Keenan [Wed, 31 Mar 2010 23:37:04 +0000 (19:37 -0400)] 
Move @line_no, @Attributes, %outargs, @XSStack to $self.

8 years agoMove %lengthof, %XsubAliases, %XsubAliasValues, %Interfaces.
James E. Keenan [Wed, 31 Mar 2010 03:10:30 +0000 (23:10 -0400)] 
Move %lengthof, %XsubAliases, %XsubAliasValues, %Interfaces.

To do: Eliminate confusion between these attributes: interface
(scalar) interfaces (scalar) Interfaces (hash)

8 years agoAdd \%in_out and \%argtype_seen to $self.
James E. Keenan [Wed, 31 Mar 2010 02:23:02 +0000 (22:23 -0400)] 
Add \%in_out and \%argtype_seen to $self.

8 years agoMove 9 'our' hashes and arrays into $self
James E. Keenan [Wed, 31 Mar 2010 00:47:51 +0000 (20:47 -0400)] 
Move 9 'our' hashes and arrays into $self

For now, bypassing \@line, \%defaults.

8 years agoMove $var_num into $self.
James E. Keenan [Tue, 30 Mar 2010 22:45:21 +0000 (18:45 -0400)] 
Move $var_num into $self.

Write inline comment explaining current status of 'our' variables.

8 years agoMove $Interfaces into $self, but as $self->{interfaces}
James E. Keenan [Tue, 30 Mar 2010 12:34:02 +0000 (08:34 -0400)] 
Move $Interfaces into $self, but as $self->{interfaces}

... to avoid confusion with %Interfaces. (But note we already have
$self->{interface}. This will have to be fixed.)

8 years agoMove $DoSetMagic, $XsubAliases, into $self.
James E. Keenan [Tue, 30 Mar 2010 12:07:29 +0000 (08:07 -0400)] 
Move $DoSetMagic, $XsubAliases, into $self.

The latter is called 'xsubaliases', the change of casing
anticipating confusion with %XsubAliases.

8 years agoTidy up lists of 'our' variables.
James E. Keenan [Mon, 29 Mar 2010 02:11:33 +0000 (22:11 -0400)] 
Tidy up lists of 'our' variables.

8 years agoMove $condnum, $cond, into $self. $ALIAS ran into eval EXPR problems.
James E. Keenan [Mon, 29 Mar 2010 02:07:45 +0000 (22:07 -0400)] 
Move $condnum, $cond, into $self. $ALIAS ran into eval EXPR problems.

8 years agoMove $func_args into $self.
James E. Keenan [Mon, 29 Mar 2010 01:39:49 +0000 (21:39 -0400)] 
Move $func_args into $self.

8 years agoMove $RETVAL_code into $self.
James E. Keenan [Mon, 29 Mar 2010 01:22:23 +0000 (21:22 -0400)] 
Move $RETVAL_code into $self.

8 years agoMove $gotRETVAL into $self.
James E. Keenan [Mon, 29 Mar 2010 00:35:36 +0000 (20:35 -0400)] 
Move $gotRETVAL into $self.

8 years agoMove $deferred into $self.
James E. Keenan [Mon, 29 Mar 2010 00:23:56 +0000 (20:23 -0400)] 
Move $deferred into $self.

8 years agoEliminate 'our' $printed_name
James E. Keenan [Sun, 28 Mar 2010 17:31:29 +0000 (13:31 -0400)] 
Eliminate 'our' $printed_name

Replace it with a 'my' variable declared inside INPUT_handler().
Permissible, because $printed_name is explicitly passed to subs
called from within INPUT_handler() and only there.