Cherry-pick Scalar-List-Utils tainted.t fix from upstream
authorDagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Thu, 26 Jan 2017 09:17:41 +0000 (09:17 +0000)
committerDagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Thu, 26 Jan 2017 09:22:06 +0000 (09:22 +0000)
It's fixed properly upstream, by using $^X instead of %ENV, so use that
instead of the now-expired skip.

Porting/Maintainers.pl
cpan/Scalar-List-Utils/t/tainted.t
t/porting/customized.dat

index 5e94e19..4c77db8 100755 (executable)
@@ -1011,6 +1011,7 @@ use File::Glob qw(:case);
             'lib/Sub/Util.pm',     # CPAN RT 118470
             't/lln.t',             # CPAN RT 118470
             't/uniq.t',            # CPAN RT 118470
+            't/tainted.t',         # CPAN RT 119169
         ],
     },
 
index 9e0df5e..fb83c86 100644 (file)
@@ -13,15 +13,10 @@ my $var = 2;
 
 ok( !tainted($var), 'known variable');
 
-my $key = (grep { !/^PERL/ } keys %ENV)[0];
+ok( tainted($^X),      'interpreter variable');
 
-SKIP: { # Skip these to get blead to pass, but the skip expires soon
-skip 'is randomly failing', 2 unless $] gt 5.025009;
-ok( tainted($ENV{$key}),       'environment variable');
-
-$var = $ENV{$key};
-ok( tainted($var),     'copy of environment variable');
-}
+$var = $^X;
+ok( tainted($var),     'copy of interpreter variable');
 
 {
     package Tainted;
index f5a5a31..91991b2 100644 (file)
@@ -52,6 +52,7 @@ Scalar-List-Utils cpan/Scalar-List-Utils/lib/List/Util/XS.pm 2d09b84a5575e678346
 Scalar-List-Utils cpan/Scalar-List-Utils/lib/Scalar/Util.pm 98af8fe390d9c9fa11a1fafebbc68ea663cdce2c
 Scalar-List-Utils cpan/Scalar-List-Utils/lib/Sub/Util.pm 188cf0dd95cd7ba60fd6a366f440811fb52c2c79
 Scalar-List-Utils cpan/Scalar-List-Utils/t/lln.t b7148c7f1cd9c70fd21d8153542b6d3de2b655ad
+Scalar-List-Utils cpan/Scalar-List-Utils/t/tainted.t 9c52e04687ec8a7d23a1c38a762723858305b1fe
 Scalar-List-Utils cpan/Scalar-List-Utils/t/uniq.t 5de01094d2bca9cf8b2bbbca920122f7396bf11e
 Socket cpan/Socket/Socket.pm 98e38176d745c38282907f391c077298f5a3d0ba
 Socket cpan/Socket/Socket.xs edd4fed212785f11c5c2095a75941dad27d586d9