21 months agoAdd the 5.17.7 epigraph to epigraphs.pod v5.17.7.0
Dave Rolsky [Tue, 18 Dec 2012 22:02:34 +0000]
Add the 5.17.7 epigraph to epigraphs.pod

21 months agoAdd known t/op/require_errors.t failure to known problems v5.17.7
Dave Rolsky [Tue, 18 Dec 2012 21:37:35 +0000]
Add known t/op/require_errors.t failure to known problems

21 months agoAdd 5.17.7 to perlhist
Dave Rolsky [Tue, 18 Dec 2012 16:57:02 +0000]
Add 5.17.7 to perlhist

21 months agoUpdate Module::CoreList for 5.17.7
Dave Rolsky [Tue, 18 Dec 2012 16:55:48 +0000]
Update Module::CoreList for 5.17.7

21 months agoThe 23b7025ebc commit is sufficiently documented in perldelta
Dave Rolsky [Tue, 18 Dec 2012 16:54:21 +0000]
The 23b7025ebc commit is sufficiently documented in perldelta

21 months agoBetter description of hash assignment bug fixes
Dave Rolsky [Mon, 17 Dec 2012 21:32:35 +0000]
Better description of hash assignment bug fixes

21 months agoClarify hash assignment bug fix in list context
Dave Rolsky [Mon, 17 Dec 2012 21:31:26 +0000]
Clarify hash assignment bug fix in list context

21 months agoTrim description of one bug fix in perldelta
Dave Rolsky [Mon, 17 Dec 2012 21:26:08 +0000]
Trim description of one bug fix in perldelta

21 months agoAdd more build configurations to test in the RMG
Dave Rolsky [Mon, 17 Dec 2012 20:03:49 +0000]
Add more build configurations to test in the RMG

21 months agoAdd placeholder for additional 23b7025ebc changes in case no one gets back to me
Dave Rolsky [Mon, 17 Dec 2012 19:38:26 +0000]
Add placeholder for additional 23b7025ebc changes in case no one gets back to me

21 months agoAdd an =item marker for sub-list in perldelta
Dave Rolsky [Mon, 17 Dec 2012 19:37:39 +0000]
Add an =item marker for sub-list in perldelta

21 months agoAdd delta for Storable & Locale::Maketext security issues
Dave Rolsky [Mon, 17 Dec 2012 19:24:42 +0000]
Add delta for Storable & Locale::Maketext security issues

21 months agoFix typo in Locale-Maketext ChangeLog
Dave Rolsky [Mon, 17 Dec 2012 19:18:52 +0000]
Fix typo in Locale-Maketext ChangeLog

21 months agoFix some weird formatting in perldelta
Dave Rolsky [Mon, 17 Dec 2012 19:09:01 +0000]
Fix some weird formatting in perldelta

21 months agos/5.17.5/5.17.6/ in the INSTALL document
Dave Rolsky [Mon, 17 Dec 2012 18:25:53 +0000]
s/5.17.5/5.17.6/ in the INSTALL document

21 months agoAdd the generated Acknowledgements section to perldelta
Dave Rolsky [Mon, 17 Dec 2012 18:23:42 +0000]
Add the generated Acknowledgements section to perldelta

21 months agoRemove all the boilerplate notes from perldelta
Dave Rolsky [Mon, 17 Dec 2012 18:21:17 +0000]
Remove all the boilerplate notes from perldelta

21 months agoLook up RT authors in the DATA section aliases as well as AUTHORS
Dave Rolsky [Mon, 17 Dec 2012 18:20:47 +0000]
Look up RT authors in the DATA section aliases as well as AUTHORS

This patch is a little gross but if fixes a bug where an author wasn't found
at all. The author in question was in the git log as "bulk88 (via RT)
<perlbug-followup@perl.org>". Note the lack of a name before the "(via RT)"
part.

This whole thing is a bit of a mess. I think this whole script could be
re-organized in a simpler way, perhaps.

21 months agoWork in progress on perldelta for 23b7025ebc
Dave Rolsky [Mon, 17 Dec 2012 17:46:13 +0000]
Work in progress on perldelta for 23b7025ebc

I still need to figure out what some of the changes described in
http://www.nntp.perl.org/group/perl.perl5.porters/2012/10/msg194211.html
actually mean.

21 months agouse PERL_UNUSED_VAR rather than PERL_UNUSED_DECL
David Mitchell [Mon, 17 Dec 2012 14:53:11 +0000]
use PERL_UNUSED_VAR rather than PERL_UNUSED_DECL

PERL_UNUSED_DECL doesn't do anything under g++, so doing this silences
some g++ warnings.

21 months agoUpdate ExtUtils-MakeMaker to CPAN version 6.64
Chris 'BinGOs' Williams [Mon, 17 Dec 2012 09:46:37 +0000]
Update ExtUtils-MakeMaker to CPAN version 6.64

  [DELTA]

  6.64  Sun Dec 16 18:27:40 PST 2012
    Build Fixes
    * Update the home page in the meta file.  makemaker.org has been
      unmaintained for a while.

  6.63_04  Thu Nov 22 13:18:06 PST 2012
    Test Fixes
    * Eliminated the problematic and not very useful PASTHRU test
      on Windows.  A better test will come after stable. [github 41]
      (Michael G Schwern)
    * Avoid a new regex warning in 5.17.x in t/MM_OS2.t. (Craig A. Berry)

    VMS Fixes
    * Better ignore files due to non-case-preserving filesystems.
      (Craig A. Berry)

21 months agoUpdate Scalar-List-Utils to CPAN version 1.26
Chris 'BinGOs' Williams [Mon, 17 Dec 2012 09:35:15 +0000]
Update Scalar-List-Utils to CPAN version 1.26

  [DELTA]

  1.26 -- Sun Dec 16 19:39

    * Merge patch from JDHEDDEN - Add Scalar::Util::isdual() RT#76150

  1.25_01 -- Wed Nov 21 09:47

    * Fix a hash order dependency bug t/tainted.t
      (Currently this is a core only version to fix perl5 smokes)

21 months agoGDBM_File must cast fatal_func appropriately for the version of gdbm.h
Nicholas Clark [Mon, 17 Dec 2012 09:31:11 +0000]
GDBM_File must cast fatal_func appropriately for the version of gdbm.h

The fifth argument to gdbm_open() is an optional callback function for fatal
errors. The prototype for this function has changed between gdbm 1.8.3 and
1.9.0, from void (*)() to void(*)(const char *). This distinction doesn't
matter to a C compiler, but does to a C++ compiler, which we use to test the
core build. So, cast appropriately, depending on the version macros in
gdbm.h

21 months agoskip the \N{...} unloaded charnames croak test when PERL_UNICODE set
Tony Cook [Mon, 17 Dec 2012 09:06:47 +0000]
skip the \N{...} unloaded charnames croak test when PERL_UNICODE set

This has been causing failures for a while.

21 months agoSKIP in run_multiple_progs() was parsed but unimplemented, implement it
Tony Cook [Mon, 17 Dec 2012 09:05:56 +0000]
SKIP in run_multiple_progs() was parsed but unimplemented, implement it

21 months agofix the debugger t expr command regression
Tony Cook [Mon, 17 Dec 2012 08:19:32 +0000]
fix the debugger t expr command regression

21 months agorough TODO test for t expr
Tony Cook [Mon, 17 Dec 2012 08:09:34 +0000]
rough TODO test for t expr

21 months agoMake DosGlob.t more resilient
Father Chrysostomos [Mon, 17 Dec 2012 01:00:45 +0000]
Make DosGlob.t more resilient

If the sv count goes *down* (which doesn’t happen on my machine, but see
<CANgJU+W8_nVg9-YVRBe2r=ZYCbu9-R3RPf0tbH-XWrtVxYhGpA@mail.gmail.com>), we
certainly don’t have a leak.

21 months agoperl5180delta: Mention 2 more broken+patched modules
Father Chrysostomos [Sun, 16 Dec 2012 14:21:02 +0000]
perl5180delta: Mention 2 more broken+patched modules

21 months agoeliminate PL_regsize
David Mitchell [Sat, 15 Dec 2012 00:31:40 +0000]
eliminate PL_regsize

This var (or rather PL_reg_state.re_state_regsize, which it is #deffed to)
just holds the index of the maximum opening paren index seen so far in
S_regmatch(). So make it a local var of S_regmatch() and pass it as a
param to the couple of static functions called from there that need it.

(Also give the local var the more meaningful name 'maxopenparen'.)

21 months agomktables, regexec.c: Comments, white-space; no code changes
Karl Williamson [Sun, 16 Dec 2012 18:57:09 +0000]
mktables, regexec.c: Comments, white-space; no code changes

21 months agoRename property involved in \X matching, for clarity
Karl Williamson [Sun, 16 Dec 2012 18:50:34 +0000]
Rename property involved in \X matching, for clarity

I was re-reading some code and got confused.  This table matches just
the first character of a sequence that may or may not contain others.

21 months agoregen/unicode_constants.pl: Add option to skip if undef
Karl Williamson [Sun, 16 Dec 2012 15:56:28 +0000]
regen/unicode_constants.pl: Add option to skip if undef

I thought I would need this new functionality in this regen script, but
ended up going a different route.  But just in case someone might find
this useful in the future, here it is.

21 months agoregexec.c: More efficient Korean \X processing
Karl Williamson [Sat, 15 Dec 2012 16:53:19 +0000]
regexec.c: More efficient Korean \X processing

This refactors the code slightly that checks for Korean precomposed
syllables in \X.  It eliminates the PL_variable formerly used to keep
track of things.

21 months agoregexec.c: Move #defines to earlier in the file
Karl Williamson [Sat, 15 Dec 2012 16:42:36 +0000]
regexec.c: Move #defines to earlier in the file

They will be used in a later commit earlier.  This also changes the
wording of the comment slightly to give more explanation, since the
context they are now found in is different

21 months agoAdded Sergey Alekseev to AUTHORS
Chris 'BinGOs' Williams [Sun, 16 Dec 2012 10:31:07 +0000]
Added Sergey Alekseev to AUTHORS

21 months agoCorrect typo in perlreftut
Sergey Alekseev [Sun, 16 Dec 2012 10:29:31 +0000]
Correct typo in perlreftut

Signed-off-by: Chris 'BinGOs' Williams <chris@bingosnet.co.uk>

21 months agoadd lib/File/DosGlob.pm to .gitignore
Yves Orton [Sat, 15 Dec 2012 21:09:36 +0000]
add lib/File/DosGlob.pm to .gitignore

The master version of the file now lives in ext

21 months agoFix missing argument in sprintf in Socket.xs
Yves Orton [Sat, 15 Dec 2012 20:59:43 +0000]
Fix missing argument in sprintf in Socket.xs

Shows up as:
  Socket.xs:919:16: warning: more '%' conversions than data arguments [-Wformat]
  Socket.xs:925:16: warning: more '%' conversions than data arguments [-Wformat]

This bumps the version as well.

21 months agoSilence a warning under clang/asan
Yves Orton [Sat, 15 Dec 2012 20:55:47 +0000]
Silence a warning under clang/asan

This should silence the following warning:

dump.c:459:57: warning: comparison of constant 85 with expression of
   type 'svtype' is always false [-Wtautological-constant-out-of-range-compare]

The warning is a false positive, this code is /meant/ to detect
conditions that should not happen.

21 months agoUpdate IO-Compress to CPAN version 2.059
Chris 'BinGOs' Williams [Sat, 15 Dec 2012 19:50:36 +0000]
Update IO-Compress to CPAN version 2.059

  [DELTA]

  2.059 10 December 2012

      * IO::Compress::Base
        Added "Encode" option.

21 months agoAdd regression tests for split on string of single wordspace or hex20.
James E Keenan [Sat, 15 Dec 2012 03:00:22 +0000]
Add regression tests for split on string of single wordspace or hex20.

For:  RT #116086

21 months agoperldelta: Add to-do note for hash changes
Father Chrysostomos [Sat, 15 Dec 2012 14:56:03 +0000]
perldelta: Add to-do note for hash changes

I don’t have time for this right now, and I might not for two or three
days, so make sure it is not forgotten.

21 months agoperldelta for glob changes
Father Chrysostomos [Sat, 15 Dec 2012 14:54:05 +0000]
perldelta for glob changes

21 months agoknown_pod_issues.dat: Allow links to Devel::Callsite
Father Chrysostomos [Sat, 15 Dec 2012 14:53:24 +0000]
known_pod_issues.dat: Allow links to Devel::Callsite

21 months agoperldelta for bb4784f00 (Constant(undef))
Father Chrysostomos [Sat, 15 Dec 2012 14:45:57 +0000]
perldelta for bb4784f00 (Constant(undef))

21 months agoperldelta for 67a057d6d8 (charnames crash)
Father Chrysostomos [Sat, 15 Dec 2012 14:42:46 +0000]
perldelta for 67a057d6d8 (charnames crash)

21 months agoperldelta for 230834321 (renamed stashes; m??; reset)
Father Chrysostomos [Sat, 15 Dec 2012 14:40:40 +0000]
perldelta for 230834321 (renamed stashes; m??; reset)

21 months agoperldelta for 55b37f1c31 (goto $tied)
Father Chrysostomos [Sat, 15 Dec 2012 14:38:46 +0000]
perldelta for 55b37f1c31 (goto $tied)

21 months agoperldelta for f5eec17c/#115818
Father Chrysostomos [Sat, 15 Dec 2012 14:37:33 +0000]
perldelta for f5eec17c/#115818

21 months agoperldelta for 90b58ec9e (deprecate lexical $_)
Father Chrysostomos [Sat, 15 Dec 2012 14:36:02 +0000]
perldelta for 90b58ec9e (deprecate lexical $_)

21 months agoperldelta for 4e52a9b69 and db9306af4 (local *method=...)
Father Chrysostomos [Sat, 15 Dec 2012 14:25:50 +0000]
perldelta for 4e52a9b69 and db9306af4 (local *method=...)

21 months agoperldelta: 3d460042 fixed more local *ISA bugs
Father Chrysostomos [Sat, 15 Dec 2012 14:23:43 +0000]
perldelta: 3d460042 fixed more local *ISA bugs

21 months agoperldelta for 959f7ad7 (local *Detached::method)
Father Chrysostomos [Sat, 15 Dec 2012 14:22:57 +0000]
perldelta for 959f7ad7 (local *Detached::method)

21 months agoperldelta for 978a498e (PL_sub_generation++)
Father Chrysostomos [Sat, 15 Dec 2012 14:20:12 +0000]
perldelta for 978a498e (PL_sub_generation++)

21 months agoperldelta for 6e1b2de7 (localised glob assignment)
Father Chrysostomos [Sat, 15 Dec 2012 14:17:49 +0000]
perldelta for 6e1b2de7 (localised glob assignment)

21 months agoperldelta for cows sawing ampersands
Father Chrysostomos [Sat, 15 Dec 2012 14:12:25 +0000]
perldelta for cows sawing ampersands

21 months agoperldelta for de0df3c09/#23180
Father Chrysostomos [Sat, 15 Dec 2012 13:55:26 +0000]
perldelta for de0df3c09/#23180

21 months agoperldelta for ee0832cea (lexical constant warnings)
Father Chrysostomos [Sat, 15 Dec 2012 13:50:57 +0000]
perldelta for ee0832cea (lexical constant warnings)

21 months agoperldelta for 4ded55f35 (lexical constants)
Father Chrysostomos [Sat, 15 Dec 2012 13:50:00 +0000]
perldelta for 4ded55f35 (lexical constants)

21 months agoperldelta for lexsub warnings
Father Chrysostomos [Sat, 15 Dec 2012 13:48:22 +0000]
perldelta for lexsub warnings

21 months agoperldelta: Blanket entry for memory leaks
Father Chrysostomos [Sat, 15 Dec 2012 13:41:46 +0000]
perldelta: Blanket entry for memory leaks

21 months agoperldelta for f6f93f805 (circular blessings)
Father Chrysostomos [Sat, 15 Dec 2012 13:38:07 +0000]
perldelta for f6f93f805 (circular blessings)

21 months agoperldelta for 2f43ddf1e (sort {undef})
Father Chrysostomos [Sat, 15 Dec 2012 13:35:20 +0000]
perldelta for 2f43ddf1e (sort {undef})

21 months agoUse SvREFCNT_dec_NN in one place in hv.h
Father Chrysostomos [Thu, 13 Dec 2012 14:05:33 +0000]
Use SvREFCNT_dec_NN in one place in hv.h

In this instance, we know that av is not null, so no need to check
whether it is

21 months agoleakfinder.pl: exceptions
Father Chrysostomos [Thu, 13 Dec 2012 13:46:09 +0000]
leakfinder.pl: exceptions

21 months agoUpdate Unicode-Collate to CPAN version 0.96
Chris 'BinGOs' Williams [Sat, 15 Dec 2012 13:29:13 +0000]
Update Unicode-Collate to CPAN version 0.96

  [DELTA]

  0.96  Sat Dec 15 19:43:10 2012
    - special noncharancter tailorings ('highestFFFF' and 'minimalFFFE')
      * some locales are modified for 'highestFFFF': as, bn, fa, gu, hi, hy,
        kn, kok, mr, or, sa, si, si_dict, ta, te, th, ur.
    - U::C::Locale now allows 'entry' to add or override mappings.
    - bug fix: using DUCET through XS wrongly prevented completely ignorable
      characters from tailoring.
    - modified tests: default.t, loc_as.t, loc_bn.t, loc_fa.t, loc_gu.t,
      loc_hi.t, loc_hy.t, loc_kn.t, loc_kok.t, loc_mr.t, loc_or.t, loc_sa.t,
      loc_si.t, loc_sidt.t, loc_ta.t, loc_te.t, loc_test.t, loc_th.t,
      loc_ur.t, nonchar.t in t.

21 months agot/op/inc.t: Add descriptions to all tests lacking them.
James E Keenan [Mon, 10 Dec 2012 01:13:56 +0000]
t/op/inc.t: Add descriptions to all tests lacking them.

21 months agot/op/grent.t: Provide descriptions for tests lacking them.
James E Keenan [Sun, 9 Dec 2012 22:25:49 +0000]
t/op/grent.t: Provide descriptions for tests lacking them.

21 months agot/op/goto.t: Provide descriptions for remaining tests lacking them.
James E Keenan [Sun, 9 Dec 2012 14:27:28 +0000]
t/op/goto.t: Provide descriptions for remaining tests lacking them.

Focus of these descriptions:  Simply enable user to more easily locate tests
in file.

21 months agot/op/filetest.t: Provide descriptions for remaining tests lacking them.
James E Keenan [Sun, 9 Dec 2012 14:03:21 +0000]
t/op/filetest.t: Provide descriptions for remaining tests lacking them.

21 months agot/op/filehandle.t: Provide descriptions for all tests.
James E Keenan [Sun, 9 Dec 2012 13:26:21 +0000]
t/op/filehandle.t: Provide descriptions for all tests.

Remove misleading inline comment (dupe of comment in t/op/filetest.t).

21 months agot/op/each_array.t: Provide descriptions for all tests.
James E Keenan [Sun, 9 Dec 2012 03:18:03 +0000]
t/op/each_array.t: Provide descriptions for all tests.

21 months agot/op/dor.t: Provide descriptions for tests still lacking them.
James E Keenan [Sat, 8 Dec 2012 20:50:18 +0000]
t/op/dor.t: Provide descriptions for tests still lacking them.

21 months agot/op/die_unwind.t: Provide descriptions for some tests.
James E Keenan [Sat, 8 Dec 2012 20:38:56 +0000]
t/op/die_unwind.t: Provide descriptions for some tests.

21 months agot/op/die_except.t: Add description for each test.
James E Keenan [Sat, 8 Dec 2012 20:09:57 +0000]
t/op/die_except.t: Add description for each test.

21 months agofurther fix to SvUPGRADE
David Mitchell [Fri, 14 Dec 2012 21:28:02 +0000]
further fix to SvUPGRADE

The change to SvUPGRADE introduced by 463ea2290a54e a few commits ago
to silence a warning with clang, broke g++ builds instead. Here's
a second attempt to keep everyone happy.

Basically it avoids warnings from all of gcc, g++ and clang for the two
constructs

    SvUPGRADE(...);
    (void)SvUPGRADE(...);

But still breaks

    if (!SvUPGRADE(...) { croak(...); }

which I don't care about.

21 months agoAdd diagnostics for PERL_HASH_SEED warning
Yves Orton [Fri, 14 Dec 2012 22:14:48 +0000]
Add diagnostics for PERL_HASH_SEED warning

21 months agoUse the right warn routine
Yves Orton [Fri, 14 Dec 2012 21:34:26 +0000]
Use the right warn routine

21 months agowarn if PERL_HASH_SEED contains an unexpected character
Yves Orton [Fri, 14 Dec 2012 20:44:07 +0000]
warn if PERL_HASH_SEED contains an unexpected character

21 months agoslight update to perldelta for SvUPGRADE
David Mitchell [Fri, 14 Dec 2012 15:36:11 +0000]
slight update to perldelta for SvUPGRADE

21 months agomake SvUPGRADE() a statement.
David Mitchell [Fri, 14 Dec 2012 15:05:40 +0000]
make SvUPGRADE() a statement.

To guote the perldelta entry:

SvUPGRADE() is no longer an expression. Originally this macro (and its
underlying function, sv_upgrade()) were documented as boolean, although
in reality they always croaked on error and never returned false. In 2005
the documentation was updated to specify a void return value, but
SvUPGRADE() was left always returning 1 for backwards compatibility. This
has now been removed, and SvUPGRADE() is now a statement with no return
value.

So this is now a syntax error:

    if (!SvUPGRADE(sv)) { croak(...); }

If you have code like that, simply replace it with

    SvUPGRADE(sv);

21 months agoMore fun escaping dots in tovmsspec.
Craig A. Berry [Fri, 14 Dec 2012 14:29:55 +0000]
More fun escaping dots in tovmsspec.

c1abd561a0a322 avoided the double escaping of dots in filenames,
but failed to copy the dot itself in cases where it was already
escaped.  Plus, when not using extended file specifications and
thus converting the dot to an underscore, we need to make sure
the underscore is not escaped.

And add a test that covers most of these scenarios.  Probably
more tests are needed.

21 months agoregcomp.c: silence some compiler warnings
David Mitchell [Fri, 14 Dec 2012 11:55:45 +0000]
regcomp.c: silence some compiler warnings

ReREFCNT_inc() returns a value, so cast it to void where not used.

21 months agoTypemap.xs: fix warning under clang
David Mitchell [Fri, 14 Dec 2012 11:50:08 +0000]
Typemap.xs: fix warning under clang

Trivial type issue in croak format

21 months agoRemove BeOS special-casing from Configure.
Nicholas Clark [Thu, 29 Nov 2012 12:30:19 +0000]
Remove BeOS special-casing from Configure.

21 months agoRemove the BeOS port.
Nicholas Clark [Thu, 29 Nov 2012 12:17:31 +0000]
Remove the BeOS port.

BeOS was an operating system for personal computers developed by Be Inc,
initially for their BeBox hardware. The OS Haiku was written as an open source
replacement/continuation for BeOS, and its perl port is current and actively
maintained.

The BeOS port has not been updated since 2004.

21 months agoNote the GDBM_File changes in perldelta.
Nicholas Clark [Thu, 13 Dec 2012 16:16:52 +0000]
Note the GDBM_File changes in perldelta.

21 months agoEliminate the fifth argument from GDBM_File::TIEHASH.
Nicholas Clark [Thu, 13 Dec 2012 16:06:26 +0000]
Eliminate the fifth argument from GDBM_File::TIEHASH.

This was intended to provide control of the callback used by gdbm* functions
in case of fatal errors (such as filesystem problems), but did not work (and
could never have worked). No code on CPAN even attempted to use it. The
callback is now always the previous default, croak.

This eliminates the only used of 'FATALFUNC' in the *DBM modules' type
files, so remove it from all of them.

It also eliminates a cast from a data pointer to a function pointer, which
is not legal C, and rightly upsets pedantic ANSI C compilers. The fact that
there was exactly cast, and only in one direction, gives a clue as to how
likely this was ever to work.

21 months agoGDBM_File is meant to croak() if the gdbm library has a fatal error.
Nicholas Clark [Thu, 13 Dec 2012 15:38:17 +0000]
GDBM_File is meant to croak() if the gdbm library has a fatal error.

gdbm_open() takes a fifth argument, for an optional callback function used
to report a fatal error. Since it was added in 5.000, the tied hash wrapper
implemented in GDBM_File.xs has (intended) to default this to croak().
However, the callback expects a function taking a single const char *
argument, whereas croak(const char *pat, ...) has variable arguments.
The code as-was had two bugs

1) The calling ABI on some platforms differs between a (known) variable-
   argument function, and one which takes (known) fixed arguments. As the
   call site knows the pointer is to a function with fixed arguments, the
   calling convention it uses doesn't match what Perl_croak_nocontext()
   expects, which can lead to crashes.
2) A message containing % characters will be interpreted as a printf format.

Both these are fixed by using a small station function as a wrapper, which
takes a single string argument, and passes to croak() a "%s" format string,
followed by the string for the error message.

Add a test for this functionality.

21 months agoB.xs: silence clang warning
David Mitchell [Thu, 13 Dec 2012 13:24:58 +0000]
B.xs: silence clang warning

PADOFFSET is unsigned, so checking that it's >= 0 is pointless.

21 months agochdir's argument is a directory in DosGlob.t.
Craig A. Berry [Thu, 13 Dec 2012 13:10:17 +0000]
chdir's argument is a directory in DosGlob.t.

It probably doesn't matter anywhere but VMS, but on VMS,
disk:[dir.blead]t (the result of catfile) is an invalid argument to
chdir, but disk:[dir.blead.t] (the result of catdir) is correct.

21 months agoSigh. Fix lex.t again
Father Chrysostomos [Thu, 13 Dec 2012 13:26:56 +0000]
Sigh. Fix lex.t again

PERL_UNICODE can cause things to happen in a different order
internally.

21 months ago{Dos,}Glob.xs: Skip freeing during global destruction
Father Chrysostomos [Thu, 13 Dec 2012 02:09:57 +0000]
{Dos,}Glob.xs: Skip freeing during global destruction

See ticket #116064.

File::Glob and ::DosGlob free data associated with a calling op when
that op is freed.

During global destruction, there is no need to do that, as it will be
freed anyway.

Also, during sv_clean_all dMY_CXT can cause us to read freed memory.

21 months agoFix occasional failures in svleak.t and DosGlob.t
Father Chrysostomos [Thu, 13 Dec 2012 01:55:06 +0000]
Fix occasional failures in svleak.t and DosGlob.t

If the random number of ops happens to be 0 the first time, then we
end up with a false positive, as evaluating '$x+<*>' after '<*>' will
vivify the *x glob.

21 months agoleakfinder.pl: More exceptions
Father Chrysostomos [Tue, 11 Dec 2012 13:51:03 +0000]
leakfinder.pl: More exceptions

21 months agoperl.h: fix signedness warning with clang
David Mitchell [Wed, 12 Dec 2012 10:34:29 +0000]
perl.h: fix signedness warning with clang

'len' arg to my_vsnprintf() is supposed to be Size_t; cast it that way
before testing it.

21 months agoIn DosGlob.xs, add a block around MY_CXT_INIT, as it contains a declaration.
Nicholas Clark [Wed, 12 Dec 2012 09:18:21 +0000]
In DosGlob.xs, add a block around MY_CXT_INIT, as it contains a declaration.

The macro MY_CXT_INIT contains a variable declaration, and xsubpp doesn't
wrap XS BOOT sections within a block, hence code at the start of the BOOT
section may already be after code. Hence wrap MY_CXT_INIT within a block, to
ensure that its initialisation is before any code.

21 months agoData::Dumper is at 2.139
Steffen Mueller [Wed, 12 Dec 2012 06:35:21 +0000]
Data::Dumper is at 2.139

21 months agoBring Data::Dumper version and changelog up to date with CPAN release
Steffen Mueller [Wed, 12 Dec 2012 06:33:33 +0000]
Bring Data::Dumper version and changelog up to date with CPAN release

The 2.139 CPAN release just went out. It has the same code that is in
blead now, but it has distribution fixes on top of blead that wouldn't
make sense here. This bumps the version and imports the change log.