[rt #103222] make Internals::SvREFCNT set/get consistent

diff --git a/lib/Internals.t b/lib/Internals.t
index b0d5bda..d6c2367 100644 (file)
--- a/lib/Internals.t
+++ b/lib/Internals.t
@@ -7,7 +7,7 @@ BEGIN {
     }
 }
 
-use Test::More tests => 74;
+use Test::More tests => 76;
 
 my $ro_err = qr/^Modification of a read-only value attempted/;
 
@@ -163,3 +163,7 @@ is(  Internals::SvREFCNT($foo[2]), 1 );
 is(  Internals::SvREFCNT(%foo), 1 );
 is(  Internals::SvREFCNT($foo{foo}), 1 );
 
+is(  Internals::SvREFCNT($foo, 2), 2, "update ref count");
+is(  Internals::SvREFCNT($foo), 2, "check we got the stored value");
+
+Internals::SvREFCNT($foo, 1 );

diff --git a/universal.c b/universal.c
index d623a67..0599e67 100644 (file)
--- a/universal.c
+++ b/universal.c
@@ -927,8 +927,8 @@ XS(XS_Internals_SvREFCNT)   /* This is dangerous stuff. */
         XSRETURN_IV(SvREFCNT(sv) - 1); /* Minus the ref created for us. */
     else if (items == 2) {
          /* I hope you really know what you are doing. */
-        SvREFCNT(sv) = SvIV(ST(1));
-        XSRETURN_IV(SvREFCNT(sv));
+        SvREFCNT(sv) = SvIV(ST(1)) + 1; /* we free one ref on exit */
+        XSRETURN_IV(SvREFCNT(sv) - 1);
     }
     XSRETURN_UNDEF; /* Can't happen. */
 }